1.add HTTPError;2.rename ParseParamSuccess to ParseParamFail

request/error.go

@@ -0,0 +1,5 @@
+package request
+
+type HTTPError struct {
+	Msg string `json:"msg" example:"status bad request"`
+}

request/request.go

@@ -4,6 +4,7 @@ import (
 	"net/http"
 	"runtime"
 
+	"fmt"
 	"github.com/gin-gonic/gin"
 	"github.com/sirupsen/logrus"
 )
@@ -12,24 +13,24 @@ type Checker interface {
 	Check() error
 }
 
-func ParseParamSuccess(ctx *gin.Context, r interface{}, fs ...func() error) bool {
+func ParseParamFail(ctx *gin.Context, r interface{}, fs ...func() error) bool {
 	if r != nil {
 		if Fail(ctx, http.StatusBadRequest, ctx.ShouldBind(r)) {
-			return false
+			return true
 		}
 
 		if checker, ok := r.(Checker); ok {
-			return !Fail(ctx, http.StatusBadRequest, checker.Check())
+			return Fail(ctx, http.StatusBadRequest, checker.Check())
 		}
 	}
 
 	for _, f := range fs {
 		if Fail(ctx, http.StatusBadRequest, f()) {
-			return false
+			return true
 		}
 	}
 
-	return true
+	return false
 }
 
 func Fail(ctx *gin.Context, status int, err error) bool {
@@ -37,7 +38,7 @@ func Fail(ctx *gin.Context, status int, err error) bool {
 		return false
 	}
 
-	ctx.JSON(status, gin.H{"msg": err.Error()})
+	ctx.JSON(status, HTTPError{Msg: err.Error()})
 
 	if status == http.StatusInternalServerError {
 		_, file, line, _ := runtime.Caller(1)
@@ -59,6 +60,6 @@ func Success(ctx *gin.Context, data interface{}) {
 	case "POST":
 		ctx.JSON(http.StatusCreated, data)
 	default:
-		ctx.JSON(http.StatusBadRequest, gin.H{"msg": "unsupported request method" + ctx.Request.Method})
+		ctx.JSON(http.StatusBadRequest, HTTPError{Msg: fmt.Sprintf("unsupported request method %s", ctx.Request.Method)})
 	}
 }