Disabled implicit casts and dynamic; fixed analysis issues

packages/notus/analysis_options.yaml

@@ -1,11 +1,12 @@
 analyzer:
-  language:
-    enableSuperMixins: true
-
+  strong-mode:
+    implicit-casts: false
+    implicit-dynamic: false
+    
 # Lint rules and documentation, see http://dart-lang.github.io/linter/lints
 linter:
   rules:
-    # - avoid_init_to_null
+    - avoid_init_to_null
     - cancel_subscriptions
     - close_sinks
     - directives_ordering

packages/zefyr/analysis_options.yaml

@@ -1,11 +1,12 @@
 analyzer:
-  language:
-#    enableSuperMixins: true
+  strong-mode:
+    implicit-casts: false
+    implicit-dynamic: false
 
 # Lint rules and documentation, see http://dart-lang.github.io/linter/lints
 linter:
   rules:
-    # - avoid_init_to_null
+    - avoid_init_to_null
     - cancel_subscriptions
     - close_sinks
     - directives_ordering

packages/zefyr/lib/src/widgets/editable_text.dart

@@ -1,7 +1,6 @@
 // Copyright (c) 2018, the Zefyr project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
-import 'package:collection/collection.dart';
 import 'package:flutter/cupertino.dart';
 import 'package:flutter/widgets.dart';
 import 'package:notus/notus.dart';
@@ -10,7 +9,6 @@ import 'code.dart';
 import 'common.dart';
 import 'controller.dart';
 import 'cursor_timer.dart';
-import 'editable_box.dart';
 import 'editor.dart';
 import 'image.dart';
 import 'input.dart';
@@ -197,13 +195,13 @@ class _ZefyrEditableTextState extends State<ZefyrEditableText>
     final BlockNode block = node;
     final blockStyle = block.style.get(NotusAttribute.block);
     if (blockStyle == NotusAttribute.block.code) {
-      return new ZefyrCode(node: node);
+      return new ZefyrCode(node: block);
     } else if (blockStyle == NotusAttribute.block.bulletList) {
-      return new ZefyrList(node: node);
+      return new ZefyrList(node: block);
     } else if (blockStyle == NotusAttribute.block.numberList) {
-      return new ZefyrList(node: node);
+      return new ZefyrList(node: block);
     } else if (blockStyle == NotusAttribute.block.quote) {
-      return new ZefyrQuote(node: node);
+      return new ZefyrQuote(node: block);
     }
 
     throw new UnimplementedError('Block format $blockStyle.');

packages/zefyr/lib/src/widgets/editor.dart

@@ -61,7 +61,7 @@ class _ZefyrEditorState extends State<ZefyrEditor> {
     _toolbarKey = null;
   }
 
-  Widget buildToolbar(BuildContext) {
+  Widget buildToolbar(BuildContext context) {
     return ZefyrTheme(
       data: _themeData,
       child: ZefyrToolbar(

packages/zefyr/lib/src/widgets/image.dart

@@ -54,7 +54,7 @@ class ZefyrImage extends StatefulWidget {
 class _ZefyrImageState extends State<ZefyrImage> {
   String get imageSource {
     EmbedAttribute attribute = widget.node.style.get(NotusAttribute.embed);
-    return attribute.value['source'];
+    return attribute.value['source'] as String;
   }
 
   @override

packages/zefyr/lib/src/widgets/quote.dart

@@ -36,9 +36,9 @@ class ZefyrQuote extends StatelessWidget {
 
     Widget content;
     if (line.style.contains(NotusAttribute.heading)) {
-      content = new ZefyrHeading(node: node, blockStyle: blockStyle);
+      content = new ZefyrHeading(node: line, blockStyle: blockStyle);
     } else {
-      content = new ZefyrParagraph(node: node, blockStyle: blockStyle);
+      content = new ZefyrParagraph(node: line, blockStyle: blockStyle);
     }
 
     final row = Row(children: <Widget>[Expanded(child: content)]);

packages/zefyr/lib/src/widgets/rich_text.dart

@@ -43,7 +43,7 @@ class RenderZefyrParagraph extends RenderParagraph
     implements RenderEditableBox {
   RenderZefyrParagraph(
     TextSpan text, {
-    @required ContainerNode node,
+    @required LineNode node,
     TextAlign textAlign: TextAlign.start,
     @required TextDirection textDirection,
     bool softWrap: true,

packages/zefyr/lib/src/widgets/selection.dart

@@ -10,13 +10,12 @@ import 'package:zefyr/util.dart';
 
 import 'controller.dart';
 import 'editable_box.dart';
-import 'render_context.dart';
 import 'scope.dart';
 
 RenderEditableBox _getEditableBox(HitTestResult result) {
   for (var entry in result.path) {
     if (entry.target is RenderEditableBox) {
-      return entry.target;
+      return entry.target as RenderEditableBox;
     }
   }
   return null;

packages/zefyr/lib/src/widgets/view.dart

@@ -91,13 +91,13 @@ class ZefyrViewState extends State<ZefyrView> {
     final BlockNode block = node;
     final blockStyle = block.style.get(NotusAttribute.block);
     if (blockStyle == NotusAttribute.block.code) {
-      return new ZefyrCode(node: node);
+      return new ZefyrCode(node: block);
     } else if (blockStyle == NotusAttribute.block.bulletList) {
-      return new ZefyrList(node: node);
+      return new ZefyrList(node: block);
     } else if (blockStyle == NotusAttribute.block.numberList) {
-      return new ZefyrList(node: node);
+      return new ZefyrList(node: block);
     } else if (blockStyle == NotusAttribute.block.quote) {
-      return new ZefyrQuote(node: node);
+      return new ZefyrQuote(node: block);
     }
 
     throw new UnimplementedError('Block format $blockStyle.');

packages/zefyr/test/rendering/render_editable_paragraph_test.dart

@@ -24,7 +24,7 @@ void main() {
       renderContext = new ZefyrRenderContext();
       p = new RenderZefyrParagraph(
         text,
-        node: doc.root.children.first,
+        node: doc.root.children.first as LineNode,
         textDirection: TextDirection.ltr,
       );
     });

packages/zefyr/test/widgets/buttons_test.dart

@@ -24,7 +24,7 @@ void main() {
       expect(bold.value, 'House');
 
       await editor.tapButtonWithIcon(Icons.format_bold);
-      line = editor.document.root.children.first;
+      line = editor.document.root.children.first as LineNode;
       expect(line.childCount, 1);
     });
 
@@ -139,7 +139,7 @@ void main() {
       await editor.updateSelection(base: 7, extent: 7);
       await editor.tapButtonWithIcon(Icons.link);
       await editor.tapButtonWithIcon(Icons.link_off);
-      line = editor.document.root.children.first;
+      line = editor.document.root.children.first as LineNode;
       expect(line.childCount, 1);
     });
   });

packages/zefyr/test/widgets/editable_text_scope_test.dart

@@ -97,7 +97,7 @@ RenderEditableProxyBox createParagraph(ZefyrRenderContext context) {
   final selection = new TextSelection.collapsed(offset: 0);
   final selectionColor = Colors.blue;
   return new RenderEditableProxyBox(
-    node: doc.root.children.first,
+    node: doc.root.children.first as LineNode,
     layerLink: link,
     renderContext: context,
     showCursor: showCursor,

packages/zefyr/test/widgets/rich_text_test.dart

@@ -19,7 +19,7 @@ void main() {
       widget = new Directionality(
         textDirection: TextDirection.ltr,
         child: new ZefyrRichText(
-          node: doc.root.children.first,
+          node: doc.root.children.first as LineNode,
           text: text,
         ),
       );