Handle user taps on empty area inside editor; toggle selection toolbar on double tap

packages/zefyr/CHANGELOG.md

@@ -1,7 +1,9 @@
 ## 0.1.2
 
-* Fixed analysis warnings
-* Handle user taps on padding area around the editor.
+* Fixed analysis warnings.
+* UX: User taps on padding area around the editor and in empty space inside it now look for the nearest
+  paragraph to move caret to.
+* UX: Toggle selection toolbar on double tap instead of refreshing it.
 
 ## 0.1.1
 

packages/zefyr/lib/src/widgets/render_context.dart

@@ -109,6 +109,15 @@ class ZefyrRenderContext extends ChangeNotifier {
       final localPoint = p.globalToLocal(point);
       return (localPoint.dy >= 0 && localPoint.dy < p.size.height);
     }, orElse: _null);
+    if (box != null) return box;
+
+    box = _activeBoxes.map((p) {
+      final localPoint = p.globalToLocal(point);
+      final distance = localPoint.dy - p.size.height;
+      return new MapEntry(distance.abs(), p);
+    }).reduce((a, b) {
+      return (a.key <= b.key) ? a : b;
+    }).value;
 
     return box;
   }

packages/zefyr/lib/src/widgets/selection.dart

@@ -231,8 +231,11 @@ class _ZefyrSelectionOverlayState extends State<ZefyrSelectionOverlay>
     );
     if (_didCaretTap && _selection == selection) {
       _didCaretTap = false;
-      hideToolbar();
-      showToolbar();
+      if (isToolbarVisible) {
+        hideToolbar();
+      } else {
+        showToolbar();
+      }
     } else {
       _didCaretTap = true;
     }

packages/zefyr/test/widgets/selection_test.dart

@@ -34,8 +34,7 @@ void main() {
       expect(editor.findSelectionHandle(), findsNothing);
     });
 
-    testWidgets('tap outside of text area finds closest paragraph',
-        (tester) async {
+    testWidgets('tap on padding area finds closest paragraph', (tester) async {
       final editor = new EditorSandBox(tester: tester);
       await editor.tapEditor();
       editor.controller
@@ -52,5 +51,33 @@ void main() {
       expect(editor.controller.selection.isCollapsed, isTrue);
       expect(editor.controller.selection.extentOffset, 0);
     });
+
+    testWidgets('tap on empty space finds closest paragraph', (tester) async {
+      final editor = new EditorSandBox(tester: tester);
+      await editor.tapEditor();
+      editor.controller.replaceText(10, 1, '\n',
+          selection: new TextSelection.collapsed(offset: 0));
+      await tester.pumpAndSettle();
+      expect(editor.controller.document.toPlainText(),
+          'This House\nIs A Circus\n');
+      expect(editor.controller.selection.extentOffset, 0);
+
+      RenderBox renderObject =
+          tester.firstRenderObject(find.byType(ZefyrEditableText));
+      var offset = renderObject.localToGlobal(Offset.zero);
+      offset += Offset(50.0, renderObject.size.height - 5.0);
+      await tester.tapAt(offset);
+      await tester.pumpAndSettle();
+      expect(editor.controller.selection.isCollapsed, isTrue);
+      expect(editor.controller.selection.extentOffset,
+          13); // Note that this is probably too fragile.
+
+      offset = renderObject.localToGlobal(Offset.zero) + Offset(50.0, 1.0);
+      await tester.tapAt(offset);
+      await tester.pumpAndSettle();
+      expect(editor.controller.selection.isCollapsed, isTrue);
+      expect(editor.controller.selection.extentOffset,
+          2); // Note that this is probably too fragile.
+    });
   });
 }