Browse Source

Merge pull request #99 from syanbo/hotfix/ios-type-cast

hotfix/ios type cast crash
matrixbirds 5 years ago
parent
commit
33011f8cbc
No account linked to committer's email address
2 changed files with 10 additions and 7 deletions
  1. 3
    0
      CHANGELOG
  2. 7
    7
      ios/RCTAgora/RCTAgora.m

+ 3
- 0
CHANGELOG View File

@@ -1,5 +1,8 @@
1 1
 ## THE CHANGELOG
2 2
 
3
+#### 2.9.0-alpha.2
4
+  - fix ios dictionary stringValue type cast
5
+
3 6
 #### 2.9.0-alpha.1
4 7
   - fix typo: rename `methodisSpeakerphoneEnabled` to `isSpeakerphoneEnabled`
5 8
   - events deprecated & instead:

+ 7
- 7
ios/RCTAgora/RCTAgora.m View File

@@ -228,9 +228,9 @@ RCT_EXPORT_METHOD(init:(NSDictionary *)options) {
228 228
     }
229 229
   }
230 230
   if (options[@"secret"] != nil) {
231
-    [self.rtcEngine setEncryptionSecret:[options[@"secret"] stringValue]];
231
+    [self.rtcEngine setEncryptionSecret:[options[@"secret"]]];
232 232
     if (options[@"secretMode"] != nil) {
233
-      [self.rtcEngine setEncryptionMode:[options[@"secretMode"] stringValue]];
233
+      [self.rtcEngine setEncryptionMode:[options[@"secretMode"]]];
234 234
     }
235 235
   }
236 236
   
@@ -851,7 +851,7 @@ RCT_EXPORT_METHOD(setLocalVoiceReverb:(NSInteger)reverb value:(NSInteger)value
851 851
 RCT_EXPORT_METHOD(startAudioMixing:(NSDictionary *) options
852 852
                   resolve:(RCTPromiseResolveBlock)resolve
853 853
                   reject:(RCTPromiseRejectBlock)reject) {
854
-  NSInteger res = [self.rtcEngine startAudioMixing:[options[@"filepath"] stringValue]
854
+  NSInteger res = [self.rtcEngine startAudioMixing:[options[@"filepath"]]
855 855
                                           loopback:[options[@"loopback"] boolValue]
856 856
                                            replace:[options[@"replace"] boolValue]
857 857
                                              cycle:[options[@"cycle"] integerValue]];
@@ -1038,7 +1038,7 @@ RCT_EXPORT_METHOD(playEffect
1038 1038
                   resolve:(RCTPromiseResolveBlock)resolve
1039 1039
                   reject:(RCTPromiseRejectBlock)reject) {
1040 1040
   NSInteger res = [self.rtcEngine playEffect:(int)[options[@"soundid"] integerValue]
1041
-                                    filePath:[options[@"filepath"] stringValue]
1041
+                                    filePath:[options[@"filepath"]]
1042 1042
                                    loopCount:(int)[options[@"loopcount"] integerValue]
1043 1043
                                        pitch:[options[@"pitch"] doubleValue]
1044 1044
                                          pan:[options[@"pan"] doubleValue]
@@ -1157,7 +1157,7 @@ RCT_EXPORT_METHOD(startAudioRecording:(NSDictionary *)options
1157 1157
                   resolve:(RCTPromiseResolveBlock)resolve
1158 1158
                   reject:(RCTPromiseRejectBlock)reject) {
1159 1159
   AgoraAudioRecordingQuality qualityType = (AgoraAudioRecordingQuality)[options[@"quality"] integerValue];
1160
-  NSInteger res = [self.rtcEngine startAudioRecording:[options[@"filepath"] stringValue] quality:qualityType];
1160
+  NSInteger res = [self.rtcEngine startAudioRecording:[options[@"filepath"]] quality:qualityType];
1161 1161
   if (res == 0) {
1162 1162
     resolve(nil);
1163 1163
   } else {
@@ -1374,7 +1374,7 @@ RCT_EXPORT_METHOD(addInjectStreamUrl
1374 1374
   config.audioBitrate = [options[@"config"][@"audioBitrate"] integerValue];
1375 1375
   config.audioChannels = [options[@"config"][@"audioChannels"] integerValue];
1376 1376
   
1377
-  NSInteger res = [self.rtcEngine addInjectStreamUrl:[options[@"url"] stringValue]
1377
+  NSInteger res = [self.rtcEngine addInjectStreamUrl:[options[@"url"]]
1378 1378
                                               config:config];
1379 1379
   if (res == 0) {
1380 1380
     resolve(nil);
@@ -1630,7 +1630,7 @@ RCT_EXPORT_METHOD(setLiveTranscoding:(NSDictionary *)options
1630 1630
     transcoding.transcodingUsers = transcodingUsers;
1631 1631
   }
1632 1632
   if ([options objectForKey:@"transcodingExtraInfo"]) {
1633
-    transcoding.transcodingExtraInfo = [options[@"transcodingExtraInfo"] stringValue];
1633
+    transcoding.transcodingExtraInfo = [options[@"transcodingExtraInfo"]];
1634 1634
   }
1635 1635
   
1636 1636
   NSInteger res = [self.rtcEngine setLiveTranscoding:transcoding];