Browse Source

Fix naming and variable types

Guy Carmeli 8 years ago
parent
commit
00012ad9c0

+ 6
- 6
android/app/src/main/java/com/reactnativenavigation/layouts/ScreenLayout.java View File

@@ -11,12 +11,12 @@ import android.view.Window;
11 11
 import android.widget.LinearLayout;
12 12
 
13 13
 import com.facebook.react.ReactInstanceManager;
14
-import com.reactnativenavigation.controllers.ScreenParams;
14
+import com.reactnativenavigation.params.ScreenParams;
15 15
 import com.reactnativenavigation.params.ScreenStyleParams;
16
+import com.reactnativenavigation.params.TitleBarButtonParams;
16 17
 import com.reactnativenavigation.utils.SdkSupports;
17 18
 import com.reactnativenavigation.views.ContentView;
18 19
 import com.reactnativenavigation.views.ScrollDirectionListener;
19
-import com.reactnativenavigation.views.TitleBarButton;
20 20
 
21 21
 import java.util.List;
22 22
 
@@ -26,16 +26,16 @@ import static android.view.ViewGroup.LayoutParams.WRAP_CONTENT;
26 26
 public class ScreenLayout extends LinearLayout implements ScrollDirectionListener.OnScrollChanged {
27 27
 
28 28
     private final ReactInstanceManager reactInstanceManager;
29
-    private final String moduleName;
29
+    private final String screenId;
30 30
     private final Bundle passProps;
31
-    private final List<TitleBarButton.Params> buttons;
31
+    private final List<TitleBarButtonParams> buttons;
32 32
     private ContentView contentView;
33 33
     private TopBar topBar;
34 34
 
35 35
     public ScreenLayout(Context context, ReactInstanceManager reactInstanceManager, ScreenParams screenParams) {
36 36
         super(context);
37 37
         this.reactInstanceManager = reactInstanceManager;
38
-        moduleName = screenParams.moduleName;
38
+        screenId = screenParams.screenId;
39 39
         passProps = screenParams.passProps;
40 40
         buttons = screenParams.buttons;
41 41
         setOrientation(VERTICAL);
@@ -56,7 +56,7 @@ public class ScreenLayout extends LinearLayout implements ScrollDirectionListene
56 56
     }
57 57
 
58 58
     private void addContentView() {
59
-        contentView = new ContentView(getContext(), reactInstanceManager, moduleName, passProps, this);
59
+        contentView = new ContentView(getContext(), reactInstanceManager, screenId, passProps, this);
60 60
         addView(contentView, new LayoutParams(MATCH_PARENT, MATCH_PARENT));
61 61
     }
62 62
 

+ 2
- 2
android/app/src/main/java/com/reactnativenavigation/layouts/TopBar.java View File

@@ -3,8 +3,8 @@ package com.reactnativenavigation.layouts;
3 3
 import android.content.Context;
4 4
 import android.support.design.widget.AppBarLayout;
5 5
 
6
+import com.reactnativenavigation.params.TitleBarButtonParams;
6 7
 import com.reactnativenavigation.views.TitleBar;
7
-import com.reactnativenavigation.views.TitleBarButton;
8 8
 
9 9
 import java.util.List;
10 10
 
@@ -17,7 +17,7 @@ public class TopBar extends AppBarLayout {
17 17
         setFitsSystemWindows(true);
18 18
     }
19 19
 
20
-    public void addTitleBarAndSetButtons(List<TitleBarButton.Params> buttons) {
20
+    public void addTitleBarAndSetButtons(List<TitleBarButtonParams> buttons) {
21 21
         titleBar = new TitleBar(getContext());
22 22
         titleBar.setButtons(buttons);
23 23
     }

+ 4
- 4
android/app/src/main/java/com/reactnativenavigation/views/ContentView.java View File

@@ -11,20 +11,20 @@ import com.reactnativenavigation.react.ReactViewHacks;
11 11
 public class ContentView extends ReactRootView {
12 12
 
13 13
     private final ReactInstanceManager reactInstanceManager;
14
-    private final String moduleName;
14
+    private final String screenId;
15 15
     private final Bundle passProps;
16 16
     private final ScrollDirectionListener.OnScrollChanged scrollListener;
17 17
 
18
-    public ContentView(Context context, ReactInstanceManager reactInstanceManager, String moduleName, Bundle passProps, ScrollDirectionListener.OnScrollChanged scrollListener) {
18
+    public ContentView(Context context, ReactInstanceManager reactInstanceManager, String screenId, Bundle passProps, ScrollDirectionListener.OnScrollChanged scrollListener) {
19 19
         super(context);
20 20
         this.reactInstanceManager = reactInstanceManager;
21
-        this.moduleName = moduleName;
21
+        this.screenId = screenId;
22 22
         this.passProps = passProps;
23 23
         this.scrollListener = scrollListener;
24 24
     }
25 25
 
26 26
     public void init() {
27
-        startReactApplication(reactInstanceManager, moduleName, passProps);
27
+        startReactApplication(reactInstanceManager, screenId, passProps);
28 28
         new ScrollViewAttacher(this, scrollListener).attach();
29 29
     }
30 30
 

+ 2
- 1
android/app/src/main/java/com/reactnativenavigation/views/TitleBar.java View File

@@ -9,6 +9,7 @@ import android.view.MenuInflater;
9 9
 
10 10
 import com.reactnativenavigation.R;
11 11
 import com.reactnativenavigation.animation.HideOnScrollAnimator;
12
+import com.reactnativenavigation.params.TitleBarButtonParams;
12 13
 
13 14
 import java.util.List;
14 15
 
@@ -24,7 +25,7 @@ public class TitleBar extends Toolbar {
24 25
         createMenu();
25 26
     }
26 27
 
27
-    public void setButtons(List<TitleBarButton.Params> buttons) {
28
+    public void setButtons(List<TitleBarButtonParams> buttons) {
28 29
         menu.clear();
29 30
 
30 31
         for (int i = 0; i < buttons.size(); i++) {