NoColor returns nil (#5600)

For some reason it returned cyan... probably leftover from a debug session

lib/ios/NoColor.m

@@ -1,6 +1,4 @@
 #import "NoColor.h"
-#import "Color.h"
-
 
 @implementation NoColor
 
@@ -9,14 +7,11 @@
 }
 
 - (UIColor *)get {
-//    return nil;
-    return UIColor.cyanColor;
+    return nil;
 }
 
 - (UIColor *)getWithDefaultValue:(id)defaultValue {
-    return UIColor.cyanColor;
-//    return nil;
+    return nil;
 }
 
-
 @end

lib/ios/Param.m

@@ -11,9 +11,7 @@
 
 - (instancetype)initWithValue:(id)value {
 	self = [super init];
-	
 	self.value = value;
-	
 	return self;
 }
 
@@ -21,7 +19,6 @@
 	if (!self.value) {
 		@throw [NSException exceptionWithName:@"Param get" reason:@"value does not exists" userInfo:nil];
 	}
-	
 	return self.value;
 }
 

lib/ios/ReactNativeNavigation.xcodeproj/project.pbxproj

@@ -41,6 +41,7 @@
 		309877B0B5AAA7788F56F3D9 /* UIViewController+Utils.h in Headers */ = {isa = PBXBuildFile; fileRef = 30987CF6993B89E85C0BCEE4 /* UIViewController+Utils.h */; };
 		309877F473AECC05FB3B9362 /* UITabBarController+RNNUtils.h in Headers */ = {isa = PBXBuildFile; fileRef = 30987FED6F982D322416CAF2 /* UITabBarController+RNNUtils.h */; };
 		309878CC9D33CE1CF991EBD1 /* NoColor.m in Sources */ = {isa = PBXBuildFile; fileRef = 309877ADF638DF25FF0DA8A1 /* NoColor.m */; };
+		309879812219F6EDD2AECAC6 /* RNNTestNoColor.m in Sources */ = {isa = PBXBuildFile; fileRef = 309871A6C468B5DC1D0CA495 /* RNNTestNoColor.m */; };
 		30987AB5137F264FA06DA289 /* DotIndicatorOptions.m in Sources */ = {isa = PBXBuildFile; fileRef = 309876223177761614786DCC /* DotIndicatorOptions.m */; };
 		30987B23F288EB3A78B7F27C /* RNNDotIndicatorPresenter.m in Sources */ = {isa = PBXBuildFile; fileRef = 30987E66AA7AB38E7370F8C8 /* RNNDotIndicatorPresenter.m */; };
 		30987CA5048A48D6CE76B06C /* DotIndicatorParser.h in Headers */ = {isa = PBXBuildFile; fileRef = 309871FBA64AD937CEF3E191 /* DotIndicatorParser.h */; };
@@ -87,7 +88,6 @@
 		5038A374216CDDB6009280BC /* UIViewController+SideMenuController.h in Headers */ = {isa = PBXBuildFile; fileRef = 5038A372216CDDB6009280BC /* UIViewController+SideMenuController.h */; };
 		5038A375216CDDB6009280BC /* UIViewController+SideMenuController.m in Sources */ = {isa = PBXBuildFile; fileRef = 5038A373216CDDB6009280BC /* UIViewController+SideMenuController.m */; };
 		5038A377216CF252009280BC /* UITabBarController+RNNOptionsTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 5038A376216CF252009280BC /* UITabBarController+RNNOptionsTest.m */; };
-		5038A379216D01F6009280BC /* RNNBottomTabOptionsTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 5038A378216D01F6009280BC /* RNNBottomTabOptionsTest.m */; };
 		5038A3B1216DF41B009280BC /* UIViewController+RNNOptions.h in Headers */ = {isa = PBXBuildFile; fileRef = 5038A3AF216DF41B009280BC /* UIViewController+RNNOptions.h */; };
 		5038A3B2216DF41B009280BC /* UIViewController+RNNOptions.m in Sources */ = {isa = PBXBuildFile; fileRef = 5038A3B0216DF41B009280BC /* UIViewController+RNNOptions.m */; };
 		5038A3B5216DF602009280BC /* UINavigationController+RNNOptions.h in Headers */ = {isa = PBXBuildFile; fileRef = 5038A3B3216DF602009280BC /* UINavigationController+RNNOptions.h */; };
@@ -379,6 +379,7 @@
 		2DCD9193200014A900EDC75D /* RNNBridgeManager.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = RNNBridgeManager.h; sourceTree = "<group>"; };
 		2DCD9194200014A900EDC75D /* RNNBridgeManager.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = RNNBridgeManager.m; sourceTree = "<group>"; };
 		30987122507D8CBF16624F93 /* DotIndicatorOptions.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DotIndicatorOptions.h; sourceTree = "<group>"; };
+		309871A6C468B5DC1D0CA495 /* RNNTestNoColor.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = RNNTestNoColor.m; sourceTree = "<group>"; };
 		309871FBA64AD937CEF3E191 /* DotIndicatorParser.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DotIndicatorParser.h; sourceTree = "<group>"; };
 		3098727A36771B4902A14FEA /* RNNTestBase.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = RNNTestBase.m; sourceTree = "<group>"; };
 		309874C5B132A51A03DAA3BF /* NoColor.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NoColor.h; sourceTree = "<group>"; };
@@ -437,7 +438,6 @@
 		5038A372216CDDB6009280BC /* UIViewController+SideMenuController.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "UIViewController+SideMenuController.h"; sourceTree = "<group>"; };
 		5038A373216CDDB6009280BC /* UIViewController+SideMenuController.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = "UIViewController+SideMenuController.m"; sourceTree = "<group>"; };
 		5038A376216CF252009280BC /* UITabBarController+RNNOptionsTest.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = "UITabBarController+RNNOptionsTest.m"; sourceTree = "<group>"; };
-		5038A378216D01F6009280BC /* RNNBottomTabOptionsTest.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = RNNBottomTabOptionsTest.m; sourceTree = "<group>"; };
 		5038A3AF216DF41B009280BC /* UIViewController+RNNOptions.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "UIViewController+RNNOptions.h"; sourceTree = "<group>"; };
 		5038A3B0216DF41B009280BC /* UIViewController+RNNOptions.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = "UIViewController+RNNOptions.m"; sourceTree = "<group>"; };
 		5038A3B3216DF602009280BC /* UINavigationController+RNNOptions.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "UINavigationController+RNNOptions.h"; sourceTree = "<group>"; };
@@ -778,6 +778,14 @@
 			path = MMDrawerController;
 			sourceTree = "<group>";
 		};
+		30987D8ED611122B1A9E1154 /* Options */ = {
+			isa = PBXGroup;
+			children = (
+				309871A6C468B5DC1D0CA495 /* RNNTestNoColor.m */,
+			);
+			path = Options;
+			sourceTree = "<group>";
+		};
 		5012242C2173E0A4000F5F98 /* Parent ViewControllers */ = {
 			isa = PBXGroup;
 			children = (
@@ -1053,7 +1061,6 @@
 				5085DD2C21DCF75A0032E64B /* RNNSideMenuControllerTest.m */,
 				50206A6C21AFE75400B7BB1A /* RNNSideMenuParserTest.m */,
 				502F0E152178D09600367CC3 /* RNNBasePresenterTest.m */,
-				5038A378216D01F6009280BC /* RNNBottomTabOptionsTest.m */,
 				7B49FEBF1E95090800DEB3EA /* Info.plist */,
 				E83BAD671F2734B500A9F3DD /* RNNNavigationOptionsTest.m */,
 				E83BAD781F27416B00A9F3DD /* RNNRootViewControllerTest.m */,
@@ -1066,6 +1073,7 @@
 				50AB0B1E22562FA10039DAED /* UIViewController+LayoutProtocolTest.m */,
 				505963F622676A0000EBB63C /* RNNLayoutManagerTest.m */,
 				30987758777622B7D6CCD695 /* RNNDotIndicatorPresenterTest.m */,
+				30987D8ED611122B1A9E1154 /* Options */,
 			);
 			path = ReactNativeNavigationTests;
 			sourceTree = "<group>";
@@ -1470,7 +1478,6 @@
 				505963F722676A0000EBB63C /* RNNLayoutManagerTest.m in Sources */,
 				7B49FECE1E95098500DEB3EA /* RNNCommandsHandlerTest.m in Sources */,
 				E5F6C3AB22DB4D0F0093C2CE /* UIColor+RNNUtils.m in Sources */,
-				5038A379216D01F6009280BC /* RNNBottomTabOptionsTest.m in Sources */,
 				E83BAD681F2734B500A9F3DD /* RNNNavigationOptionsTest.m in Sources */,
 				505EDD32214E4BE80071C7DE /* RNNNavigationControllerTest.m in Sources */,
 				50AB0B1F22562FA10039DAED /* UIViewController+LayoutProtocolTest.m in Sources */,
@@ -1491,6 +1498,7 @@
 				E5F6C3A722DB4D0F0093C2CE /* UIViewController+Utils.m in Sources */,
 				E8DA243D1F973C1900CD552B /* RNNTransitionStateHolderTest.m in Sources */,
 				7B49FECC1E95098500DEB3EA /* RNNExternalComponentStoreTest.m in Sources */,
+				309879812219F6EDD2AECAC6 /* RNNTestNoColor.m in Sources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};

lib/ios/ReactNativeNavigationTests/Options/RNNTestNoColor.m

@@ -0,0 +1,25 @@
+#import <XCTest/XCTest.h>
+#import "NoColor.h"
+
+@interface RNNTestNoColor : XCTestCase
+
+@property (nonatomic, retain) NoColor* uut;
+
+@end
+
+
+@implementation RNNTestNoColor
+- (void)setUp {
+    [super setUp];
+    self.uut = [[NoColor alloc] init];
+}
+
+- (void)testHasValue_alwaysReturnsYES {
+    XCTAssertEqual([_uut hasValue], YES);
+}
+
+- (void)testGet_returnsNil {
+    XCTAssertEqual(_uut.get, (UIColor *) nil);
+}
+
+@end

lib/ios/ReactNativeNavigationTests/RNNBottomTabOptionsTest.m

@@ -1,19 +0,0 @@
-#import <XCTest/XCTest.h>
-#import "RNNBottomTabOptions.h"
-
-@interface RNNBottomTabOptionsTest : XCTestCase
-
-@property (nonatomic, retain) RNNBottomTabOptions* uut;
-
-@end
-
-@implementation RNNBottomTabOptionsTest
-
-- (void)setUp {
-    [super setUp];
-//	self.uut = [[RNNBottomTabOptions alloc] initEmptyOptions];
-}
-
-
-
-@end

package.json

@@ -166,4 +166,4 @@
       }
     }
   }
-}
+}