update splash flow

android/app/src/main/AndroidManifest.xml

@@ -1,8 +1,13 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     package="com.reactnativenavigation">
 
-    <application>
+    <application
+        android:allowBackup="false"
+        android:theme="@style/Theme.AppCompat.Light.NoActionBar">
         <activity android:name=".controllers.NavigationActivity" />
+        <activity
+            android:name="com.facebook.react.devsupport.DevSettingsActivity"
+            android:exported="false" />
     </application>
 
 </manifest>

android/app/src/main/java/com/reactnativenavigation/controllers/SplashActivity.java

@@ -16,27 +16,30 @@ public abstract class SplashActivity extends AppCompatActivity {
     protected void onCreate(@Nullable Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
         setSplashLayout();
+    }
 
-        if (NavigationApplication.instance.isReactContextInitialized()) {
-            finish();
+    @Override
+    protected void onResume() {
+        super.onResume();
+
+        if (NavigationApplication.instance.getReactGateway().hasStartedCreatingContext()) {
             return;
         }
 
         if (ReactDevPermission.shouldAskPermission()) {
             ReactDevPermission.askPermission(this);
+            return;
+        }
+
+        if (NavigationApplication.instance.isReactContextInitialized()) {
             finish();
             return;
         }
 
+        // TODO I'm starting to think this entire flow is incorrect and should be done in Application
         NavigationApplication.instance.startReactContextOnceInBackgroundAndExecuteJS();
     }
 
-    @Override
-    protected void onPause() {
-        super.onPause();
-        finish();
-    }
-
     private void setSplashLayout() {
         final int splashLayout = getSplashLayout();
         if (splashLayout > 0) {

android/app/src/main/java/com/reactnativenavigation/react/NavigationReactGateway.java

@@ -38,6 +38,11 @@ public class NavigationReactGateway implements ReactGateway {
         return host.hasInstance() && getReactInstanceManager().getCurrentReactContext() != null;
     }
 
+    @Override
+    public boolean hasStartedCreatingContext() {
+        return getReactInstanceManager().hasStartedCreatingInitialContext();
+    }
+
     public ReactContext getReactContext() {
         return getReactInstanceManager().getCurrentReactContext();
     }

android/app/src/main/java/com/reactnativenavigation/react/ReactGateway.java

@@ -29,4 +29,6 @@ public interface ReactGateway {
     void onBackPressed();
 
     void onActivityResult(int requestCode, int resultCode, Intent data);
+
+    boolean hasStartedCreatingContext();
 }

example/android/app/src/main/AndroidManifest.xml

@@ -7,18 +7,15 @@
         android:name=".MyApplication"
         android:allowBackup="false"
         android:icon="@mipmap/ic_launcher"
-        android:label="@string/app_name"
-        android:theme="@style/AppTheme">
+        android:label="@string/app_name">
         <activity
             android:name=".MainActivity"
-            android:configChanges="keyboard|keyboardHidden|orientation|screenSize"
             android:label="@string/app_name">
             <intent-filter>
                 <action android:name="android.intent.action.MAIN" />
                 <category android:name="android.intent.category.LAUNCHER" />
             </intent-filter>
         </activity>
-        <activity android:name="com.facebook.react.devsupport.DevSettingsActivity" />
     </application>
 
 </manifest>

example/android/app/src/main/res/values/styles.xml

@@ -1,8 +0,0 @@
-<resources>
-
-    <!-- Base application theme. -->
-    <style name="AppTheme" parent="Theme.AppCompat.Light.NoActionBar">
-        <!-- Customize your theme here. -->
-    </style>
-
-</resources>

example/package.json

@@ -3,7 +3,7 @@
   "version": "0.0.1",
   "private": true,
   "scripts": {
-    "start": "watchman watch-del-all && (adb reverse tcp:8081 tcp:8081 || true) && node node_modules/react-native/local-cli/cli.js start",
+    "start": "watchman watch-del-all && (adb reverse tcp:8081 tcp:8081 || true) && node node_modules/react-native/local-cli/cli.js start --reset-cache",
     "xcode": "open ios/example.xcodeproj",
     "android": "cd android && ./gradlew installDebug"
   },