Browse Source

xcpretty was swallowing test errors

Daniel Zlotin 7 years ago
parent
commit
16d834cb84
2 changed files with 3 additions and 12 deletions
  1. 0
    2
      scripts/env/env.ios.sh
  2. 3
    10
      scripts/test.unit.ios.js

+ 0
- 2
scripts/env/env.ios.sh View File

2
 
2
 
3
 brew tap wix/brew
3
 brew tap wix/brew
4
 brew install wix/brew/applesimutils
4
 brew install wix/brew/applesimutils
5
-
6
-gem install xcpretty

+ 3
- 10
scripts/test.unit.ios.js View File

6
 function run() {
6
 function run() {
7
   const conf = release ? `Release` : `Debug`;
7
   const conf = release ? `Release` : `Debug`;
8
 
8
 
9
-  execWithXcprettyIfPossible(`cd ./playground/ios &&
9
+  exec.execSync(`cd ./playground/ios &&
10
             RCT_NO_LAUNCH_PACKAGER=true
10
             RCT_NO_LAUNCH_PACKAGER=true
11
             xcodebuild build build-for-testing
11
             xcodebuild build build-for-testing
12
             -scheme "ReactNativeNavigation"
12
             -scheme "ReactNativeNavigation"
14
             -sdk iphonesimulator
14
             -sdk iphonesimulator
15
             -configuration ${conf}
15
             -configuration ${conf}
16
             -derivedDataPath ./DerivedData/playground
16
             -derivedDataPath ./DerivedData/playground
17
+            -quiet
17
             ONLY_ACTIVE_ARCH=YES`);
18
             ONLY_ACTIVE_ARCH=YES`);
18
 
19
 
19
-  execWithXcprettyIfPossible(`cd ./playground/ios &&
20
+  exec.execSync(`cd ./playground/ios &&
20
             RCT_NO_LAUNCH_PACKAGER=true
21
             RCT_NO_LAUNCH_PACKAGER=true
21
             xcodebuild test-without-building
22
             xcodebuild test-without-building
22
             -scheme "ReactNativeNavigation"
23
             -scheme "ReactNativeNavigation"
28
             ONLY_ACTIVE_ARCH=YES`);
29
             ONLY_ACTIVE_ARCH=YES`);
29
 }
30
 }
30
 
31
 
31
-function execWithXcprettyIfPossible(cmd) {
32
-  if (exec.which('xcpretty')) {
33
-    exec.execSync(`${cmd} | xcpretty`);
34
-  } else {
35
-    exec.execSync(cmd);
36
-  }
37
-}
38
-
39
 run();
32
 run();