tslint instead of xo and eslint

lib/src/Navigation.ts

@@ -47,7 +47,7 @@ class Navigation {
    * @param {string} componentName Unique component name
    * @param {function} getComponentClassFunc generator function, typically `() => require('./myComponent')`
    */
-  registerComponent(componentName: string, getComponentClassFunc: ComponentProvider) {
+  public registerComponent(componentName: string, getComponentClassFunc: ComponentProvider) {
     this.componentRegistry.registerComponent(componentName, getComponentClassFunc);
   }
 
@@ -55,7 +55,7 @@ class Navigation {
    * Reset the navigation stack to a new component (the stack root is changed).
    * @param {Root} root
    */
-  setRoot(params) {
+  public setRoot(params) {
     return this.commands.setRoot(params);
   }
 
@@ -63,7 +63,7 @@ class Navigation {
    * Set default options to all screens. Useful for declaring a consistent style across the app.
    * @param {options:Options} options
    */
-  setDefaultOptions(options) {
+  public setDefaultOptions(options) {
     this.commands.setDefaultOptions(options);
   }
 
@@ -72,7 +72,7 @@ class Navigation {
    * @param {string} componentId The component's id.
    * @param {options:Options} options
    */
-  setOptions(componentId, options) {
+  public setOptions(componentId, options) {
     this.commands.setOptions(componentId, options);
   }
 
@@ -80,7 +80,7 @@ class Navigation {
    * Show a screen as a modal.
    * @param {object} params
    */
-  showModal(params) {
+  public showModal(params) {
     return this.commands.showModal(params);
   }
 
@@ -88,14 +88,14 @@ class Navigation {
    * Dismiss a modal by componentId. The dismissed modal can be anywhere in the stack.
    * @param {string} componentId The component's id.
    */
-  dismissModal(componentId) {
+  public dismissModal(componentId) {
     return this.commands.dismissModal(componentId);
   }
 
   /**
    * Dismiss all Modals
    */
-  dismissAllModals() {
+  public dismissAllModals() {
     return this.commands.dismissAllModals();
   }
 
@@ -104,7 +104,7 @@ class Navigation {
    * @param {string} componentId The component's id.
    * @param {Component} component
    */
-  push(componentId, component) {
+  public push(componentId, component) {
     return this.commands.push(componentId, component);
   }
 
@@ -113,7 +113,7 @@ class Navigation {
    * @param {string} componentId The component's id.
    * @param {*} params
    */
-  pop(componentId, params) {
+  public pop(componentId, params) {
     return this.commands.pop(componentId, params);
   }
 
@@ -121,7 +121,7 @@ class Navigation {
    * Pop the stack to a given component
    * @param {string} componentId The component's id.
    */
-  popTo(componentId: string) {
+  public popTo(componentId: string) {
     return this.commands.popTo(componentId);
   }
 
@@ -129,7 +129,7 @@ class Navigation {
    * Pop the component's stack to root.
    * @param {*} componentId
    */
-  popToRoot(componentId: string) {
+  public popToRoot(componentId: string) {
     return this.commands.popToRoot(componentId);
   }
 
@@ -137,7 +137,7 @@ class Navigation {
    * Show overlay on top of the window
    * @param {*} params
    */
-  showOverlay(params) {
+  public showOverlay(params) {
     return this.commands.showOverlay(params);
   }
 
@@ -145,14 +145,14 @@ class Navigation {
    * dismiss overlay by componentId
    * @param {string} componentId
    */
-  dismissOverlay(componentId: string) {
+  public dismissOverlay(componentId: string) {
     return this.commands.dismissOverlay(componentId);
   }
 
   /**
    * Obtain the events registry instance
    */
-  events() {
+  public events() {
     return this.publicEventsRegistry;
   }
 }

lib/src/adapters/Element.tsx

@@ -13,10 +13,11 @@ export class Element extends React.Component<ElementProps, any> {
   static propTypes = {
     elementId: PropTypes.string.isRequired,
     resizeMode: PropTypes.string
-  }
+  };
+
   static defaultProps = {
     resizeMode: ''
-  }
+  };
 
   render() {
     return (
@@ -26,4 +27,3 @@ export class Element extends React.Component<ElementProps, any> {
 }
 
 RNNElement = requireNativeComponent('RNNElement', Element);
-

lib/src/commands/LayoutTreeCrawler.ts

@@ -6,7 +6,7 @@ export interface LayoutNode {
   id?: string;
   type: LayoutType;
   data: object;
-  children: Array<LayoutNode>;
+  children: LayoutNode[];
 }
 
 interface IdProvider {
@@ -19,8 +19,8 @@ interface Store {
 }
 
 export class LayoutTreeCrawler {
-  private uniqueIdProvider: IdProvider
-  private store: Store
+  private uniqueIdProvider: IdProvider;
+  private store: Store;
 
   constructor(uniqueIdProvider: IdProvider, store: Store) {
     this.uniqueIdProvider = uniqueIdProvider;
@@ -33,7 +33,7 @@ export class LayoutTreeCrawler {
     node.id = this.uniqueIdProvider.generate(node.type);
     node.data = node.data || {};
     node.children = node.children || [];
-    if (node.type == LayoutType.Component) {
+    if (node.type === LayoutType.Component) {
       this._handleComponent(node);
     }
     _.forEach(node.children, this.crawl);

lib/src/commands/LayoutTreeParser.test.ts

@@ -118,7 +118,6 @@ describe('LayoutTreeParser', () => {
   });
 
   it('options for all containing types', () => {
-    const options = {};
     expect(uut.parse({ component: { options } }).data.options).toBe(options);
     expect(uut.parse({ stack: { options } }).data.options).toBe(options);
     expect(uut.parse({ bottomTabs: { options } }).data.options).toBe(options);

lib/src/commands/LayoutTreeParser.ts

@@ -38,11 +38,11 @@ export class LayoutTreeParser {
     };
   }
 
-  _sideMenuChildren(api): Array<LayoutNode> {
+  _sideMenuChildren(api): LayoutNode[] {
     if (!api.center) {
       throw new Error(`sideMenu.center is required`);
     }
-    const children: Array<LayoutNode> = [];
+    const children: LayoutNode[] = [];
     if (api.left) {
       children.push({
         type: LayoutType.SideMenuLeft,

lib/src/commands/LayoutType.test.ts

@@ -7,7 +7,7 @@ describe.only('LayoutType', () => {
 
     const name = 'Stack';
     expect(LayoutType[name]).toEqual(LayoutType.Stack);
-    expect(LayoutType['asdasd']).toEqual(undefined);
+    expect(LayoutType['asdasd']).toEqual(undefined); //tslint:disable-line
   });
 
   it('isLayoutType', () => {

lib/src/commands/LayoutType.ts

@@ -7,7 +7,7 @@ export enum LayoutType {
   SideMenuLeft = 'SideMenuLeft',
   SideMenuRight = 'SideMenuRight',
   TopTabs = 'TopTabs'
-};
+}
 
 export function isLayoutType(name: string): boolean {
   return !!LayoutType[name];

lib/src/commands/OptionsProcessor.ts

@@ -5,7 +5,7 @@ import * as resolveAssetSource from 'react-native/Libraries/Image/resolveAssetSo
 export class OptionsProcessor {
   static processOptions(options) {
     _.forEach(options, (value, key) => {
-      if (!value) return
+      if (!value) { return; }
 
       if (_.isEqual(key, 'color') || _.endsWith(key, 'Color')) {
         options[key] = processColor(value);

lib/src/components/ComponentRegistry.test.tsx

@@ -45,7 +45,7 @@ describe('ComponentRegistry', () => {
   it('resulting in a normal component', () => {
     uut.registerComponent('example.MyComponent.name', () => MyComponent);
     const Component = mockRegistry.mock.calls[0][1]();
-    const tree = renderer.create(<Component componentId="123" />);
+    const tree = renderer.create(<Component componentId='123' />);
     expect(tree.toJSON()!.children).toEqual(['Hello, World!']);
   });
 });

lib/src/components/ComponentWrapper.test.tsx

@@ -21,8 +21,6 @@ describe('ComponentWrapper', () => {
     }
   }
 
-
-
   class TestParent extends React.Component<any, { propsFromState: {} }> {
     private ChildClass;
 
@@ -36,7 +34,7 @@ describe('ComponentWrapper', () => {
       return (
         <this.ChildClass
           ref={(r) => childRef = r}
-          componentId="component1"
+          componentId='component1'
           {...this.state.propsFromState}
         />
       );

lib/src/components/ComponentWrapper.tsx

@@ -2,8 +2,8 @@ import * as React from 'react';
 import * as  _ from 'lodash';
 
 interface State {
-  componentId: string,
-  allProps: {}
+  componentId: string;
+  allProps: {};
 }
 
 export class ComponentWrapper {
@@ -75,7 +75,7 @@ export class ComponentWrapper {
           />
         );
       }
-    };
+    }
 
     return WrappedComponent;
   }

lib/src/components/Store.test.ts

@@ -47,4 +47,3 @@ describe('Store', () => {
     expect(uut.getPropsForComponentId('refUniqueId')).toEqual({});
   });
 });
-

lib/src/events/PrivateEventsListener.ts

@@ -9,7 +9,7 @@ export class PrivateEventsListener {
     this.lifecycle = new Lifecycle(store);
   }
 
-  listenAndHandlePrivateEvents() {
+  public listenAndHandlePrivateEvents() {
     this.nativeEventsReceiver.registerComponentDidAppear(this.lifecycle.componentDidAppear);
     this.nativeEventsReceiver.registerComponentDidDisappear(this.lifecycle.componentDidDisappear);
     this.nativeEventsReceiver.registerNavigationButtonPressed(this.lifecycle.onNavigationButtonPressed);

lib/src/events/PublicEventsRegistry.ts

@@ -5,15 +5,15 @@ export class PublicEventsRegistry {
     this.nativeEventsReceiver = nativeEventsReceiver;
   }
 
-  onAppLaunched(callback) {
+  public onAppLaunched(callback) {
     this.nativeEventsReceiver.registerAppLaunched(callback);
   }
 
-  navigationCommands(callback) {
+  public navigationCommands(callback) {
     this.nativeEventsReceiver.registerNavigationCommands(callback);
   }
 
-  componentLifecycle(callback) {
+  public componentLifecycle(callback) {
     this.nativeEventsReceiver.registerComponentLifecycle(callback);
   }
 }

lib/src/index.ts

@@ -1,3 +1,3 @@
-import { singleton } from "./Navigation";
+import { singleton } from './Navigation';
 
 export const Navigation = singleton;

package.json

@@ -50,13 +50,16 @@
   "dependencies": {
     "lodash": "4.x.x",
     "prop-types": "15.x.x",
-    "tslib": "1.x.x"
+    "tslib": "1.x.x",
+    "@types/react": "16.x.x",
+    "@types/react-native": "0.49.x",
+    "@types/lodash": "4.x.x",
+    "@types/prop-types": "15.x.x",
+    "@types/react-test-renderer": "16.x.x",
+    "@types/jest": "22.x.x"
   },
   "devDependencies": {
     "detox": "6.x.x",
-    "eslint-config-xo": "0.18.x",
-    "eslint-config-xo-react": "0.13.x",
-    "eslint-plugin-react": "7.x.x",
     "jest": "22.x.x",
     "mocha": "4.x.x",
     "react": "16.0.0-beta.5",
@@ -67,14 +70,8 @@
     "remx": "2.x.x",
     "semver": "5.x.x",
     "shell-utils": "1.x.x",
-    "xo": "0.18.x",
-    "typescript": "2.x.x",
-    "@types/react": "16.x.x",
-    "@types/react-native": "0.49.x",
-    "@types/lodash": "4.x.x",
-    "@types/prop-types": "15.x.x",
-    "@types/react-test-renderer": "16.x.x",
-    "@types/jest": "22.x.x"
+    "tslint": "5.x.x",
+    "typescript": "2.x.x"
   },
   "babel": {
     "env": {
@@ -128,82 +125,5 @@
         "name": "iPhone SE"
       }
     }
-  },
-  "xo": {
-    "extends": "xo-react",
-    "space": true,
-    "env": [
-      "node",
-      "jest",
-      "es6"
-    ],
-    "globals": [
-      "alert"
-    ],
-    "overrides": [
-      {
-        "files": "e2e/**/*",
-        "env": [
-          "mocha"
-        ],
-        "globals": [
-          "before",
-          "after",
-          "beforeEach",
-          "afterEach",
-          "expect",
-          "element",
-          "by",
-          "device"
-        ]
-      }
-    ],
-    "settings": {
-      "import/core-modules": [
-        "react-native-navigation"
-      ]
-    },
-    "rules": {
-      "unicorn/filename-case": 0,
-      "unicorn/number-literal-case": 0,
-      "import/order": 0,
-      "import/named": 0,
-      "import/no-unassigned-import": 0,
-      "import/prefer-default-export": 0,
-      "import/no-unresolved": [
-        2,
-        {
-          "ignore": [
-            "react-native-navigation"
-          ]
-        }
-      ],
-      "react/jsx-tag-spacing": 0,
-      "react/jsx-sort-props": 0,
-      "react/jsx-boolean-value": 0,
-      "react/prop-types": 0,
-      "react/jsx-no-bind": 0,
-      "react/jsx-handler-names": 0,
-      "react/forbid-component-props": 0,
-      "react/jsx-curly-brace-presence": 0,
-      "capitalized-comments": 0,
-      "no-use-before-define": [
-        2,
-        {
-          "functions": false,
-          "variables": false
-        }
-      ],
-      "promise/param-names": 0,
-      "no-return-assign": 0,
-      "arrow-parens": [
-        2,
-        "always"
-      ],
-      "object-curly-spacing": [
-        2,
-        "always"
-      ]
-    }
   }
 }

scripts/release.js

@@ -1,4 +1,4 @@
-/* eslint-disable no-console */
+/* tslint:disable: no-console */
 const exec = require('shell-utils').exec;
 const semver = require('semver');
 const fs = require('fs');

scripts/test-js.js

@@ -4,7 +4,7 @@ const _ = require('lodash');
 const fix = _.includes(process.argv, '--fix') ? '--fix' : '';
 
 const dirs = [
-  'lib/dist',
+  'lib/src',
   'integration',
   'e2e',
   'scripts',
@@ -14,7 +14,7 @@ const dirs = [
 run();
 
 function run() {
-  const paths = _.chain(dirs).map((d) => `'${d}/**'`).join(' ').value();
-  exec.execSync(`xo ${paths} ${fix}`);
+  const paths = _.chain(dirs).map((d) => `'${d}/**/*.[tj]s*'`).join(' ').value();
+  exec.execSync(`tslint ${paths} ${fix} --format verbose`);
   exec.execSync(`jest --coverage`);
 }

scripts/test.all.js

@@ -1,4 +1,4 @@
-/* eslint-disable no-console */
+/* tslint:disable: no-console */
 const exec = require('shell-utils').exec;
 
 async function run() {

scripts/test.e2e.android.js

@@ -1,4 +1,4 @@
-/* eslint-disable no-console */
+/* tslint:disable: no-console */
 const _ = require('lodash');
 const exec = require('shell-utils').exec;
 

tsconfig-strict.json

@@ -18,6 +18,6 @@
     "strictFunctionTypes": true,
     "strictNullChecks": true,
     "strict": true,
-    "noImplicitAny": true
+    "noImplicitAny": false
   }
 }

tslint.json

@@ -0,0 +1,45 @@
+{
+  "defaultSeverity": "error",
+  "extends": [
+    "tslint:recommended"
+  ],
+  "jsRules": {
+    "quotemark": [
+      true,
+      "single"
+    ],
+    "max-line-length": [
+      true,
+      180
+    ],
+    "ordered-imports": false,
+    "trailing-comma": [
+      true,
+      "never"
+    ],
+    "member-access": false,
+    "interface-name": false,
+    "object-literal-sort-keys": false,
+    "max-classes-per-file": false
+  },
+  "rules": {
+    "quotemark": [
+      true,
+      "single"
+    ],
+    "max-line-length": [
+      true,
+      180
+    ],
+    "ordered-imports": false,
+    "trailing-comma": [
+      true,
+      "never"
+    ],
+    "member-access": false,
+    "interface-name": false,
+    "object-literal-sort-keys": false,
+    "max-classes-per-file": false
+  },
+  "rulesDirectory": []
+}