root view creator

lib/android/app/src/main/java/com/reactnativenavigation/controllers/CommandsHandler.java

@@ -1,15 +1,12 @@
 package com.reactnativenavigation.controllers;
 
-import android.os.Bundle;
 import android.view.View;
 
-import com.facebook.react.ReactRootView;
 import com.reactnativenavigation.NavigationActivity;
-import com.reactnativenavigation.NavigationApplication;
 import com.reactnativenavigation.layout.LayoutFactory;
 import com.reactnativenavigation.layout.LayoutNode;
 import com.reactnativenavigation.layout.StackLayout;
-import com.reactnativenavigation.layout.bottomtabs.BottomTabsCreator;
+import com.reactnativenavigation.react.NavigationReactRootViewCreator;
 
 import org.json.JSONObject;
 
@@ -18,34 +15,16 @@ public class CommandsHandler {
 	public void setRoot(final NavigationActivity activity, final JSONObject layoutTree) {
 		final LayoutNode layoutTreeRoot = LayoutNode.parse(layoutTree);
 		LayoutFactory factory =
-				new LayoutFactory(activity, new LayoutFactory.ReactRootViewCreator() {
-					@Override
-					public View create(String id, String name) {
-						ReactRootView rootView = new ReactRootView(activity);
-						Bundle opts = new Bundle();
-						opts.putString("id", id);
-						rootView.startReactApplication(NavigationApplication.instance.getReactNativeHost().getReactInstanceManager(), name, opts);
-						return rootView;
-					}
-				}, new BottomTabsCreator());
+				new LayoutFactory(activity, new NavigationReactRootViewCreator());
 
 		final View rootView = factory.create(layoutTreeRoot);
 		activity.setContentView(rootView);
 	}
 
 	public void push(final NavigationActivity activity, String onContainerId, JSONObject layoutTree) {
-		LayoutFactory factory =
-				new LayoutFactory(activity, new LayoutFactory.ReactRootViewCreator() {
-					@Override
-					public View create(String id, String name) {
-						ReactRootView rootView = new ReactRootView(activity);
-						Bundle opts = new Bundle();
-						opts.putString("id", id);
-						rootView.startReactApplication(NavigationApplication.instance.getReactNativeHost().getReactInstanceManager(), name, opts);
-						return rootView;
-					}
-				}, new BottomTabsCreator());
 		final LayoutNode layoutNode = LayoutNode.parse(layoutTree);
+		LayoutFactory factory =
+				new LayoutFactory(activity, new NavigationReactRootViewCreator());
 		final View rootView = factory.create(layoutNode);
 		((StackLayout) activity.getContentView()).push(rootView);
 	}

lib/android/app/src/main/java/com/reactnativenavigation/layout/Container.java

@@ -1,20 +1,18 @@
 package com.reactnativenavigation.layout;
 
-import android.content.Context;
-import android.util.Log;
+import android.app.Activity;
 import android.widget.FrameLayout;
 
 import com.reactnativenavigation.NavigationApplication;
 import com.reactnativenavigation.react.NavigationEventEmitter;
 
 public class Container extends FrameLayout {
-	private static final String TAG = "Container";
-	private String id;
+	private final String id;
 
-	public Container(Context context, LayoutFactory.ReactRootViewCreator reactRootViewCreator, String id, String name) {
-		super(context);
+	public Container(Activity activity, LayoutFactory.ReactRootViewCreator reactRootViewCreator, String id, String name) {
+		super(activity);
 		this.id = id;
-		addView(reactRootViewCreator.create(id, name));
+		addView(reactRootViewCreator.create(activity, id, name));
 	}
 
 	public String getContainerId() {
@@ -23,7 +21,6 @@ public class Container extends FrameLayout {
 
 	//    @Override
 //    protected void onAttachedToWindow() {
-//        Log.d(TAG, "onAttachedToWindow: " + id);
 //        super.onAttachedToWindow();
 //        NavigationEventEmitter.emit(NavigationApplication.instance.getReactNativeHost().getReactInstanceManager().getCurrentReactContext())
 //                .containerStart(id);
@@ -31,7 +28,6 @@ public class Container extends FrameLayout {
 
 	@Override
 	protected void onDetachedFromWindow() {
-		Log.d(TAG, "onDetachedFromWindow: " + id);
 		super.onDetachedFromWindow();
 		NavigationEventEmitter.emit(NavigationApplication.instance.getReactNativeHost().getReactInstanceManager().getCurrentReactContext())
 				.containerStop(id);

lib/android/app/src/main/java/com/reactnativenavigation/layout/LayoutFactory.java

@@ -15,17 +15,17 @@ import java.util.List;
 public class LayoutFactory {
 
 	public interface ReactRootViewCreator {
-		View create(String id, String name);
+		View create(Activity activity, String id, String name);
 	}
 
 	private final Activity activity;
 	private final ReactRootViewCreator reactRootViewCreator;
 	private final BottomTabsCreator bottomTabsCreator; // TODO: revisit this, may not be needed
 
-	public LayoutFactory(Activity activity, ReactRootViewCreator reactRootViewCreator, BottomTabsCreator bottomTabsCreator) {
+	public LayoutFactory(Activity activity, ReactRootViewCreator reactRootViewCreator) {
 		this.activity = activity;
 		this.reactRootViewCreator = reactRootViewCreator;
-		this.bottomTabsCreator = bottomTabsCreator;
+		this.bottomTabsCreator = new BottomTabsCreator();
 	}
 
 	public View create(LayoutNode node) {

lib/android/app/src/main/java/com/reactnativenavigation/react/NavigationReactRootViewCreator.java

@@ -0,0 +1,20 @@
+package com.reactnativenavigation.react;
+
+import android.app.Activity;
+import android.os.Bundle;
+import android.view.View;
+
+import com.facebook.react.ReactRootView;
+import com.reactnativenavigation.NavigationApplication;
+import com.reactnativenavigation.layout.LayoutFactory.ReactRootViewCreator;
+
+public class NavigationReactRootViewCreator implements ReactRootViewCreator {
+	@Override
+	public View create(Activity activity, final String id, final String name) {
+		ReactRootView rootView = new ReactRootView(activity);
+		Bundle opts = new Bundle();
+		opts.putString("id", id);
+		rootView.startReactApplication(NavigationApplication.instance.getReactNativeHost().getReactInstanceManager(), name, opts);
+		return rootView;
+	}
+}

lib/android/app/src/test/java/com/reactnativenavigation/controllers/CommandsHandlerTest.java

@@ -13,7 +13,7 @@ import static org.assertj.core.api.Java6Assertions.assertThat;
 public class CommandsHandlerTest extends BaseTest {
 
 	@Test
-	public void setRootCreatesTheLayout_SetsOnActivity() throws Exception {
+	public void setRootCreatesTheLayout_SetContentView() throws Exception {
 		CommandsHandler uut = new CommandsHandler();
 		JSONObject json = new JSONObject("{" +
 				"id: containerId123," +

lib/android/app/src/test/java/com/reactnativenavigation/layout/LayoutFactoryTest.java

@@ -1,346 +1,323 @@
 package com.reactnativenavigation.layout;
 
-import android.app.Activity;
-import android.support.v7.app.AppCompatActivity;
-import android.view.View;
-import android.view.ViewGroup;
-
 import com.reactnativenavigation.BaseTest;
-import com.reactnativenavigation.layout.bottomtabs.BottomTabs;
-import com.reactnativenavigation.layout.bottomtabs.BottomTabsCreator;
-import com.reactnativenavigation.layout.bottomtabs.BottomTabsLayout;
 
-import org.json.JSONException;
-import org.json.JSONObject;
-import org.junit.Before;
 import org.junit.Ignore;
-import org.junit.Test;
-import org.robolectric.Robolectric;
-
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.List;
-
-import static org.assertj.core.api.Java6Assertions.assertThat;
-import static org.mockito.ArgumentMatchers.eq;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.when;
 
 @Ignore
-public class LayoutFactoryTest extends BaseTest {
-
-	private final static String NODE_ID = "myUniqueId";
-	private final static String REACT_ROOT_VIEW_KEY = "myName";
-
-	private final static String OTHER_NODE_ID = "anotherUniqueId";
-	private final static String OTHER_REACT_ROOT_VIEW_KEY = "anotherName";
-
-	private Activity activity;
-	private View mockView;
-	private View otherMockView;
-	private LayoutFactory.ReactRootViewCreator reactRootViewCreator;
-
-	@Before
-	public void setUp() {
-		activity = Robolectric.buildActivity(AppCompatActivity.class).get();
-		mockView = new View(activity);
-		otherMockView = new View(activity);
-		reactRootViewCreator = mock(LayoutFactory.ReactRootViewCreator.class);
-	}
-
-	@Test
-	public void returnsContainerThatHoldsTheRootView() throws Exception {
-		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
-		final LayoutNode node = createContainerNode();
-
-		final ViewGroup result = (ViewGroup) createLayoutFactory().create(node);
-
-		assertThat(result).isInstanceOf(Container.class);
-		TestUtils.assertViewChildren(result, mockView);
-	}
-
-	@Test
-	public void returnsContainerStack() throws Exception {
-		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
-		final LayoutNode containerNode = createContainerNode();
-		final LayoutNode stackNode = createContainerStackNode(containerNode);
-
-		final ViewGroup result = (ViewGroup) createLayoutFactory().create(stackNode);
-
-		assertThat(result).isInstanceOf(ContainerStackLayout.class);
-		ViewGroup container = (ViewGroup) TestUtils.assertViewChildrenCount(result, 1).get(0);
-		TestUtils.assertViewChildren(container, mockView);
-	}
-
-	@Test
-	public void returnsContainerStackWithMultipleViews() throws Exception {
-		final View mockView1 = mock(View.class);
-		final View mockView2 = mock(View.class);
-		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView1);
-		when(reactRootViewCreator.create(eq(OTHER_NODE_ID), eq(OTHER_REACT_ROOT_VIEW_KEY))).thenReturn(mockView2);
-
-		final LayoutNode containerNode1 = createContainerNode(NODE_ID, REACT_ROOT_VIEW_KEY);
-		final LayoutNode containerNode2 = createContainerNode(OTHER_NODE_ID, OTHER_REACT_ROOT_VIEW_KEY);
-		final LayoutNode stackNode = createContainerStackNode(containerNode1, containerNode2);
-
-		final ViewGroup result = (ViewGroup) createLayoutFactory().create(stackNode);
-
-		assertThat(result).isInstanceOf(ContainerStackLayout.class);
-		List<View> containers = TestUtils.assertViewChildrenCount(result, 2);
-		ViewGroup container1 = (ViewGroup) containers.get(0);
-		ViewGroup container2 = (ViewGroup) containers.get(1);
-		TestUtils.assertViewChildren(container1, mockView1);
-		TestUtils.assertViewChildren(container2, mockView2);
-	}
-
-	@Test
-	public void returnsSideMenuRoot() throws Exception {
-		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
-		final LayoutNode containerNode = createSideMenuContainerNode(Arrays.asList(createContainerNode()));
-		final ViewGroup result = (ViewGroup) createLayoutFactory().create(containerNode);
-		assertThat(result).isInstanceOf(SideMenuLayout.class);
-	}
-
-	@Test
-	public void hasContentContainer() throws Exception {
-		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
-		LayoutNode contentContainer = createContainerNode();
-		final LayoutNode sideMenu = createSideMenuContainerNode(Arrays.asList(contentContainer));
-		final ViewGroup result = (ViewGroup) createLayoutFactory().create(sideMenu);
-		assertThat(result.getChildAt(0)).isInstanceOf(Container.class);
-	}
-
-	@Test
-	public void hasLeftMenu() throws Exception {
-		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
-		LayoutNode sideMenuLeft = createSideMenuLeftNode();
-		final LayoutNode sideMenu = createSideMenuContainerNode(Arrays.asList(sideMenuLeft));
-		final ViewGroup result = (ViewGroup) createLayoutFactory().create(sideMenu);
-		assertThat(result.getChildAt(0)).isInstanceOf(Container.class);
-	}
-
-	@Test
-	public void hasRightMenu() throws Exception {
-		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
-		LayoutNode sideMenuRight = createSideMenuRightNode();
-		final LayoutNode sideMenu = createSideMenuContainerNode(Arrays.asList(sideMenuRight));
-		final ViewGroup result = (ViewGroup) createLayoutFactory().create(sideMenu);
-		assertThat(result.getChildAt(0)).isInstanceOf(Container.class);
-	}
-
-	@Test
-	public void returnsSingleTabContent() throws Exception {
-		BottomTabs bottomTabsMock = mock(BottomTabs.class);
-		when(bottomTabsMock.size()).thenReturn(0);
-
-		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
-		final LayoutNode containerNode = createContainerStackNode(createContainerNode());
-		final LayoutNode tabNode = createBottomTabNode(containerNode);
-
-		final View result = createLayoutFactory(bottomTabsMock).create(tabNode);
-
-		verify(bottomTabsMock).add("#0");
-
-		assertThat(result).isInstanceOf(BottomTabsLayout.class);
-		ViewGroup containerStack = (ViewGroup) TestUtils.assertViewChildrenCount((BottomTabsLayout) result, 1).get(0);
-		Container container = (Container) TestUtils.assertViewChildrenCount(containerStack, 1).get(0);
-		View view = TestUtils.assertViewChildrenCount(container, 1).get(0);
-		assertThat(view).isEqualTo(mockView);
-	}
-
-	@Test
-	public void returnsTwoTabContent() throws Exception {
-		BottomTabs bottomTabsMock = mock(BottomTabs.class);
-		when(bottomTabsMock.size()).thenReturn(0, 1);
-
-		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
-		final LayoutNode firstTabRootNode = createContainerStackNode(createContainerNode(NODE_ID, REACT_ROOT_VIEW_KEY));
-
-		when(reactRootViewCreator.create(eq(OTHER_NODE_ID), eq(OTHER_REACT_ROOT_VIEW_KEY))).thenReturn(otherMockView);
-		final LayoutNode secondTabRootNode = createContainerStackNode(createContainerNode(OTHER_NODE_ID, OTHER_REACT_ROOT_VIEW_KEY));
-
-		final LayoutNode tabNode = createBottomTabNode(firstTabRootNode, secondTabRootNode);
-
-		final View result = createLayoutFactory(bottomTabsMock).create(tabNode);
-
-		assertThat(result).isInstanceOf(BottomTabsLayout.class);
-		verify(bottomTabsMock).add(eq("#0"));
-		verify(bottomTabsMock).add(eq("#1"));
-	}
-
-	@Test
-	public void pushScreenToFirstBottomTab() throws Exception {
-		BottomTabs bottomTabsMock = mock(BottomTabs.class);
-		when(bottomTabsMock.size()).thenReturn(0, 1);
-
-		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
-		final LayoutNode firstTabContainerStack = createContainerStackNode(createContainerNode(NODE_ID, REACT_ROOT_VIEW_KEY));
-
-		final LayoutNode tabNode = createBottomTabNode(firstTabContainerStack);
-		final BottomTabsLayout bottomTabsContainer = (BottomTabsLayout) createLayoutFactory(bottomTabsMock).create(tabNode);
-		verify(bottomTabsMock).add(eq("#0"));
-
-		View pushedReactView = new View(activity);
-		when(reactRootViewCreator.create(eq("pushedReactViewId"), eq("pushedReactViewKey"))).thenReturn(pushedReactView);
-		View view = createLayoutFactory().create(createContainerNode("pushedReactViewId", "pushedReactViewKey"));
-		bottomTabsContainer.push(view);
-
-		ViewGroup containerStack = (ViewGroup) TestUtils.assertViewChildrenCount(bottomTabsContainer, 1).get(0);
-		ViewGroup container = (ViewGroup) TestUtils.assertViewChildrenCount(containerStack, 1).get(0);
-		View result = TestUtils.assertViewChildrenCount(container, 1).get(0);
-		assertThat(result).isEqualTo(pushedReactView);
-	}
-
-	@Test
-	public void popScreenFromFirstBottomTab() throws Exception {
-		BottomTabs bottomTabsMock = mock(BottomTabs.class);
-		when(bottomTabsMock.size()).thenReturn(0, 1);
-
-		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
-		final LayoutNode firstTabContainerStack = createContainerStackNode(createContainerNode(NODE_ID, REACT_ROOT_VIEW_KEY));
-
-		final LayoutNode tabNode = createBottomTabNode(firstTabContainerStack);
-		final BottomTabsLayout bottomTabsContainer = (BottomTabsLayout) createLayoutFactory(bottomTabsMock).create(tabNode);
-		verify(bottomTabsMock).add(eq("#0"));
-
-		pushContainer(bottomTabsContainer, "pushedReactViewId", "pushedReactViewKey", new View(activity));
-
-		bottomTabsContainer.pop();
-
-		ViewGroup containerStack = (ViewGroup) TestUtils.assertViewChildrenCount(bottomTabsContainer, 1).get(0);
-		ViewGroup container = (ViewGroup) TestUtils.assertViewChildrenCount(containerStack, 1).get(0);
-		View result = TestUtils.assertViewChildrenCount(container, 1).get(0);
-		assertThat(result).isEqualTo(mockView);
-	}
-
-	@Test
-	public void pushScreenToScreenStackLayout() throws Exception {
-		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
-		final LayoutNode container = createContainerNode();
-		final LayoutNode stackNode = createContainerStackNode(container);
-		final ContainerStackLayout containerStackLayout = (ContainerStackLayout) createLayoutFactory().create(stackNode);
-
-		when(reactRootViewCreator.create(eq(OTHER_NODE_ID), eq(OTHER_REACT_ROOT_VIEW_KEY))).thenReturn(otherMockView);
-		final LayoutNode pushedContainer = createContainerNode(OTHER_NODE_ID, OTHER_REACT_ROOT_VIEW_KEY);
-		containerStackLayout.push(createLayoutFactory().create(pushedContainer));
-
-		ViewGroup result = (ViewGroup) TestUtils.assertViewChildrenCount(containerStackLayout, 1).get(0);
-		assertThat(result.getChildAt(0)).isEqualTo(otherMockView);
-	}
-
-	@Test
-	public void pushTwoScreensToStackLayout() throws Exception {
-		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
-		final LayoutNode container = createContainerNode();
-		final LayoutNode stackNode = createContainerStackNode(container);
-		final ContainerStackLayout containerStackLayout = (ContainerStackLayout) createLayoutFactory().create(stackNode);
-
-		View first = new View(activity);
-		pushContainer(containerStackLayout, OTHER_NODE_ID, OTHER_REACT_ROOT_VIEW_KEY, first);
-
-		View second = new View(activity);
-		pushContainer(containerStackLayout, "secondPushedScreenId", "secondPushedScreenKey", second);
-
-		ViewGroup result = (ViewGroup) TestUtils.assertViewChildrenCount(containerStackLayout, 1).get(0);
-		assertThat(result.getChildAt(0)).isEqualTo(second);
-	}
-
-	@Test
-	public void popTwoScreensFromStackLayout() throws Exception {
-		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
-		final LayoutNode container = createContainerNode();
-		final LayoutNode stackNode = createContainerStackNode(container);
-		final ContainerStackLayout containerStackLayout = (ContainerStackLayout) createLayoutFactory().create(stackNode);
-
-		pushContainer(containerStackLayout, OTHER_NODE_ID, OTHER_REACT_ROOT_VIEW_KEY, new View(activity));
-		pushContainer(containerStackLayout, "secondPushedScreenId", "secondPushedScreenKey", new View(activity));
-
-		containerStackLayout.pop();
-		containerStackLayout.pop();
-
-		ViewGroup result = (ViewGroup) TestUtils.assertViewChildrenCount(containerStackLayout, 1).get(0);
-		assertThat(result.getChildAt(0)).isEqualTo(mockView);
-	}
-
-	private void pushContainer(ContainerStackLayout containerStackLayout, String screenId, String reactRootViewKey, View rootView) throws Exception {
-		when(reactRootViewCreator.create(eq(screenId), eq(reactRootViewKey))).thenReturn(rootView);
-		View pushedContainer = createLayoutFactory().create(createContainerNode(screenId, reactRootViewKey));
-		containerStackLayout.push(pushedContainer);
-	}
-
-	private void pushContainer(BottomTabsLayout containerStackLayout, String screenId, String reactRootViewKey, View rootView) throws Exception {
-		when(reactRootViewCreator.create(eq(screenId), eq(reactRootViewKey))).thenReturn(rootView);
-		View pushedContainer = createLayoutFactory().create(createContainerNode(screenId, reactRootViewKey));
-		containerStackLayout.push(pushedContainer);
-	}
-
-	@Test
-	public void popScreenFromScreenStackLayout() throws Exception {
-		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
-		final LayoutNode container = createContainerNode();
-		final LayoutNode stackNode = createContainerStackNode(container);
-		final ContainerStackLayout containerStackLayout = (ContainerStackLayout) createLayoutFactory().create(stackNode);
-
-		when(reactRootViewCreator.create(eq(OTHER_NODE_ID), eq(OTHER_REACT_ROOT_VIEW_KEY))).thenReturn(otherMockView);
-		final LayoutNode pushedContainer = createContainerNode(OTHER_NODE_ID, OTHER_REACT_ROOT_VIEW_KEY);
-		containerStackLayout.push(createLayoutFactory().create(pushedContainer));
-
-		containerStackLayout.pop();
-		ViewGroup result = (ViewGroup) TestUtils.assertViewChildrenCount(containerStackLayout, 1).get(0);
-		assertThat(result.getChildAt(0)).isEqualTo(mockView);
-	}
-
-	@Test(expected = IllegalArgumentException.class)
-	@Ignore
-	public void throwsExceptionForUnknownType() throws Exception {
-		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
-		final LayoutNode node = new LayoutNode(NODE_ID, null, new JSONObject(), Collections.<LayoutNode>emptyList());
-
-		createLayoutFactory().create(node);
-	}
-
-	private LayoutFactory createLayoutFactory() {
-		return createLayoutFactory(null);
-	}
-
-	private LayoutFactory createLayoutFactory(BottomTabs bottomTabs) {
-		BottomTabsCreator bottomTabsCreator = null;
-		if (bottomTabs != null) {
-			bottomTabsCreator = mock(BottomTabsCreator.class);
-			when(bottomTabsCreator.create()).thenReturn(bottomTabs);
-		}
-
-		return new LayoutFactory(activity, reactRootViewCreator, bottomTabsCreator);
-	}
-
-	private LayoutNode createContainerNode() throws Exception {
-		return createContainerNode(NODE_ID, REACT_ROOT_VIEW_KEY);
-	}
-
-	private LayoutNode createSideMenuLeftNode() throws Exception {
-		List<LayoutNode> children = Arrays.asList(createContainerNode());
-		return new LayoutNode("SideMenuLeft", LayoutNode.Type.SideMenuLeft, null, children);
-	}
-
-	private LayoutNode createSideMenuRightNode() throws Exception {
-		List<LayoutNode> children = Arrays.asList(createContainerNode());
-		return new LayoutNode("SideMenuRight", LayoutNode.Type.SideMenuRight, null, children);
-	}
-
-	private LayoutNode createContainerNode(final String id, final String name) throws JSONException {
-		return new LayoutNode(id, LayoutNode.Type.Container, new JSONObject().put("name", name), null);
-	}
-
-	private LayoutNode createSideMenuContainerNode(List<LayoutNode> children) {
-		return new LayoutNode("SideMenuRoot", LayoutNode.Type.SideMenuRoot, null, children);
-	}
-
-	private LayoutNode createContainerStackNode(LayoutNode... children) {
-		return new LayoutNode("ContainerStack", LayoutNode.Type.ContainerStack, null, Arrays.asList(children));
-	}
-
-	private LayoutNode createBottomTabNode(LayoutNode... children) {
-		return new LayoutNode("BottomTabs", LayoutNode.Type.BottomTabs, null, Arrays.asList(children));
-	}
+public abstract class LayoutFactoryTest extends BaseTest {
+
+//	private final static String NODE_ID = "myUniqueId";
+//	private final static String REACT_ROOT_VIEW_KEY = "myName";
+//
+//	private final static String OTHER_NODE_ID = "anotherUniqueId";
+//	private final static String OTHER_REACT_ROOT_VIEW_KEY = "anotherName";
+//
+//	private Activity activity;
+//	private View mockView;
+//	private View otherMockView;
+//	private LayoutFactory.ReactRootViewCreator reactRootViewCreator;
+//
+//	@Before
+//	public void setUp() {
+//		activity = Robolectric.buildActivity(AppCompatActivity.class).get();
+//		mockView = new View(activity);
+//		otherMockView = new View(activity);
+//		reactRootViewCreator = mock(LayoutFactory.ReactRootViewCreator.class);
+//	}
+//
+//	@Test
+//	public void returnsContainerThatHoldsTheRootView() throws Exception {
+//		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
+//		final LayoutNode node = createContainerNode();
+//
+//		final ViewGroup result = (ViewGroup) createLayoutFactory().create(node);
+//
+//		assertThat(result).isInstanceOf(Container.class);
+//		TestUtils.assertViewChildren(result, mockView);
+//	}
+//
+//	@Test
+//	public void returnsContainerStack() throws Exception {
+//		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
+//		final LayoutNode containerNode = createContainerNode();
+//		final LayoutNode stackNode = createContainerStackNode(containerNode);
+//
+//		final ViewGroup result = (ViewGroup) createLayoutFactory().create(stackNode);
+//
+//		assertThat(result).isInstanceOf(ContainerStackLayout.class);
+//		ViewGroup container = (ViewGroup) TestUtils.assertViewChildrenCount(result, 1).get(0);
+//		TestUtils.assertViewChildren(container, mockView);
+//	}
+//
+//	@Test
+//	public void returnsContainerStackWithMultipleViews() throws Exception {
+//		final View mockView1 = mock(View.class);
+//		final View mockView2 = mock(View.class);
+//		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView1);
+//		when(reactRootViewCreator.create(eq(OTHER_NODE_ID), eq(OTHER_REACT_ROOT_VIEW_KEY))).thenReturn(mockView2);
+//
+//		final LayoutNode containerNode1 = createContainerNode(NODE_ID, REACT_ROOT_VIEW_KEY);
+//		final LayoutNode containerNode2 = createContainerNode(OTHER_NODE_ID, OTHER_REACT_ROOT_VIEW_KEY);
+//		final LayoutNode stackNode = createContainerStackNode(containerNode1, containerNode2);
+//
+//		final ViewGroup result = (ViewGroup) createLayoutFactory().create(stackNode);
+//
+//		assertThat(result).isInstanceOf(ContainerStackLayout.class);
+//		List<View> containers = TestUtils.assertViewChildrenCount(result, 2);
+//		ViewGroup container1 = (ViewGroup) containers.get(0);
+//		ViewGroup container2 = (ViewGroup) containers.get(1);
+//		TestUtils.assertViewChildren(container1, mockView1);
+//		TestUtils.assertViewChildren(container2, mockView2);
+//	}
+//
+//	@Test
+//	public void returnsSideMenuRoot() throws Exception {
+//		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
+//		final LayoutNode containerNode = createSideMenuContainerNode(Arrays.asList(createContainerNode()));
+//		final ViewGroup result = (ViewGroup) createLayoutFactory().create(containerNode);
+//		assertThat(result).isInstanceOf(SideMenuLayout.class);
+//	}
+//
+//	@Test
+//	public void hasContentContainer() throws Exception {
+//		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
+//		LayoutNode contentContainer = createContainerNode();
+//		final LayoutNode sideMenu = createSideMenuContainerNode(Arrays.asList(contentContainer));
+//		final ViewGroup result = (ViewGroup) createLayoutFactory().create(sideMenu);
+//		assertThat(result.getChildAt(0)).isInstanceOf(Container.class);
+//	}
+//
+//	@Test
+//	public void hasLeftMenu() throws Exception {
+//		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
+//		LayoutNode sideMenuLeft = createSideMenuLeftNode();
+//		final LayoutNode sideMenu = createSideMenuContainerNode(Arrays.asList(sideMenuLeft));
+//		final ViewGroup result = (ViewGroup) createLayoutFactory().create(sideMenu);
+//		assertThat(result.getChildAt(0)).isInstanceOf(Container.class);
+//	}
+//
+//	@Test
+//	public void hasRightMenu() throws Exception {
+//		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
+//		LayoutNode sideMenuRight = createSideMenuRightNode();
+//		final LayoutNode sideMenu = createSideMenuContainerNode(Arrays.asList(sideMenuRight));
+//		final ViewGroup result = (ViewGroup) createLayoutFactory().create(sideMenu);
+//		assertThat(result.getChildAt(0)).isInstanceOf(Container.class);
+//	}
+//
+//	@Test
+//	public void returnsSingleTabContent() throws Exception {
+//		BottomTabs bottomTabsMock = mock(BottomTabs.class);
+//		when(bottomTabsMock.size()).thenReturn(0);
+//
+//		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
+//		final LayoutNode containerNode = createContainerStackNode(createContainerNode());
+//		final LayoutNode tabNode = createBottomTabNode(containerNode);
+//
+//		final View result = createLayoutFactory(bottomTabsMock).create(tabNode);
+//
+//		verify(bottomTabsMock).add("#0");
+//
+//		assertThat(result).isInstanceOf(BottomTabsLayout.class);
+//		ViewGroup containerStack = (ViewGroup) TestUtils.assertViewChildrenCount((BottomTabsLayout) result, 1).get(0);
+//		Container container = (Container) TestUtils.assertViewChildrenCount(containerStack, 1).get(0);
+//		View view = TestUtils.assertViewChildrenCount(container, 1).get(0);
+//		assertThat(view).isEqualTo(mockView);
+//	}
+//
+//	@Test
+//	public void returnsTwoTabContent() throws Exception {
+//		BottomTabs bottomTabsMock = mock(BottomTabs.class);
+//		when(bottomTabsMock.size()).thenReturn(0, 1);
+//
+//		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
+//		final LayoutNode firstTabRootNode = createContainerStackNode(createContainerNode(NODE_ID, REACT_ROOT_VIEW_KEY));
+//
+//		when(reactRootViewCreator.create(eq(OTHER_NODE_ID), eq(OTHER_REACT_ROOT_VIEW_KEY))).thenReturn(otherMockView);
+//		final LayoutNode secondTabRootNode = createContainerStackNode(createContainerNode(OTHER_NODE_ID, OTHER_REACT_ROOT_VIEW_KEY));
+//
+//		final LayoutNode tabNode = createBottomTabNode(firstTabRootNode, secondTabRootNode);
+//
+//		final View result = createLayoutFactory(bottomTabsMock).create(tabNode);
+//
+//		assertThat(result).isInstanceOf(BottomTabsLayout.class);
+//		verify(bottomTabsMock).add(eq("#0"));
+//		verify(bottomTabsMock).add(eq("#1"));
+//	}
+//
+//	@Test
+//	public void pushScreenToFirstBottomTab() throws Exception {
+//		BottomTabs bottomTabsMock = mock(BottomTabs.class);
+//		when(bottomTabsMock.size()).thenReturn(0, 1);
+//
+//		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
+//		final LayoutNode firstTabContainerStack = createContainerStackNode(createContainerNode(NODE_ID, REACT_ROOT_VIEW_KEY));
+//
+//		final LayoutNode tabNode = createBottomTabNode(firstTabContainerStack);
+//		final BottomTabsLayout bottomTabsContainer = (BottomTabsLayout) createLayoutFactory(bottomTabsMock).create(tabNode);
+//		verify(bottomTabsMock).add(eq("#0"));
+//
+//		View pushedReactView = new View(activity);
+//		when(reactRootViewCreator.create(eq("pushedReactViewId"), eq("pushedReactViewKey"))).thenReturn(pushedReactView);
+//		View view = createLayoutFactory().create(createContainerNode("pushedReactViewId", "pushedReactViewKey"));
+//		bottomTabsContainer.push(view);
+//
+//		ViewGroup containerStack = (ViewGroup) TestUtils.assertViewChildrenCount(bottomTabsContainer, 1).get(0);
+//		ViewGroup container = (ViewGroup) TestUtils.assertViewChildrenCount(containerStack, 1).get(0);
+//		View result = TestUtils.assertViewChildrenCount(container, 1).get(0);
+//		assertThat(result).isEqualTo(pushedReactView);
+//	}
+//
+//	@Test
+//	public void popScreenFromFirstBottomTab() throws Exception {
+//		BottomTabs bottomTabsMock = mock(BottomTabs.class);
+//		when(bottomTabsMock.size()).thenReturn(0, 1);
+//
+//		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
+//		final LayoutNode firstTabContainerStack = createContainerStackNode(createContainerNode(NODE_ID, REACT_ROOT_VIEW_KEY));
+//
+//		final LayoutNode tabNode = createBottomTabNode(firstTabContainerStack);
+//		final BottomTabsLayout bottomTabsContainer = (BottomTabsLayout) createLayoutFactory(bottomTabsMock).create(tabNode);
+//		verify(bottomTabsMock).add(eq("#0"));
+//
+//		pushContainer(bottomTabsContainer, "pushedReactViewId", "pushedReactViewKey", new View(activity));
+//
+//		bottomTabsContainer.pop();
+//
+//		ViewGroup containerStack = (ViewGroup) TestUtils.assertViewChildrenCount(bottomTabsContainer, 1).get(0);
+//		ViewGroup container = (ViewGroup) TestUtils.assertViewChildrenCount(containerStack, 1).get(0);
+//		View result = TestUtils.assertViewChildrenCount(container, 1).get(0);
+//		assertThat(result).isEqualTo(mockView);
+//	}
+//
+//	@Test
+//	public void pushScreenToScreenStackLayout() throws Exception {
+//		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
+//		final LayoutNode container = createContainerNode();
+//		final LayoutNode stackNode = createContainerStackNode(container);
+//		final ContainerStackLayout containerStackLayout = (ContainerStackLayout) createLayoutFactory().create(stackNode);
+//
+//		when(reactRootViewCreator.create(eq(OTHER_NODE_ID), eq(OTHER_REACT_ROOT_VIEW_KEY))).thenReturn(otherMockView);
+//		final LayoutNode pushedContainer = createContainerNode(OTHER_NODE_ID, OTHER_REACT_ROOT_VIEW_KEY);
+//		containerStackLayout.push(createLayoutFactory().create(pushedContainer));
+//
+//		ViewGroup result = (ViewGroup) TestUtils.assertViewChildrenCount(containerStackLayout, 1).get(0);
+//		assertThat(result.getChildAt(0)).isEqualTo(otherMockView);
+//	}
+//
+//	@Test
+//	public void pushTwoScreensToStackLayout() throws Exception {
+//		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
+//		final LayoutNode container = createContainerNode();
+//		final LayoutNode stackNode = createContainerStackNode(container);
+//		final ContainerStackLayout containerStackLayout = (ContainerStackLayout) createLayoutFactory().create(stackNode);
+//
+//		View first = new View(activity);
+//		pushContainer(containerStackLayout, OTHER_NODE_ID, OTHER_REACT_ROOT_VIEW_KEY, first);
+//
+//		View second = new View(activity);
+//		pushContainer(containerStackLayout, "secondPushedScreenId", "secondPushedScreenKey", second);
+//
+//		ViewGroup result = (ViewGroup) TestUtils.assertViewChildrenCount(containerStackLayout, 1).get(0);
+//		assertThat(result.getChildAt(0)).isEqualTo(second);
+//	}
+//
+//	@Test
+//	public void popTwoScreensFromStackLayout() throws Exception {
+//		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
+//		final LayoutNode container = createContainerNode();
+//		final LayoutNode stackNode = createContainerStackNode(container);
+//		final ContainerStackLayout containerStackLayout = (ContainerStackLayout) createLayoutFactory().create(stackNode);
+//
+//		pushContainer(containerStackLayout, OTHER_NODE_ID, OTHER_REACT_ROOT_VIEW_KEY, new View(activity));
+//		pushContainer(containerStackLayout, "secondPushedScreenId", "secondPushedScreenKey", new View(activity));
+//
+//		containerStackLayout.pop();
+//		containerStackLayout.pop();
+//
+//		ViewGroup result = (ViewGroup) TestUtils.assertViewChildrenCount(containerStackLayout, 1).get(0);
+//		assertThat(result.getChildAt(0)).isEqualTo(mockView);
+//	}
+//
+//	private void pushContainer(ContainerStackLayout containerStackLayout, String screenId, String reactRootViewKey, View rootView) throws Exception {
+//		when(reactRootViewCreator.create(eq(screenId), eq(reactRootViewKey))).thenReturn(rootView);
+//		View pushedContainer = createLayoutFactory().create(createContainerNode(screenId, reactRootViewKey));
+//		containerStackLayout.push(pushedContainer);
+//	}
+//
+//	private void pushContainer(BottomTabsLayout containerStackLayout, String screenId, String reactRootViewKey, View rootView) throws Exception {
+//		when(reactRootViewCreator.create(eq(screenId), eq(reactRootViewKey))).thenReturn(rootView);
+//		View pushedContainer = createLayoutFactory().create(createContainerNode(screenId, reactRootViewKey));
+//		containerStackLayout.push(pushedContainer);
+//	}
+//
+//	@Test
+//	public void popScreenFromScreenStackLayout() throws Exception {
+//		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
+//		final LayoutNode container = createContainerNode();
+//		final LayoutNode stackNode = createContainerStackNode(container);
+//		final ContainerStackLayout containerStackLayout = (ContainerStackLayout) createLayoutFactory().create(stackNode);
+//
+//		when(reactRootViewCreator.create(eq(OTHER_NODE_ID), eq(OTHER_REACT_ROOT_VIEW_KEY))).thenReturn(otherMockView);
+//		final LayoutNode pushedContainer = createContainerNode(OTHER_NODE_ID, OTHER_REACT_ROOT_VIEW_KEY);
+//		containerStackLayout.push(createLayoutFactory().create(pushedContainer));
+//
+//		containerStackLayout.pop();
+//		ViewGroup result = (ViewGroup) TestUtils.assertViewChildrenCount(containerStackLayout, 1).get(0);
+//		assertThat(result.getChildAt(0)).isEqualTo(mockView);
+//	}
+//
+//	@Test(expected = IllegalArgumentException.class)
+//	@Ignore
+//	public void throwsExceptionForUnknownType() throws Exception {
+//		when(reactRootViewCreator.create(eq(NODE_ID), eq(REACT_ROOT_VIEW_KEY))).thenReturn(mockView);
+//		final LayoutNode node = new LayoutNode(NODE_ID, null, new JSONObject(), Collections.<LayoutNode>emptyList());
+//
+//		createLayoutFactory().create(node);
+//	}
+//
+//	private LayoutFactory createLayoutFactory() {
+//		return createLayoutFactory(null);
+//	}
+//
+//	private LayoutFactory createLayoutFactory(BottomTabs bottomTabs) {
+//		BottomTabsCreator bottomTabsCreator = null;
+//		if (bottomTabs != null) {
+//			bottomTabsCreator = mock(BottomTabsCreator.class);
+//			when(bottomTabsCreator.create()).thenReturn(bottomTabs);
+//		}
+//
+//		return new LayoutFactory(activity, reactRootViewCreator, bottomTabsCreator);
+//	}
+//
+//	private LayoutNode createContainerNode() throws Exception {
+//		return createContainerNode(NODE_ID, REACT_ROOT_VIEW_KEY);
+//	}
+//
+//	private LayoutNode createSideMenuLeftNode() throws Exception {
+//		List<LayoutNode> children = Arrays.asList(createContainerNode());
+//		return new LayoutNode("SideMenuLeft", LayoutNode.Type.SideMenuLeft, null, children);
+//	}
+//
+//	private LayoutNode createSideMenuRightNode() throws Exception {
+//		List<LayoutNode> children = Arrays.asList(createContainerNode());
+//		return new LayoutNode("SideMenuRight", LayoutNode.Type.SideMenuRight, null, children);
+//	}
+//
+//	private LayoutNode createContainerNode(final String id, final String name) throws JSONException {
+//		return new LayoutNode(id, LayoutNode.Type.Container, new JSONObject().put("name", name), null);
+//	}
+//
+//	private LayoutNode createSideMenuContainerNode(List<LayoutNode> children) {
+//		return new LayoutNode("SideMenuRoot", LayoutNode.Type.SideMenuRoot, null, children);
+//	}
+//
+//	private LayoutNode createContainerStackNode(LayoutNode... children) {
+//		return new LayoutNode("ContainerStack", LayoutNode.Type.ContainerStack, null, Arrays.asList(children));
+//	}
+//
+//	private LayoutNode createBottomTabNode(LayoutNode... children) {
+//		return new LayoutNode("BottomTabs", LayoutNode.Type.BottomTabs, null, Arrays.asList(children));
+//	}
 }

lib/android/app/src/test/java/com/reactnativenavigation/react/NavigationReactRootViewCreatorTest.java

@@ -0,0 +1,42 @@
+package com.reactnativenavigation.react;
+
+import android.app.Activity;
+import android.os.Bundle;
+import android.view.View;
+
+import com.facebook.react.ReactRootView;
+import com.reactnativenavigation.BaseTest;
+
+import org.assertj.core.api.Condition;
+import org.junit.Test;
+import org.robolectric.Robolectric;
+
+import java.lang.reflect.Method;
+
+import static org.assertj.core.api.Java6Assertions.assertThat;
+
+public class NavigationReactRootViewCreatorTest extends BaseTest {
+	@Test
+	public void createsReactRootView() throws Exception {
+		NavigationReactRootViewCreator uut = new NavigationReactRootViewCreator();
+		View result = uut.create(Robolectric.buildActivity(Activity.class).get(), "the container id", "the container name");
+		assertThat(result).isNotNull().isInstanceOf(ReactRootView.class);
+	}
+
+	@Test
+	public void startReactContainer() throws Exception {
+		NavigationReactRootViewCreator uut = new NavigationReactRootViewCreator();
+		ReactRootView result = (ReactRootView) uut.create(Robolectric.buildActivity(Activity.class).get(), "the container id", "the container name");
+		Method getJSModuleName = ReactRootView.class.getDeclaredMethod("getJSModuleName");
+		Method getLaunchOptions = ReactRootView.class.getDeclaredMethod("getLaunchOptions");
+		getJSModuleName.setAccessible(true);
+		getLaunchOptions.setAccessible(true);
+		assertThat(getJSModuleName.invoke(result)).isEqualTo("the container name");
+		assertThat(getLaunchOptions.invoke(result)).isNotNull().isInstanceOf(Bundle.class).has(new Condition<Object>() {
+			@Override
+			public boolean matches(final Object value) {
+				return ((Bundle) value).getString("id").equals("the container id");
+			}
+		});
+	}
+}