Fix bottomTabs visible false wrong layout (#6095)

* Use viewController hidesBottomBarWhenPushed method for bottomTabs visibility

lib/ios/BottomTabsBasePresenter.m

@@ -17,7 +17,6 @@
     RNNNavigationOptions *withDefault = [options withDefault:[self defaultOptions]];
 
     [bottomTabs setTabBarTestID:[withDefault.bottomTabs.testID getWithDefaultValue:nil]];
-    [bottomTabs setTabBarVisible:[withDefault.bottomTabs.visible getWithDefaultValue:YES] animated:[withDefault.bottomTabs.animate getWithDefaultValue:NO]];
     
     [bottomTabs.view setBackgroundColor:[withDefault.layout.backgroundColor getWithDefaultValue:nil]];
     [self applyBackgroundColor:[withDefault.bottomTabs.backgroundColor getWithDefaultValue:nil] translucent:[withDefault.bottomTabs.translucent getWithDefaultValue:NO]];

lib/ios/RNNBasePresenter.h

@@ -47,4 +47,6 @@ typedef void (^RNNReactViewReadyCompletionBlock)(void);
 
 - (BOOL)getStatusBarVisibility;
 
+- (BOOL)hidesBottomBarWhenPushed;
+
 @end

lib/ios/RNNBasePresenter.m

@@ -119,5 +119,9 @@
     return NO;
 }
 
+- (BOOL)hidesBottomBarWhenPushed {
+    RNNNavigationOptions *withDefault = [self.boundViewController.topMostViewController.resolveOptions withDefault:self.defaultOptions];
+    return ![withDefault.bottomTabs.visible getWithDefaultValue:YES];
+}
 
 @end

lib/ios/RNNBottomTabsController.m

@@ -131,5 +131,9 @@
     return [self.presenter getOrientation];
 }
 
+- (BOOL)hidesBottomBarWhenPushed {
+    return [self.presenter hidesBottomBarWhenPushed];
+}
+
 
 @end

lib/ios/RNNComponentViewController.m

@@ -148,5 +148,8 @@
     return [self.presenter getOrientation];
 }
 
+- (BOOL)hidesBottomBarWhenPushed {
+    return [self.presenter hidesBottomBarWhenPushed];
+}
 
 @end

lib/ios/RNNExternalViewController.m

@@ -48,4 +48,8 @@
     return [self.presenter getOrientation];
 }
 
+- (BOOL)hidesBottomBarWhenPushed {
+    return [self.presenter hidesBottomBarWhenPushed];
+}
+
 @end

lib/ios/RNNSideMenuChildVC.m

@@ -57,4 +57,8 @@
     return [self.presenter getOrientation];
 }
 
+- (BOOL)hidesBottomBarWhenPushed {
+    return [self.presenter hidesBottomBarWhenPushed];
+}
+
 @end

lib/ios/RNNSideMenuController.m

@@ -173,4 +173,8 @@
     return [self.presenter getOrientation];
 }
 
+- (BOOL)hidesBottomBarWhenPushed {
+    return [self.presenter hidesBottomBarWhenPushed];
+}
+
 @end

lib/ios/RNNSplitViewController.m

@@ -31,4 +31,8 @@
     return [self.presenter getOrientation];
 }
 
+- (BOOL)hidesBottomBarWhenPushed {
+    return [self.presenter hidesBottomBarWhenPushed];
+}
+
 @end

lib/ios/RNNStackController.m

@@ -72,4 +72,8 @@
     return [self.presenter getOrientation];
 }
 
+- (BOOL)hidesBottomBarWhenPushed {
+    return [self.presenter hidesBottomBarWhenPushed];
+}
+
 @end

playground/ios/NavigationIOS12Tests/RNNBottomTabsPresenterTest.m

@@ -28,7 +28,6 @@
 	[[(id)self.uut expect] applyBackgroundColor:nil translucent:NO];
     [[self.boundViewController expect] setTabBarHideShadow:NO];
     [[self.boundViewController expect] setTabBarStyle:UIBarStyleDefault];
-    [[self.boundViewController expect] setTabBarVisible:YES animated:NO];
     [self.uut applyOptions:emptyOptions];
     [self.boundViewController verify];
 }
@@ -46,7 +45,6 @@
     [[(id)self.uut expect] applyBackgroundColor:nil translucent:[UIColor redColor]];
     [[self.boundViewController expect] setTabBarHideShadow:YES];
     [[self.boundViewController expect] setTabBarStyle:UIBarStyleBlack];
-    [[self.boundViewController expect] setTabBarVisible:NO animated:NO];
 
     [self.uut applyOptions:initialOptions];
     [self.boundViewController verify];

playground/ios/NavigationTests/RNNBasePresenterTest.m

@@ -84,4 +84,43 @@
 	XCTAssertTrue(_boundViewController.modalInPresentation);
 }
 
+- (void)testHidesBottomBarWhenPushed_showsBar {
+	_boundViewController.options.bottomTabs.visible = [[Bool alloc] initWithBOOL:NO];
+	XCTAssertTrue(_boundViewController.hidesBottomBarWhenPushed);
+}
+
+- (void)testHidesBottomBarWhenPushed_hidesBar {
+	_boundViewController.options.bottomTabs.visible = [[Bool alloc] initWithBOOL:YES];
+	XCTAssertFalse(_boundViewController.hidesBottomBarWhenPushed);
+}
+
+- (void)testHidesBottomBarWhenPushed_resolveParentShowsBar {
+	UINavigationController* nvc = [[UINavigationController alloc] initWithRootViewController:self.boundViewController];
+	nvc.options = [RNNNavigationOptions emptyOptions];
+	nvc.options.bottomTabs.visible = [[Bool alloc] initWithBOOL:NO];
+	XCTAssertTrue(_boundViewController.hidesBottomBarWhenPushed);
+}
+
+- (void)testHidesBottomBarWhenPushed_resolveParentHidesBar {
+	UINavigationController* nvc = [[UINavigationController alloc] initWithRootViewController:self.boundViewController];
+	nvc.options = [RNNNavigationOptions emptyOptions];
+	nvc.options.bottomTabs.visible = [[Bool alloc] initWithBOOL:YES];
+	XCTAssertFalse(_boundViewController.hidesBottomBarWhenPushed);
+}
+
+- (void)testHidesBottomBarWhenPushed_resolveChildShowsBarBeforeParent {
+	UINavigationController* nvc = [[UINavigationController alloc] initWithRootViewController:self.boundViewController];
+	nvc.options = [RNNNavigationOptions emptyOptions];
+	nvc.options.bottomTabs.visible = [[Bool alloc] initWithBOOL:NO];
+	XCTAssertTrue(_boundViewController.hidesBottomBarWhenPushed);
+}
+
+- (void)testHidesBottomBarWhenPushed_resolveChildHidesBarBeforeParent {
+	UINavigationController* nvc = [[UINavigationController alloc] initWithRootViewController:self.boundViewController];
+	nvc.options = [RNNNavigationOptions emptyOptions];
+	self.boundViewController.options.bottomTabs.visible = [[Bool alloc] initWithBOOL:NO];
+	nvc.options.bottomTabs.visible = [[Bool alloc] initWithBOOL:YES];
+	XCTAssertTrue(_boundViewController.hidesBottomBarWhenPushed);
+}
+
 @end

playground/ios/NavigationTests/RNNBottomTabsAppearancePresenterTest.m

@@ -36,7 +36,6 @@
     [[(id)self.uut expect] applyBackgroundColor:nil translucent:NO];
     [[self.boundViewController expect] setTabBarHideShadow:NO];
     [[self.boundViewController expect] setTabBarStyle:UIBarStyleDefault];
-    [[self.boundViewController expect] setTabBarVisible:YES animated:NO];
     [self.uut applyOptions:emptyOptions];
     [self.boundViewController verify];
 }
@@ -54,7 +53,6 @@
     [[(id)self.uut expect] applyBackgroundColor:nil translucent:[UIColor redColor]];
     [[self.boundViewController expect] setTabBarHideShadow:YES];
     [[self.boundViewController expect] setTabBarStyle:UIBarStyleBlack];
-    [[self.boundViewController expect] setTabBarVisible:NO animated:NO];
 
     [self.uut applyOptions:initialOptions];
     [self.boundViewController verify];