Hide topBar with animation by default (#2752)

* Hide topBar with animation by default

* fix unit tests

lib/android/app/src/main/java/com/reactnativenavigation/views/TopBar.java

@@ -33,7 +33,7 @@ public class TopBar extends AppBarLayout implements ScrollEventListener.ScrollAw
     private final Toolbar titleBar;
     private TitleBarButton.OnClickListener onClickListener;
     private final TopBarCollapseBehavior collapsingBehavior;
-    private final TopBarAnimator animator;
+    private TopBarAnimator animator;
     private TopTabs topTabs;
     private StackLayout parentView;
 
@@ -179,7 +179,7 @@ public class TopBar extends AppBarLayout implements ScrollEventListener.ScrollAw
         if (getVisibility() == View.VISIBLE) {
             return;
         }
-        if (animated.isTrue()) {
+        if (animated.isTrueOrUndefined()) {
             animator.show();
         } else {
             setVisibility(View.VISIBLE);
@@ -190,7 +190,7 @@ public class TopBar extends AppBarLayout implements ScrollEventListener.ScrollAw
         if (getVisibility() == View.GONE) {
             return;
         }
-        if (animated.isTrue()) {
+        if (animated.isTrueOrUndefined()) {
             animator.hide();
         } else {
             setVisibility(View.GONE);
@@ -213,12 +213,17 @@ public class TopBar extends AppBarLayout implements ScrollEventListener.ScrollAw
         titleBar.getMenu().clear();
     }
 
+    public void clearTopTabs() {
+        topTabs.clear(this);
+    }
+
     @VisibleForTesting()
     public TopTabs getTopTabs() {
         return topTabs;
     }
 
-    public void clearTopTabs() {
-        topTabs.clear(this);
+    @VisibleForTesting
+    public void setAnimator(TopBarAnimator animator) {
+        this.animator = animator;
     }
 }

lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/OptionsApplyingTest.java

@@ -147,6 +147,7 @@ public class OptionsApplyingTest extends BaseTest {
 
         Options opts = new Options();
         opts.topBarOptions.visible = new Bool(false);
+        opts.topBarOptions.animateHide = new Bool(false);
         uut.mergeOptions(opts);
 
         assertThat(stackController.getTopBar().getVisibility()).isEqualTo(View.GONE);

lib/android/app/src/test/java/com/reactnativenavigation/views/TopBarTest.java

@@ -1,18 +1,48 @@
 package com.reactnativenavigation.views;
 
-import com.reactnativenavigation.*;
+import com.reactnativenavigation.BaseTest;
+import com.reactnativenavigation.anim.TopBarAnimator;
+import com.reactnativenavigation.parse.params.Bool;
+import com.reactnativenavigation.parse.params.NullBool;
 
-import org.junit.*;
+import org.junit.Test;
 
-import static org.assertj.core.api.Java6Assertions.*;
+import static org.assertj.core.api.Java6Assertions.assertThat;
+import static org.mockito.Mockito.spy;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
 
 public class TopBarTest extends BaseTest {
+
+    private TopBar uut;
+    private TopBarAnimator animator;
+
+    @Override
+    public void beforeEach() {
+        StackLayout parent = new StackLayout(newActivity());
+        uut = new TopBar(newActivity(), buttonId -> {}, parent);
+        animator = spy(new TopBarAnimator(uut));
+        uut.setAnimator(animator);
+        parent.addView(uut);
+    }
+
     @Test
     public void title() throws Exception {
-        TopBar topBar = new TopBar(newActivity(), buttonId -> {}, null);
-        assertThat(topBar.getTitle()).isEmpty();
+        assertThat(uut.getTitle()).isEmpty();
+        uut.setTitle("new title");
+        assertThat(uut.getTitle()).isEqualTo("new title");
+    }
 
-        topBar.setTitle("new title");
-        assertThat(topBar.getTitle()).isEqualTo("new title");
+    @Test
+    public void hide_animateHideUnlessSpecifiedOtherwise() throws Exception {
+        uut.hide(new NullBool());
+        verify(animator, times(1)).hide();
+    }
+
+    @Test
+    public void show_animateShowUnlessSpecifiedOtherwise() throws Exception {
+        uut.hide(new Bool(false));
+        uut.show(new NullBool());
+        verify(animator, times(1)).show();
     }
 }