Browse Source

Update README

Guy Carmeli 8 years ago
parent
commit
386eeb0351
1 changed files with 5 additions and 3 deletions
  1. 5
    3
      README.md

+ 5
- 3
README.md View File

85
         ...
85
         ...
86
         />
86
         />
87
 	```
87
 	```
88
-5. Implement `isDebug` and `createAdditionalReactPackages`
88
+5. Implement `isDebug` and `createAdditionalReactPackages` methods
89
 
89
 
90
 	```java
90
 	```java
91
 	import com.reactnativenavigation.NavigationApplication;
91
 	import com.reactnativenavigation.NavigationApplication;
94
  
94
  
95
     	@Override
95
     	@Override
96
 		public boolean isDebug() {
96
 		public boolean isDebug() {
97
+			// Make sure you are using BuildConfig from your own application
97
 			return BuildConfig.DEBUG;
98
 			return BuildConfig.DEBUG;
98
 		}
99
 		}
99
 
100
 
108
 	```
109
 	```
109
 
110
 
110
 ## Migrating to version 2.0
111
 ## Migrating to version 2.0
111
-Migrating your code base to version 2.0 will require a few changes to your native Java code. The actual navigation API has not changes so there will be no changes to your JS code base.
112
+Migrating your code base to version 2.0 will require a few changes to your native Java code. The actual navigation API has not changed so there will be no changes to your JS code base.
112
 
113
 
113
 * Your `MainActivity` should now extend `com.reactnativenavigation.controllers.SplashActivity`
114
 * Your `MainActivity` should now extend `com.reactnativenavigation.controllers.SplashActivity`
114
-* Delete the `getPackages()` method if you've overridden it in `MainActivity`. Don't forget to delete unused imports after this step.
115
+* Delete the `getPackages()` from `MainActivity`. Don't forget to delete unused imports after this step.
115
 * Create a custom Application class and update the `Application` element in `AndroidManifest.xml`
116
 * Create a custom Application class and update the `Application` element in `AndroidManifest.xml`
116
 	
117
 	
117
 	```java
118
 	```java
137
  
138
  
138
     	@Override
139
     	@Override
139
 		public boolean isDebug() {
140
 		public boolean isDebug() {
141
+			// Make sure you are using BuildConfig from your own application
140
 			return BuildConfig.DEBUG;
142
 			return BuildConfig.DEBUG;
141
 		}
143
 		}
142
 
144