Browse Source

remove xcpretty as it hides build errors

Daniel Zlotin 7 years ago
parent
commit
4063abb4df
2 changed files with 4 additions and 18 deletions
  1. 2
    8
      scripts/test.e2e.ios.js
  2. 2
    10
      scripts/test.unit.ios.js

+ 2
- 8
scripts/test.e2e.ios.js View File

7
   const scheme = release ? `playground_release` : `playground`;
7
   const scheme = release ? `playground_release` : `playground`;
8
   const conf = release ? `Release` : `Debug`;
8
   const conf = release ? `Release` : `Debug`;
9
 
9
 
10
-  const cmd = `RCT_NO_LAUNCH_PACKAGER=true
10
+  exec.execSync(`RCT_NO_LAUNCH_PACKAGER=true
11
             cd ./playground/ios && xcodebuild
11
             cd ./playground/ios && xcodebuild
12
             build
12
             build
13
             -scheme ${scheme}
13
             -scheme ${scheme}
15
             -sdk iphonesimulator
15
             -sdk iphonesimulator
16
             -configuration ${conf}
16
             -configuration ${conf}
17
             -derivedDataPath ./DerivedData/playground
17
             -derivedDataPath ./DerivedData/playground
18
-            ONLY_ACTIVE_ARCH=YES`;
19
-
20
-  if (exec.which(`xcpretty`)) {
21
-    exec.execSync(`${cmd} | xcpretty && exit \${PIPESTATUS[0]}`);
22
-  } else {
23
-    exec.execSync(`${cmd}`);
24
-  }
18
+            ONLY_ACTIVE_ARCH=YES && echo $?`);
25
 }
19
 }
26
 
20
 
27
 function runDetoxUsingMocha() {
21
 function runDetoxUsingMocha() {

+ 2
- 10
scripts/test.unit.ios.js View File

3
 
3
 
4
 const release = _.includes(process.argv, 'release');
4
 const release = _.includes(process.argv, 'release');
5
 
5
 
6
-function runWithXcpretty(cmd) {
7
-  // if (exec.which(`xcpretty`)) {
8
-  //   exec.execSync(`${cmd} | xcpretty && exit \${PIPESTATUS[0]}`);
9
-  // } else {
10
-  exec.execSync(`${cmd}`);
11
-  // }
12
-}
13
-
14
 function run() {
6
 function run() {
15
   const conf = release ? `Release` : `Debug`;
7
   const conf = release ? `Release` : `Debug`;
16
-  runWithXcpretty(`RCT_NO_LAUNCH_PACKAGER=true
8
+  exec.execSync(`RCT_NO_LAUNCH_PACKAGER=true
17
           cd ./playground/ios && xcodebuild
9
           cd ./playground/ios && xcodebuild
18
             build build-for-testing
10
             build build-for-testing
19
             -scheme "ReactNativeNavigation"
11
             -scheme "ReactNativeNavigation"
22
             -configuration ${conf}
14
             -configuration ${conf}
23
             -derivedDataPath ./DerivedData/playground
15
             -derivedDataPath ./DerivedData/playground
24
             ONLY_ACTIVE_ARCH=YES && echo $?`);
16
             ONLY_ACTIVE_ARCH=YES && echo $?`);
25
-  runWithXcpretty(`RCT_NO_LAUNCH_PACKAGER=true
17
+  exec.execSync(`RCT_NO_LAUNCH_PACKAGER=true
26
           cd ./playground/ios && xcodebuild
18
           cd ./playground/ios && xcodebuild
27
             test-without-building
19
             test-without-building
28
             -scheme "ReactNativeNavigation"
20
             -scheme "ReactNativeNavigation"