Browse Source

keep renaming

Daniel Zlotin 7 years ago
parent
commit
42333a1be8

+ 2
- 2
e2e/ScreenStyle.test.js View File

8
     await device.relaunchApp();
8
     await device.relaunchApp();
9
   });
9
   });
10
 
10
 
11
-  it('declare a options on container component', async () => {
11
+  it('declare a options on component component', async () => {
12
     await elementById(testIDs.PUSH_OPTIONS_BUTTON).tap();
12
     await elementById(testIDs.PUSH_OPTIONS_BUTTON).tap();
13
     await expect(element(by.label('Static Title'))).toBeVisible();
13
     await expect(element(by.label('Static Title'))).toBeVisible();
14
   });
14
   });
15
 
15
 
16
-  it('change title on container component', async () => {
16
+  it('change title on component component', async () => {
17
     await elementById(testIDs.PUSH_OPTIONS_BUTTON).tap();
17
     await elementById(testIDs.PUSH_OPTIONS_BUTTON).tap();
18
     await expect(element(by.label('Static Title'))).toBeVisible();
18
     await expect(element(by.label('Static Title'))).toBeVisible();
19
     await elementById(testIDs.DYNAMIC_OPTIONS_BUTTON).tap();
19
     await elementById(testIDs.DYNAMIC_OPTIONS_BUTTON).tap();

+ 1
- 1
lib/src/Navigation.js View File

87
   /**
87
   /**
88
    * Push a new screen into this screen's navigation stack.
88
    * Push a new screen into this screen's navigation stack.
89
    * @param {string} componentId The component's id.
89
    * @param {string} componentId The component's id.
90
-   * @param {Container} component
90
+   * @param {Component} component
91
    */
91
    */
92
   push(componentId, component) {
92
   push(componentId, component) {
93
     return this.commands.push(componentId, component);
93
     return this.commands.push(componentId, component);

+ 1
- 1
playground/src/containers/CustomTransitionOrigin.js View File

51
     );
51
     );
52
   }
52
   }
53
   onClickNavigationIcon() {
53
   onClickNavigationIcon() {
54
-    Navigation.push(this.props.containerId, {
54
+    Navigation.push(this.props.componentId, {
55
       component: {
55
       component: {
56
         name: 'navigation.playground.CustomTransitionDestination',
56
         name: 'navigation.playground.CustomTransitionDestination',
57
         customTransition: {
57
         customTransition: {

+ 3
- 3
playground/src/containers/ModalScreen.js View File

38
         {this.getPreviousModalId() ? (<Button title="Dismiss Previous Modal" testID={testIDs.DISMISS_PREVIOUS_MODAL_BUTTON} onPress={this.onClickDismissPreviousModal} />) : undefined}
38
         {this.getPreviousModalId() ? (<Button title="Dismiss Previous Modal" testID={testIDs.DISMISS_PREVIOUS_MODAL_BUTTON} onPress={this.onClickDismissPreviousModal} />) : undefined}
39
         {this.props.previousModalIds ? (<Button title="Dismiss ALL Previous Modals" testID={testIDs.DISMISS_ALL_PREVIOUS_MODAL_BUTTON} onPress={this.onClickDismissAllPreviousModals} />) : undefined}
39
         {this.props.previousModalIds ? (<Button title="Dismiss ALL Previous Modals" testID={testIDs.DISMISS_ALL_PREVIOUS_MODAL_BUTTON} onPress={this.onClickDismissAllPreviousModals} />) : undefined}
40
         {this.props.previousModalIds ? (<Button title="Dismiss First In Stack" testID={testIDs.DISMISS_FIRST_MODAL_BUTTON} onPress={this.onClickDismissFirstInStack} />) : undefined}
40
         {this.props.previousModalIds ? (<Button title="Dismiss First In Stack" testID={testIDs.DISMISS_FIRST_MODAL_BUTTON} onPress={this.onClickDismissFirstInStack} />) : undefined}
41
-        <Text style={styles.footer}>{`this.props.containerId = ${this.props.containerId}`}</Text>
41
+        <Text style={styles.footer}>{`this.props.componentId = ${this.props.componentId}`}</Text>
42
       </View>
42
       </View>
43
     );
43
     );
44
   }
44
   }
49
         name: 'navigation.playground.ModalScreen',
49
         name: 'navigation.playground.ModalScreen',
50
         passProps: {
50
         passProps: {
51
           modalPosition: this.getModalPosition() + 1,
51
           modalPosition: this.getModalPosition() + 1,
52
-          previousModalIds: _.concat([], this.props.previousModalIds || [], this.props.containerId)
52
+          previousModalIds: _.concat([], this.props.previousModalIds || [], this.props.componentId)
53
         }
53
         }
54
       }
54
       }
55
     });
55
     });
56
   }
56
   }
57
 
57
 
58
   async onClickDismissModal() {
58
   async onClickDismissModal() {
59
-    await Navigation.dismissModal(this.props.containerId);
59
+    await Navigation.dismissModal(this.props.componentId);
60
   }
60
   }
61
 
61
 
62
   onClickDismissPreviousModal() {
62
   onClickDismissPreviousModal() {