upgrade example e2e tests to detox 5 + RN 44.2 (#1337)

example/e2e/init.js

-/*eslint-disable*/
-const detox = require('detox');
-const config = require('../package.json').detox;
-
-before(function(done) {
-  this.timeout(120000);
-  detox.config(config);
-  detox.start(done);
-});
-
-afterEach(function(done) {
-  detox.waitForTestResult(done);
-});
-
-after(function(done) {
-  detox.cleanup(done);
-});

example/e2e/mocha.opts

---recursive
---timeout 120000

example/e2e/sanity.test.js

-describe('sanity', function() {
-  beforeEach(function(done) {
-    global.simulator.reloadReactNativeApp(done);
-  });
-
-  it('should have screen one showing', function() {
-    expect(element(by.label('Screen One'))).toBeVisible();
-  });
-});

example/ios/example.xcodeproj/project.pbxproj

 			isa = PBXGroup;
 			children = (
 				7B9B39631DEB4076004A6281 /* libRCTAnimation.a */,
-				7B9B39651DEB4076004A6281 /* libRCTAnimation-tvOS.a */,
+				7B9B39651DEB4076004A6281 /* libRCTAnimation.a */,
 			);
 			name = Products;
 			sourceTree = "<group>";
 				13B07F8C1A680F5B00A75B9A /* Frameworks */,
 				13B07F8E1A680F5B00A75B9A /* Resources */,
 				00DD1BFF1BD5951E006B06BC /* Bundle React Native code and images */,
-				6956ED03EAA1831C238A5BB4 /* Copy Detox Framework */,
 			);
 			buildRules = (
 			);
 			remoteRef = 7B9B39621DEB4076004A6281 /* PBXContainerItemProxy */;
 			sourceTree = BUILT_PRODUCTS_DIR;
 		};
-		7B9B39651DEB4076004A6281 /* libRCTAnimation-tvOS.a */ = {
+		7B9B39651DEB4076004A6281 /* libRCTAnimation.a */ = {
 			isa = PBXReferenceProxy;
 			fileType = archive.ar;
-			path = "libRCTAnimation-tvOS.a";
+			path = libRCTAnimation.a;
 			remoteRef = 7B9B39641DEB4076004A6281 /* PBXContainerItemProxy */;
 			sourceTree = BUILT_PRODUCTS_DIR;
 		};
 			shellPath = /bin/sh;
 			shellScript = "export NODE_BINARY=node\n../node_modules/react-native/packager/react-native-xcode.sh";
 		};
-		6956ED03EAA1831C238A5BB4 /* Copy Detox Framework */ = {
-			isa = PBXShellScriptBuildPhase;
-			buildActionMask = 2147483647;
-			files = (
-			);
-			inputPaths = (
-			);
-			name = "Copy Detox Framework";
-			outputPaths = (
-			);
-			runOnlyForDeploymentPostprocessing = 0;
-			shellPath = /bin/bash;
-			shellScript = "if [ -n \"$DEPLOY_DETOX_FRAMEWORK\" ]; then\nmkdir -p \"${BUILT_PRODUCTS_DIR}\"/\"${FRAMEWORKS_FOLDER_PATH}\"\ncp -r \"${PROJECT_DIR}\"/../node_modules/detox/Detox.framework \"${BUILT_PRODUCTS_DIR}\"/\"${FRAMEWORKS_FOLDER_PATH}\"\nfi";
-		};
 /* End PBXShellScriptBuildPhase section */
 
 /* Begin PBXSourcesBuildPhase section */
 			};
 			name = Release;
 		};
-		2C24A1398D388E120DDC2CA1 /* Debug_Detox */ = {
-			isa = XCBuildConfiguration;
-			buildSettings = {
-				ALWAYS_SEARCH_USER_PATHS = NO;
-				CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
-				CLANG_CXX_LIBRARY = "libc++";
-				CLANG_ENABLE_MODULES = YES;
-				CLANG_ENABLE_OBJC_ARC = YES;
-				CLANG_WARN_BOOL_CONVERSION = YES;
-				CLANG_WARN_CONSTANT_CONVERSION = YES;
-				CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
-				CLANG_WARN_EMPTY_BODY = YES;
-				CLANG_WARN_ENUM_CONVERSION = YES;
-				CLANG_WARN_INT_CONVERSION = YES;
-				CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
-				CLANG_WARN_UNREACHABLE_CODE = YES;
-				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
-				"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
-				COPY_PHASE_STRIP = NO;
-				ENABLE_STRICT_OBJC_MSGSEND = YES;
-				GCC_C_LANGUAGE_STANDARD = gnu99;
-				GCC_DYNAMIC_NO_PIC = NO;
-				GCC_OPTIMIZATION_LEVEL = 0;
-				GCC_PREPROCESSOR_DEFINITIONS = (
-					"DEBUG=1",
-					"$(inherited)",
-				);
-				GCC_SYMBOLS_PRIVATE_EXTERN = NO;
-				GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
-				GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
-				GCC_WARN_UNDECLARED_SELECTOR = YES;
-				GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
-				GCC_WARN_UNUSED_FUNCTION = YES;
-				GCC_WARN_UNUSED_VARIABLE = YES;
-				IPHONEOS_DEPLOYMENT_TARGET = 8.0;
-				MTL_ENABLE_DEBUG_INFO = YES;
-				ONLY_ACTIVE_ARCH = YES;
-				OTHER_LDFLAGS = "";
-				SDKROOT = iphoneos;
-			};
-			name = Debug_Detox;
-		};
-		5627D4C51CEC610E1744267F /* Debug_Detox */ = {
-			isa = XCBuildConfiguration;
-			buildSettings = {
-				BUNDLE_LOADER = "$(TEST_HOST)";
-				FRAMEWORK_SEARCH_PATHS = (
-					"$(SDKROOT)/Developer/Library/Frameworks",
-					"$(inherited)",
-				);
-				GCC_PREPROCESSOR_DEFINITIONS = (
-					"DEBUG=1",
-					"$(inherited)",
-				);
-				INFOPLIST_FILE = exampleTests/Info.plist;
-				IPHONEOS_DEPLOYMENT_TARGET = 8.2;
-				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
-				PRODUCT_NAME = "$(TARGET_NAME)";
-				TEST_HOST = "$(BUILT_PRODUCTS_DIR)/example.app/example";
-			};
-			name = Debug_Detox;
-		};
 		83CBBA201A601CBA00E9B192 /* Debug */ = {
 			isa = XCBuildConfiguration;
 			buildSettings = {
 			};
 			name = Release;
 		};
-		96FA810D67E56FD9D43906E6 /* Release_Detox */ = {
-			isa = XCBuildConfiguration;
-			buildSettings = {
-				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
-				DEPLOY_DETOX_FRAMEWORK = YES;
-				FRAMEWORK_SEARCH_PATHS = (
-					"$(inherited)",
-					"$(PROJECT_DIR)/../node_modules/detox",
-				);
-				HEADER_SEARCH_PATHS = (
-					"$(inherited)",
-					"$(SRCROOT)/../node_modules/react-native-navigation/ios/**",
-				);
-				INFOPLIST_FILE = example/Info.plist;
-				IPHONEOS_DEPLOYMENT_TARGET = 8.0;
-				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
-				OTHER_LDFLAGS = (
-					"-ObjC",
-					"-l\"c++\"",
-					"-framework",
-					Detox,
-				);
-				PRODUCT_NAME = example;
-			};
-			name = Release_Detox;
-		};
-		BEB8EFA9FD7A9DCE32773C1C /* Debug_Detox */ = {
-			isa = XCBuildConfiguration;
-			buildSettings = {
-				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
-				DEAD_CODE_STRIPPING = NO;
-				DEPLOY_DETOX_FRAMEWORK = YES;
-				FRAMEWORK_SEARCH_PATHS = (
-					"$(inherited)",
-					"$(PROJECT_DIR)/../node_modules/detox",
-				);
-				HEADER_SEARCH_PATHS = (
-					"$(inherited)",
-					"$(SRCROOT)/../node_modules/react-native-navigation/ios/**",
-				);
-				INFOPLIST_FILE = example/Info.plist;
-				IPHONEOS_DEPLOYMENT_TARGET = 8.0;
-				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
-				OTHER_LDFLAGS = (
-					"-ObjC",
-					"-l\"c++\"",
-					"-framework",
-					Detox,
-				);
-				PRODUCT_NAME = example;
-			};
-			name = Debug_Detox;
-		};
-		E53E50BD43A56CF67FAAD3A5 /* Release_Detox */ = {
-			isa = XCBuildConfiguration;
-			buildSettings = {
-				BUNDLE_LOADER = "$(TEST_HOST)";
-				COPY_PHASE_STRIP = NO;
-				FRAMEWORK_SEARCH_PATHS = (
-					"$(SDKROOT)/Developer/Library/Frameworks",
-					"$(inherited)",
-				);
-				INFOPLIST_FILE = exampleTests/Info.plist;
-				IPHONEOS_DEPLOYMENT_TARGET = 8.2;
-				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
-				PRODUCT_NAME = "$(TARGET_NAME)";
-				TEST_HOST = "$(BUILT_PRODUCTS_DIR)/example.app/example";
-			};
-			name = Release_Detox;
-		};
-		EAA4DC359BE7739594666868 /* Release_Detox */ = {
-			isa = XCBuildConfiguration;
-			buildSettings = {
-				ALWAYS_SEARCH_USER_PATHS = NO;
-				CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
-				CLANG_CXX_LIBRARY = "libc++";
-				CLANG_ENABLE_MODULES = YES;
-				CLANG_ENABLE_OBJC_ARC = YES;
-				CLANG_WARN_BOOL_CONVERSION = YES;
-				CLANG_WARN_CONSTANT_CONVERSION = YES;
-				CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
-				CLANG_WARN_EMPTY_BODY = YES;
-				CLANG_WARN_ENUM_CONVERSION = YES;
-				CLANG_WARN_INT_CONVERSION = YES;
-				CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
-				CLANG_WARN_UNREACHABLE_CODE = YES;
-				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
-				"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
-				COPY_PHASE_STRIP = YES;
-				ENABLE_NS_ASSERTIONS = NO;
-				ENABLE_STRICT_OBJC_MSGSEND = YES;
-				GCC_C_LANGUAGE_STANDARD = gnu99;
-				GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
-				GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
-				GCC_WARN_UNDECLARED_SELECTOR = YES;
-				GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
-				GCC_WARN_UNUSED_FUNCTION = YES;
-				GCC_WARN_UNUSED_VARIABLE = YES;
-				IPHONEOS_DEPLOYMENT_TARGET = 8.0;
-				MTL_ENABLE_DEBUG_INFO = NO;
-				OTHER_LDFLAGS = "";
-				SDKROOT = iphoneos;
-				VALIDATE_PRODUCT = YES;
-			};
-			name = Release_Detox;
-		};
 /* End XCBuildConfiguration section */
 
 /* Begin XCConfigurationList section */
 			buildConfigurations = (
 				00E356F61AD99517003FC87E /* Debug */,
 				00E356F71AD99517003FC87E /* Release */,
-				5627D4C51CEC610E1744267F /* Debug_Detox */,
-				E53E50BD43A56CF67FAAD3A5 /* Release_Detox */,
 			);
 			defaultConfigurationIsVisible = 0;
 			defaultConfigurationName = Release;
 			buildConfigurations = (
 				13B07F941A680F5B00A75B9A /* Debug */,
 				13B07F951A680F5B00A75B9A /* Release */,
-				BEB8EFA9FD7A9DCE32773C1C /* Debug_Detox */,
-				96FA810D67E56FD9D43906E6 /* Release_Detox */,
 			);
 			defaultConfigurationIsVisible = 0;
 			defaultConfigurationName = Release;
 			buildConfigurations = (
 				83CBBA201A601CBA00E9B192 /* Debug */,
 				83CBBA211A601CBA00E9B192 /* Release */,
-				2C24A1398D388E120DDC2CA1 /* Debug_Detox */,
-				EAA4DC359BE7739594666868 /* Release_Detox */,
 			);
 			defaultConfigurationIsVisible = 0;
 			defaultConfigurationName = Release;

example/ios/example.xcodeproj/xcshareddata/xcschemes/example_Detox.xcscheme

-<?xml version="1.0" encoding="UTF-8"?>
-<Scheme
-   LastUpgradeVersion = "0620"
-   version = "1.3">
-   <BuildAction
-      parallelizeBuildables = "NO"
-      buildImplicitDependencies = "YES">
-      <BuildActionEntries>
-         <BuildActionEntry
-            buildForTesting = "YES"
-            buildForRunning = "YES"
-            buildForProfiling = "YES"
-            buildForArchiving = "YES"
-            buildForAnalyzing = "YES">
-            <BuildableReference
-               BuildableIdentifier = "primary"
-               BlueprintIdentifier = "83CBBA2D1A601D0E00E9B192"
-               BuildableName = "libReact.a"
-               BlueprintName = "React"
-               ReferencedContainer = "container:../node_modules/react-native/React/React.xcodeproj">
-            </BuildableReference>
-         </BuildActionEntry>
-         <BuildActionEntry
-            buildForTesting = "YES"
-            buildForRunning = "YES"
-            buildForProfiling = "YES"
-            buildForArchiving = "YES"
-            buildForAnalyzing = "YES">
-            <BuildableReference
-               BuildableIdentifier = "primary"
-               BlueprintIdentifier = "13B07F861A680F5B00A75B9A"
-               BuildableName = "example.app"
-               BlueprintName = "example"
-               ReferencedContainer = "container:example.xcodeproj">
-            </BuildableReference>
-         </BuildActionEntry>
-         <BuildActionEntry
-            buildForTesting = "YES"
-            buildForRunning = "YES"
-            buildForProfiling = "NO"
-            buildForArchiving = "NO"
-            buildForAnalyzing = "YES">
-            <BuildableReference
-               BuildableIdentifier = "primary"
-               BlueprintIdentifier = "00E356ED1AD99517003FC87E"
-               BuildableName = "exampleTests.xctest"
-               BlueprintName = "exampleTests"
-               ReferencedContainer = "container:example.xcodeproj">
-            </BuildableReference>
-         </BuildActionEntry>
-      </BuildActionEntries>
-   </BuildAction>
-   <TestAction
-      buildConfiguration = "Debug"
-      selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
-      selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
-      shouldUseLaunchSchemeArgsEnv = "YES">
-      <Testables>
-         <TestableReference
-            skipped = "NO">
-            <BuildableReference
-               BuildableIdentifier = "primary"
-               BlueprintIdentifier = "00E356ED1AD99517003FC87E"
-               BuildableName = "exampleTests.xctest"
-               BlueprintName = "exampleTests"
-               ReferencedContainer = "container:example.xcodeproj">
-            </BuildableReference>
-         </TestableReference>
-      </Testables>
-      <MacroExpansion>
-         <BuildableReference
-            BuildableIdentifier = "primary"
-            BlueprintIdentifier = "13B07F861A680F5B00A75B9A"
-            BuildableName = "example.app"
-            BlueprintName = "example"
-            ReferencedContainer = "container:example.xcodeproj">
-         </BuildableReference>
-      </MacroExpansion>
-      <AdditionalOptions>
-      </AdditionalOptions>
-   </TestAction>
-   <LaunchAction
-      buildConfiguration = "Debug_Detox"
-      selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
-      selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
-      launchStyle = "0"
-      useCustomWorkingDirectory = "NO"
-      ignoresPersistentStateOnLaunch = "NO"
-      debugDocumentVersioning = "YES"
-      debugServiceExtension = "internal"
-      allowLocationSimulation = "YES">
-      <BuildableProductRunnable
-         runnableDebuggingMode = "0">
-         <BuildableReference
-            BuildableIdentifier = "primary"
-            BlueprintIdentifier = "13B07F861A680F5B00A75B9A"
-            BuildableName = "example.app"
-            BlueprintName = "example"
-            ReferencedContainer = "container:example.xcodeproj">
-         </BuildableReference>
-      </BuildableProductRunnable>
-      <AdditionalOptions>
-      </AdditionalOptions>
-   </LaunchAction>
-   <ProfileAction
-      buildConfiguration = "Release"
-      shouldUseLaunchSchemeArgsEnv = "YES"
-      savedToolIdentifier = ""
-      useCustomWorkingDirectory = "NO"
-      debugDocumentVersioning = "YES">
-      <BuildableProductRunnable
-         runnableDebuggingMode = "0">
-         <BuildableReference
-            BuildableIdentifier = "primary"
-            BlueprintIdentifier = "13B07F861A680F5B00A75B9A"
-            BuildableName = "example.app"
-            BlueprintName = "example"
-            ReferencedContainer = "container:example.xcodeproj">
-         </BuildableReference>
-      </BuildableProductRunnable>
-   </ProfileAction>
-   <AnalyzeAction
-      buildConfiguration = "Debug">
-   </AnalyzeAction>
-   <ArchiveAction
-      buildConfiguration = "Release"
-      revealArchiveInOrganizer = "YES">
-   </ArchiveAction>
-</Scheme>

example/package.json

     "start": "watchman watch-del-all && (adb reverse tcp:8081 tcp:8081 || true) && node node_modules/react-native/local-cli/cli.js start --reset-cache",
     "xcode": "open ios/example.xcodeproj",
     "android": "cd android && ./gradlew installDebug",
-    "e2e": "node ./scripts/e2e.ios.js"
+    "e2e": "detox test --configuration ios.sim.debug",
+    "e2e-release": "detox test --configuration ios.sim.release"
   },
   "dependencies": {
     "react": "16.0.0-alpha.6",
-    "react-native": "0.43.3",
+    "react-native": "0.44.2",
     "react-native-animatable": "^1.1.0",
     "react-native-navigation": "latest"
   },
   "devDependencies": {
-    "detox": "4.x.x",
-    "detox-server": "1.x.x"
+    "detox": "^5.0.0",
+    "mocha": "^3.4.2"
   },
   "detox": {
-    "session": {
-      "server": "ws://localhost:8099",
-      "sessionId": "example"
-    },
-    "ios-simulator": {
-      "app": "ios/DerivedData/example/Build/Products/Debug_Detox-iphonesimulator/example.app",
-      "device": "iPhone 7, iOS 10.1"
+    "specs": "test/e2e",
+    "configurations": {
+      "ios.sim.debug": {
+        "binaryPath": "ios/DerivedData/example/Build/Products/Debug-iphonesimulator/example.app",
+        "type": "ios.simulator",
+        "name": "iPhone 6s"
+      },
+      "ios.sim.release": {
+        "binaryPath": "ios/DerivedData/example/Build/Products/Release-iphonesimulator/example.app",
+        "type": "ios.simulator",
+        "name": "iPhone 6s"
+      }
     }
   }
 }

example/scripts/e2e.ios.js

-const cp = require('child_process');
-
-function exec(cmd) {
-  cp.execSync(cmd, {stdio: ['inherit', 'inherit', 'inherit']});
-}
-
-function execSilent(cmd) {
-  cp.execSync(cmd, {stdio: ['inherit', 'ignore', 'inherit']});
-}
-
-function kill(process) {
-  execSilent(`pkill -f "${process}" || true`);
-}
-
-function buildXcodeReleaseProj() {
-//exec(`RCT_NO_LAUNCH_PACKAGER=true cd ios && xcodebuild \
-//-scheme example_Detox clean build \
-//-project example.xcodeproj \
-//-destination "platform=iOS Simulator,name=iPhone 7,OS=10.1" \
-//-derivedDataPath ./DerivedData/example`);
-}
-
-function e2e() {
-  kill(`detox-server`);
-
-  try {
-    cp.exec(`./node_modules/.bin/detox-server > ./detox-server.log 2>&1`);
-    exec(`BABEL_ENV=test ./node_modules/mocha/bin/mocha e2e --opts ./e2e/mocha.opts`);
-  } finally {
-    kill(`detox-server`);
-    kill(`Simulator`);
-    kill(`CoreSimulator`);
-    exec(`cat ./detox-server.log`);
-    exec(`sleep 5`);
-  }
-}
-
-function run() {
-  buildXcodeReleaseProj();
-  e2e();
-}
-
-run();
-

example/src/components/Row.js

 import React, { PropTypes } from 'react';
 import { StyleSheet, View, Text, TouchableHighlight, Platform } from 'react-native';
 
-function Row({ title, onPress, platform }) {
+function Row({ title, onPress, platform, testID }) {
     if (platform && platform !== Platform.OS) {
         return <View />;
     }
     return (
         <TouchableHighlight
             onPress={onPress}
+            testID={testID}
             underlayColor={'rgba(0, 0, 0, 0.054)'}
         >
             <View style={styles.row}>

example/src/screens/Types.js

         return (
             <ScrollView style={styles.container}>
                 <Row title={'Toggle Drawer'} onPress={this.toggleDrawer} />
-                <Row title={'Push Screen'} onPress={this.pushScreen} />
+                <Row title={'Push Screen'} testID={'pushScreen'} onPress={this.pushScreen} />
                 <Row title={'Top Tabs Screen'} onPress={this.pushTopTabsScreen} platform={'android'} />
                 <Row title={'Show Modal'} onPress={this.showModal} />
                 <Row title={'Show Lightbox'} onPress={this.showLightBox} />

example/src/screens/types/Push.js

     render() {
         return (
             <View style={styles.container}>
-                <Text>Push Screen</Text>
+                <Text>Pushed Screen</Text>
             </View>
         );
     }

example/test/e2e/init.js

+/*eslint-disable*/
+const detox = require('detox');
+const config = require('../../package.json').detox;
+
+before(async () => {
+  await detox.init(config);
+});
+
+after(async () => {
+  await detox.cleanup();
+});
+
+

example/test/e2e/mocha.opts

+--recursive
+--timeout 60000
+--require babel-polyfill
+--compilers js:babel-core/register

example/test/e2e/sanity.test.js

+describe('sanity', () => {
+
+  beforeEach(async () => await global.device.reloadReactNative());
+
+  it('should push a screen', async () => {
+    await element(by.id('pushScreen')).tap();
+
+    await expect(element(by.label('Pushed Screen'))).toBeVisible();
+  });
+
+});