Fix bottomTabs visibility (#6230)

* Fix setting root with bottomTabs.visible false
* Fix bottomTabs invisible after hiding through mergeOptions

on iOS, setting root with invisible bottomTabs doesn't work out of the box. We had to change the implementation and load the bottomTabsController children after it has been loaded to the window's rootViewController.

e2e/SetRoot.test.js

@@ -13,4 +13,18 @@ describe('SetRoot', () => {
     await elementById(TestIDs.SET_MULTIPLE_ROOTS_BTN).tap();
     await expect(elementById(TestIDs.PUSHED_SCREEN_HEADER)).toBeVisible();
   });
+
+  it('set root hides bottomTabs', async () => {
+    await elementById(TestIDs.SET_ROOT_HIDES_BOTTOM_TABS_BTN).tap();
+    await expect(elementById(TestIDs.LAYOUTS_TAB)).toBeNotVisible();
+    await elementById(TestIDs.PUSH_BTN).tap();
+    await expect(elementById(TestIDs.LAYOUTS_TAB)).toBeVisible();
+  });
+
+  it('set root with stack hides bottomTabs', async () => {
+    await elementById(TestIDs.SET_ROOT_WITH_STACK_HIDES_BOTTOM_TABS_BTN).tap();
+    await expect(elementById(TestIDs.LAYOUTS_TAB)).toBeNotVisible();
+    await elementById(TestIDs.POP_BTN).tap();
+    await expect(elementById(TestIDs.LAYOUTS_TAB)).toBeVisible();
+  });
 });

lib/ios/BottomTabsBasePresenter.m

@@ -17,6 +17,7 @@
     RNNNavigationOptions *withDefault = [options withDefault:[self defaultOptions]];
 
     [bottomTabs setTabBarTestID:[withDefault.bottomTabs.testID getWithDefaultValue:nil]];
+    ![withDefault.bottomTabs.visible getWithDefaultValue:YES] ?: [bottomTabs setTabBarVisible:[withDefault.bottomTabs.visible getWithDefaultValue:YES] animated:[withDefault.bottomTabs.animate getWithDefaultValue:NO]];
     
     [bottomTabs.view setBackgroundColor:[withDefault.layout.backgroundColor getWithDefaultValue:nil]];
     [self applyBackgroundColor:[withDefault.bottomTabs.backgroundColor getWithDefaultValue:nil] translucent:[withDefault.bottomTabs.translucent getWithDefaultValue:NO]];

lib/ios/BottomTabsTogetherAttacher.m

@@ -1,9 +1,10 @@
 #import "BottomTabsTogetherAttacher.h"
+#import "RNNBottomTabsController.h"
 
 @implementation BottomTabsTogetherAttacher
 
-- (void)attach:(UITabBarController *)bottomTabsController {
-    for (UIViewController* childViewController in bottomTabsController.childViewControllers) {
+- (void)attach:(RNNBottomTabsController *)bottomTabsController {
+    for (UIViewController* childViewController in bottomTabsController.pendingChildViewControllers) {
         [childViewController render];
     }
     

lib/ios/RNNBottomTabsController.h

@@ -21,4 +21,6 @@
 
 - (void)setSelectedIndexByComponentID:(NSString *)componentID;
 
+@property (nonatomic, strong) NSArray* pendingChildViewControllers;
+
 @end

lib/ios/RNNBottomTabsController.m

@@ -4,6 +4,7 @@
 @interface RNNBottomTabsController ()
 @property (nonatomic, strong) BottomTabPresenter* bottomTabPresenter;
 @property (nonatomic, strong) RNNDotIndicatorPresenter* dotIndicatorPresenter;
+@property (nonatomic) BOOL viewWillAppearOnce;
 @end
 
 @implementation RNNBottomTabsController {
@@ -25,6 +26,7 @@
     _bottomTabsAttacher = bottomTabsAttacher;
     _bottomTabPresenter = bottomTabPresenter;
     _dotIndicatorPresenter = dotIndicatorPresenter;
+    _pendingChildViewControllers = childViewControllers;
     self = [super initWithLayoutInfo:layoutInfo creator:creator options:options defaultOptions:defaultOptions presenter:presenter eventEmitter:eventEmitter childViewControllers:childViewControllers];
     if (@available(iOS 13.0, *)) {
         self.tabBar.standardAppearance = [UITabBarAppearance new];
@@ -32,6 +34,12 @@
     return self;
 }
 
+- (void)viewWillAppear:(BOOL)animated {
+    [super viewWillAppear:animated];
+    _viewWillAppearOnce = YES;
+    [self loadChildren:self.pendingChildViewControllers];
+}
+
 - (void)onChildAddToParent:(UIViewController *)child options:(RNNNavigationOptions *)options {
     [_bottomTabPresenter applyOptionsOnWillMoveToParentViewController:options child:child];
 }
@@ -73,11 +81,14 @@
 }
 
 - (void)setSelectedIndexByComponentID:(NSString *)componentID {
-	for (id child in self.childViewControllers) {
+    NSArray* children = self.pendingChildViewControllers ?: self.childViewControllers;
+	for (id child in children) {
 		UIViewController<RNNLayoutProtocol>* vc = child;
 
 		if ([vc conformsToProtocol:@protocol(RNNLayoutProtocol)] && [vc.layoutInfo.componentId isEqualToString:componentID]) {
-			[self setSelectedIndex:[self.childViewControllers indexOfObject:child]];
+            NSUInteger selectedIndex = [children indexOfObject:child];
+			[self setSelectedIndex:selectedIndex];
+            _currentTabIndex = selectedIndex;
 		}
 	}
 }
@@ -87,6 +98,18 @@
 	[super setSelectedIndex:selectedIndex];
 }
 
+- (UIViewController *)selectedViewController {
+    NSArray* children = self.pendingChildViewControllers ?: self.childViewControllers;
+    return children.count ? children[_currentTabIndex] : nil;
+}
+
+- (void)loadChildren:(NSArray *)children {
+    if (self.viewWillAppearOnce) {
+        [super loadChildren:children];
+        self.pendingChildViewControllers = nil;
+    }
+}
+
 #pragma mark UITabBarControllerDelegate
 
 - (void)tabBarController:(UITabBarController *)tabBarController didSelectViewController:(UIViewController *)viewController {

lib/ios/RNNSplitViewController.m

@@ -10,7 +10,7 @@
 }
 
 - (UIViewController *)getCurrentChild {
-	return self.viewControllers[0];
+    return self.viewControllers[0];
 }
 
 # pragma mark - UIViewController overrides

lib/ios/UIViewController+LayoutProtocol.h

@@ -42,6 +42,8 @@ typedef void (^RNNReactViewReadyCompletionBlock)(void);
 
 - (void)screenPopped;
 
+- (void)loadChildren:(NSArray *)children;
+
 @property (nonatomic, retain) RNNBasePresenter* presenter;
 @property (nonatomic, retain) RNNLayoutInfo* layoutInfo;
 @property (nonatomic, strong) RNNNavigationOptions* options;
@@ -50,5 +52,6 @@ typedef void (^RNNReactViewReadyCompletionBlock)(void);
 @property (nonatomic) id<RNNComponentViewCreator> creator;
 @property (nonatomic) RNNReactViewReadyCompletionBlock reactViewReadyCallback;
 @property (nonatomic) BOOL waitForRender;
+@property (nonatomic) BOOL isChildViewControllersLoaded;
 
 @end

lib/ios/UIViewController+LayoutProtocol.m

@@ -12,7 +12,6 @@
 					  eventEmitter:(RNNEventEmitter *)eventEmitter
 			  childViewControllers:(NSArray *)childViewControllers {
 	self = [self init];
-	
 	self.options = options;
 	self.defaultOptions = defaultOptions;
 	self.layoutInfo = layoutInfo;
@@ -21,9 +20,7 @@
     self.presenter = presenter;
     [self.presenter bindViewController:self];
     self.extendedLayoutIncludesOpaqueBars = YES;
-    if ([self respondsToSelector:@selector(setViewControllers:)]) {
-        [self performSelector:@selector(setViewControllers:) withObject:childViewControllers];
-    }
+    [self loadChildren:childViewControllers];
     [self.presenter applyOptionsOnInit:self.resolveOptions];
 
 	return self;
@@ -74,6 +71,13 @@
     [self.getCurrentChild render];
 }
 
+- (void)loadChildren:(NSArray *)children {
+    if (!self.isChildViewControllersLoaded && [self respondsToSelector:@selector(setViewControllers:)]) {
+        self.isChildViewControllersLoaded = YES;
+        [self performSelector:@selector(setViewControllers:) withObject:children];
+    }
+}
+
 - (void)readyForPresentation {
     if (self.reactViewReadyCallback) {
         self.reactViewReadyCallback();
@@ -212,6 +216,14 @@
 	objc_setAssociatedObject(self, @selector(eventEmitter), eventEmitter, OBJC_ASSOCIATION_RETAIN_NONATOMIC);
 }
 
+- (BOOL)isChildViewControllersLoaded {
+    return [objc_getAssociatedObject(self, @selector(isChildViewControllersLoaded)) boolValue];
+}
+
+- (void)setIsChildViewControllersLoaded:(BOOL)isChildViewControllersLoaded {
+    objc_setAssociatedObject(self, @selector(isChildViewControllersLoaded), [NSNumber numberWithBool:isChildViewControllersLoaded], OBJC_ASSOCIATION_RETAIN_NONATOMIC);
+}
+
 - (id<RNNComponentViewCreator>)creator {
 	return objc_getAssociatedObject(self, @selector(creator));
 }

playground/ios/NavigationIOS12Tests/RNNBottomTabsPresenterTest.m

@@ -28,6 +28,7 @@
 	[[(id)self.uut expect] applyBackgroundColor:nil translucent:NO];
     [[self.boundViewController expect] setTabBarHideShadow:NO];
     [[self.boundViewController expect] setTabBarStyle:UIBarStyleDefault];
+	[[self.boundViewController expect] setTabBarVisible:YES animated:NO];
     [self.uut applyOptions:emptyOptions];
     [self.boundViewController verify];
 }
@@ -50,6 +51,16 @@
     [self.boundViewController verify];
 }
 
+- (void)testApplyOptions_shouldRestoreHiddenTabBar {
+    RNNNavigationOptions *initialOptions = [[RNNNavigationOptions alloc] initEmptyOptions];
+    initialOptions.bottomTabs.visible = [[Bool alloc] initWithValue:@(1)];
+	
+	[[self.boundViewController expect] setTabBarVisible:YES animated:NO];
+
+    [self.uut applyOptions:initialOptions];
+    [self.boundViewController verify];
+}
+
 - (void)testApplyOptionsOnInit_alwaysShow_shouldNotCenterTabImages {
 	RNNNavigationOptions *initialOptions = [[RNNNavigationOptions alloc] initEmptyOptions];
 	initialOptions.bottomTabs.titleDisplayMode = [[Text alloc] initWithValue:@"alwaysShow"];

playground/ios/NavigationIOS12Tests/RNNRootViewControllerTest.m

@@ -172,6 +172,7 @@
 	[self.uut setTabBarItem:item];
 	[controllers addObject:self.uut];
 	__unused RNNBottomTabsController* vc = [RNNBottomTabsController createWithChildren:controllers];
+	[vc viewWillAppear:NO];
 	[self.uut willMoveToParentViewController:vc];
 	XCTAssertTrue([self.uut.tabBarItem.badgeValue isEqualToString:tabBadgeInput]);
 
@@ -375,8 +376,8 @@
 	NSArray* supportedOrientations = @[@"portrait"];
 	self.options.layout.orientation = supportedOrientations;
 	NSMutableArray* controllers = [[NSMutableArray alloc] initWithArray:@[self.uut]];
-    __unused RNNBottomTabsController* vc = [[RNNBottomTabsController alloc] initWithLayoutInfo:nil creator:nil options:[[RNNNavigationOptions alloc] initEmptyOptions] defaultOptions:nil presenter:[RNNComponentPresenter new] eventEmitter:nil childViewControllers:controllers];
-
+    __unused RNNBottomTabsController* vc = [RNNBottomTabsController createWithChildren:controllers];
+	[vc viewWillAppear:NO];
 	[self.uut viewWillAppear:false];
 
 	UIInterfaceOrientationMask expectedOrientation = UIInterfaceOrientationMaskPortrait;
@@ -387,8 +388,8 @@
 	NSArray* supportedOrientations = @[@"portrait", @"landscape"];
 	self.options.layout.orientation = supportedOrientations;
     NSMutableArray* controllers = [[NSMutableArray alloc] initWithArray:@[self.uut]];
-    __unused RNNBottomTabsController* vc = [[RNNBottomTabsController alloc] initWithLayoutInfo:nil creator:nil options:[[RNNNavigationOptions alloc] initEmptyOptions] defaultOptions:nil presenter:[RNNComponentPresenter new] eventEmitter:nil childViewControllers:controllers];
-
+    __unused RNNBottomTabsController* vc = [RNNBottomTabsController createWithChildren:controllers];
+	[vc viewWillAppear:NO];
 	[self.uut viewWillAppear:false];
 
 	UIInterfaceOrientationMask expectedOrientation = (UIInterfaceOrientationMaskPortrait | UIInterfaceOrientationMaskLandscape);
@@ -399,8 +400,8 @@
 	NSArray* supportedOrientations = @[@"all"];
 	self.options.layout.orientation = supportedOrientations;
 	NSMutableArray* controllers = [[NSMutableArray alloc] initWithArray:@[self.uut]];
-	__unused RNNBottomTabsController* vc = [[RNNBottomTabsController alloc] initWithLayoutInfo:nil creator:nil options:[[RNNNavigationOptions alloc] initEmptyOptions] defaultOptions:nil presenter:[RNNComponentPresenter new] eventEmitter:nil childViewControllers:controllers];
-
+	__unused RNNBottomTabsController* vc = [RNNBottomTabsController createWithChildren:controllers];
+	[vc viewWillAppear:NO];
 	[self.uut viewWillAppear:false];
 
 	UIInterfaceOrientationMask expectedOrientation = UIInterfaceOrientationMaskAll;
@@ -560,7 +561,7 @@
 
 - (RNNStackController *)createNavigationController {
 	RNNStackController* nav = [[RNNStackController alloc] initWithLayoutInfo:nil creator:nil options:[[RNNNavigationOptions alloc] initEmptyOptions] defaultOptions:nil presenter:[[RNNStackPresenter alloc] init] eventEmitter:nil childViewControllers:@[self.uut]];
-	
+	[nav viewWillAppear:NO];
 	return nav;
 }
 

playground/ios/NavigationTests/BottomTabsControllerTest.m

@@ -42,7 +42,8 @@
     UIViewController *vc1 = [[UIViewController alloc] init];
     UIViewController *vc2 = [[UIViewController alloc] init];
 
-    RNNBottomTabsController *uut = [[RNNBottomTabsController alloc] initWithLayoutInfo:nil creator:nil options:[[RNNNavigationOptions alloc] initWithDict:@{}] defaultOptions:nil presenter:[[RNNComponentPresenter alloc] init] eventEmitter:nil childViewControllers:@[vc1, vc2]];
+	RNNBottomTabsController *uut = [RNNBottomTabsController createWithChildren:@[vc1, vc2]];
+	[uut viewWillAppear:YES];
     XCTAssertTrue(uut.viewControllers.count == 2);
 }
 
@@ -51,32 +52,19 @@
     RNNNavigationOptions *options = [[RNNNavigationOptions alloc] initWithDict:@{}];
     RNNBottomTabsPresenter *presenter = [[RNNBottomTabsPresenter alloc] init];
     NSArray *childViewControllers = @[[UIViewController new]];
-
-    RNNBottomTabsController *uut = [[RNNBottomTabsController alloc] initWithLayoutInfo:layoutInfo creator:nil options:options defaultOptions:nil presenter:presenter eventEmitter:nil childViewControllers:childViewControllers];
-    XCTAssertTrue(uut.layoutInfo == layoutInfo);
-    XCTAssertTrue(uut.options == options);
-    XCTAssertTrue(uut.presenter == presenter);
-    XCTAssertTrue(uut.childViewControllers.count == childViewControllers.count);
-}
-
-- (void)testInitWithEventEmmiter_shouldInitializeDependencies {
-    RNNLayoutInfo *layoutInfo = [RNNLayoutInfo new];
-    RNNNavigationOptions *options = [[RNNNavigationOptions alloc] initWithDict:@{}];
-    RNNBottomTabsPresenter *presenter = [[RNNBottomTabsPresenter alloc] init];
-    RNNEventEmitter *eventEmmiter = [RNNEventEmitter new];
-
-    NSArray *childViewControllers = @[[UIViewController new]];
-
-    RNNBottomTabsController *uut = [[RNNBottomTabsController alloc] initWithLayoutInfo:layoutInfo creator:nil options:options defaultOptions:nil presenter:presenter eventEmitter:eventEmmiter childViewControllers:childViewControllers];
+	RNNEventEmitter *eventEmmiter = [RNNEventEmitter new];
+	
+    RNNBottomTabsController *uut = [[RNNBottomTabsController alloc] initWithLayoutInfo:layoutInfo creator:nil options:options defaultOptions:nil presenter:presenter bottomTabPresenter:nil dotIndicatorPresenter:nil eventEmitter:eventEmmiter childViewControllers:childViewControllers bottomTabsAttacher:nil];
+	[uut viewWillAppear:YES];
     XCTAssertTrue(uut.layoutInfo == layoutInfo);
     XCTAssertTrue(uut.options == options);
     XCTAssertTrue(uut.presenter == presenter);
     XCTAssertTrue(uut.childViewControllers.count == childViewControllers.count);
-    XCTAssertTrue(uut.eventEmitter == eventEmmiter);
+	XCTAssertTrue(uut.eventEmitter == eventEmmiter);
 }
 
 - (void)testInitWithLayoutInfo_shouldSetDelegate {
-    RNNBottomTabsController *uut = [[RNNBottomTabsController alloc] initWithLayoutInfo:nil creator:nil options:[[RNNNavigationOptions alloc] initWithDict:@{}] defaultOptions:nil presenter:[[RNNBasePresenter alloc] init] eventEmitter:nil childViewControllers:nil];
+    RNNBottomTabsController *uut = [RNNBottomTabsController createWithChildren:@[]];
 
     XCTAssertTrue(uut.delegate == uut);
 }
@@ -179,7 +167,9 @@
 
     RNNComponentViewController *vc = [[RNNComponentViewController alloc] initWithLayoutInfo:layoutInfo rootViewCreator:nil eventEmitter:nil presenter:nil options:nil defaultOptions:nil];
 
-    RNNBottomTabsController *uut = [[RNNBottomTabsController alloc] initWithLayoutInfo:nil creator:nil options:nil defaultOptions:nil presenter:[RNNBottomTabsPresenter new] eventEmitter:nil childViewControllers:@[[UIViewController new], vc]];
+    RNNBottomTabsController *uut = [RNNBottomTabsController createWithChildren:@[[UIViewController new], vc]];
+	[uut viewWillAppear:YES];
+	
     [uut setSelectedIndexByComponentID:@"componentId"];
     XCTAssertTrue(uut.selectedIndex == 1);
 }
@@ -189,7 +179,8 @@
     options.bottomTabs.currentTabIndex = [[IntNumber alloc] initWithValue:@(1)];
 
     RNNComponentViewController *vc = [[RNNComponentViewController alloc] initWithLayoutInfo:nil rootViewCreator:nil eventEmitter:nil presenter:nil options:nil defaultOptions:nil];
-    RNNBottomTabsController *uut = [[RNNBottomTabsController alloc] initWithLayoutInfo:nil creator:nil options:options defaultOptions:nil presenter:[RNNBottomTabsPresenter new] eventEmitter:nil childViewControllers:@[[UIViewController new], vc]];
+	RNNBottomTabsController *uut = [RNNBottomTabsController createWithChildren:@[[UIViewController new], vc] options:options];
+	[uut viewWillAppear:YES];
 
     XCTAssertTrue(uut.selectedIndex == 1);
 }

playground/ios/NavigationTests/RNNBottomTabsAppearancePresenterTest.m

@@ -26,6 +26,7 @@
 	self.dotIndicatorPresenter = [OCMockObject partialMockForObject:[[RNNDotIndicatorPresenter alloc] initWithDefaultOptions:nil]];
     self.uut = [OCMockObject partialMockForObject:[BottomTabsPresenterCreator createWithDefaultOptions:nil]];
 	self.boundViewController = [OCMockObject partialMockForObject:[[RNNBottomTabsController alloc] initWithLayoutInfo:nil creator:nil options:nil defaultOptions:nil presenter:self.uut bottomTabPresenter:[BottomTabPresenterCreator createWithDefaultOptions:nil] dotIndicatorPresenter:self.dotIndicatorPresenter eventEmitter:nil childViewControllers:self.children bottomTabsAttacher:nil]];
+	[self.boundViewController viewWillAppear:YES];
     [self.uut bindViewController:self.boundViewController];
     self.options = [[RNNNavigationOptions alloc] initEmptyOptions];
 }
@@ -35,7 +36,8 @@
     [[self.boundViewController expect] setTabBarTestID:nil];
     [[(id)self.uut expect] applyBackgroundColor:nil translucent:NO];
     [[self.boundViewController expect] setTabBarHideShadow:NO];
-    [[self.boundViewController expect] setTabBarStyle:UIBarStyleDefault];
+    [[self.boundViewController expect] setTabBarVisible:YES animated:NO];
+	[[self.boundViewController expect] setTabBarStyle:UIBarStyleDefault];
     [self.uut applyOptions:emptyOptions];
     [self.boundViewController verify];
 }
@@ -58,6 +60,16 @@
     [self.boundViewController verify];
 }
 
+- (void)testApplyOptions_shouldRestoreHiddenTabBar {
+    RNNNavigationOptions *initialOptions = [[RNNNavigationOptions alloc] initEmptyOptions];
+    initialOptions.bottomTabs.visible = [[Bool alloc] initWithValue:@(1)];
+	
+	[[self.boundViewController expect] setTabBarVisible:YES animated:NO];
+
+    [self.uut applyOptions:initialOptions];
+    [self.boundViewController verify];
+}
+
 - (void)testApplyOptionsOnInit_alwaysShow_shouldNotCenterTabImages {
 	RNNNavigationOptions *initialOptions = [[RNNNavigationOptions alloc] initEmptyOptions];
 	initialOptions.bottomTabs.titleDisplayMode = [[Text alloc] initWithValue:@"alwaysShow"];

playground/ios/NavigationTests/RNNBottomTabsController+Helpers.h

@@ -7,4 +7,6 @@
 
 + (RNNBottomTabsController *)createWithChildren:(NSArray *)children;
 
++ (RNNBottomTabsController *)createWithChildren:(NSArray *)children options:(RNNNavigationOptions *)options;
+
 @end

playground/ios/NavigationTests/RNNBottomTabsController+Helpers.m

@@ -5,13 +5,16 @@
 @implementation RNNBottomTabsController (Helpers)
 
 + (RNNBottomTabsController *)create {
-	RNNNavigationOptions* defaultOptions = [[RNNNavigationOptions alloc] initEmptyOptions];
 	return [self createWithChildren:nil];
 }
 
 + (RNNBottomTabsController *)createWithChildren:(NSArray *)children {
+	return [self createWithChildren:children options:[[RNNNavigationOptions alloc] initEmptyOptions]];
+}
+
++ (RNNBottomTabsController *)createWithChildren:(NSArray *)children options:(RNNNavigationOptions *)options {
 	RNNNavigationOptions* defaultOptions = [[RNNNavigationOptions alloc] initEmptyOptions];
-	return [[RNNBottomTabsController alloc] initWithLayoutInfo:nil creator:nil options:[[RNNNavigationOptions alloc] initEmptyOptions] defaultOptions:defaultOptions presenter:[BottomTabsPresenterCreator createWithDefaultOptions:defaultOptions] bottomTabPresenter:[BottomTabPresenterCreator createWithDefaultOptions:defaultOptions] dotIndicatorPresenter:[[RNNDotIndicatorPresenter alloc] initWithDefaultOptions:defaultOptions] eventEmitter:nil childViewControllers:children bottomTabsAttacher:nil];
+	return [[RNNBottomTabsController alloc] initWithLayoutInfo:nil creator:nil options:options defaultOptions:defaultOptions presenter:[BottomTabsPresenterCreator createWithDefaultOptions:defaultOptions] bottomTabPresenter:[BottomTabPresenterCreator createWithDefaultOptions:defaultOptions] dotIndicatorPresenter:[[RNNDotIndicatorPresenter alloc] initWithDefaultOptions:defaultOptions] eventEmitter:nil childViewControllers:children bottomTabsAttacher:nil];
 }
 
 @end

playground/ios/NavigationTests/RNNCommandsHandlerTest.m

@@ -382,7 +382,7 @@
 	
 	BottomTabsBaseAttacher* attacher = [[[BottomTabsAttachModeFactory alloc] initWithDefaultOptions:nil] fromOptions:options];
 	RNNBottomTabsController* tabBarController = [[RNNBottomTabsController alloc] initWithLayoutInfo:nil creator:nil options:options defaultOptions:[[RNNNavigationOptions alloc] initEmptyOptions] presenter:[RNNBasePresenter new] bottomTabPresenter:nil dotIndicatorPresenter:nil eventEmitter:_eventEmmiter childViewControllers:@[_vc1, _vc2] bottomTabsAttacher:attacher];
-
+	[tabBarController viewWillAppear:YES];
 	OCMStub([self.controllerFactory createLayout:[OCMArg any]]).andReturn(tabBarController);
 	
 	[self.uut setRoot:@{} commandId:@"" completion:^{}];
@@ -400,7 +400,8 @@
 
 	BottomTabsBaseAttacher* attacher = [[[BottomTabsAttachModeFactory alloc] initWithDefaultOptions:nil] fromOptions:options];
 	RNNBottomTabsController* tabBarController = [[RNNBottomTabsController alloc] initWithLayoutInfo:nil creator:nil options:options defaultOptions:[[RNNNavigationOptions alloc] initEmptyOptions] presenter:[RNNBasePresenter new] bottomTabPresenter:nil dotIndicatorPresenter:nil eventEmitter:_eventEmmiter childViewControllers:@[_vc1, _vc2] bottomTabsAttacher:attacher];
-
+	[tabBarController viewWillAppear:YES];
+	
 	OCMStub([self.controllerFactory createLayout:[OCMArg any]]).andReturn(tabBarController);
 
 	[self.uut setRoot:@{} commandId:@"" completion:^{
@@ -424,6 +425,7 @@
 	RNNComponentViewController* secondChild = [RNNComponentViewController createWithComponentId:@"second" initialOptions:secondChildOptions];
 	
 	RNNBottomTabsController* tabBarController = [[RNNBottomTabsController alloc] initWithLayoutInfo:nil creator:nil options:[RNNNavigationOptions emptyOptions] defaultOptions:[[RNNNavigationOptions alloc] initEmptyOptions] presenter:[RNNBasePresenter new] bottomTabPresenter:[BottomTabPresenterCreator createWithDefaultOptions:[RNNNavigationOptions emptyOptions]] dotIndicatorPresenter:nil eventEmitter:_eventEmmiter childViewControllers:@[firstChild, secondChild] bottomTabsAttacher:nil];
+	[tabBarController viewWillAppear:YES];
 	
 	OCMStub([self.controllerFactory createLayout:[OCMArg any]]).andReturn(tabBarController);
 	[self.mainWindow setRootViewController:tabBarController];
@@ -455,6 +457,7 @@
 	RNNComponentViewController* secondChild = [RNNComponentViewController createWithComponentId:@"second" initialOptions:secondChildOptions];
 	
 	RNNBottomTabsController* tabBarController = [[RNNBottomTabsController alloc] initWithLayoutInfo:nil creator:nil options:[RNNNavigationOptions emptyOptions] defaultOptions:[[RNNNavigationOptions alloc] initEmptyOptions] presenter:[RNNBasePresenter new] bottomTabPresenter:[BottomTabPresenterCreator createWithDefaultOptions:[RNNNavigationOptions emptyOptions]] dotIndicatorPresenter:nil eventEmitter:_eventEmmiter childViewControllers:@[stack, secondChild] bottomTabsAttacher:nil];
+	[tabBarController viewWillAppear:YES];
 	
 	OCMStub([self.controllerFactory createLayout:[OCMArg any]]).andReturn(tabBarController);
 	[self.mainWindow setRootViewController:tabBarController];

playground/ios/NavigationTests/RNNControllerFactoryTest.m

@@ -115,7 +115,7 @@
 												 @"data": @{},
 												 @"children": @[]}]}]};
 	RNNBottomTabsController* tabBar = (RNNBottomTabsController*) [self.factory createLayout:layout];
-	
+	[tabBar viewWillAppear:YES];
 	XCTAssertTrue([tabBar isMemberOfClass:[RNNBottomTabsController class]]);
 	XCTAssertTrue(tabBar.childViewControllers.count == 1);
 	XCTAssertTrue([tabBar.childViewControllers[0] isMemberOfClass:[RNNStackController class]]);

playground/ios/NavigationTests/RNNRootViewControllerTest.m

@@ -182,6 +182,7 @@
 	NSMutableArray* controllers = [NSMutableArray new];
 	[controllers addObject:self.uut];
 	__unused RNNBottomTabsController* vc = [RNNBottomTabsController createWithChildren:controllers];
+	[vc viewWillAppear:NO];
 	[self.uut willMoveToParentViewController:vc];
 	XCTAssertTrue([self.uut.tabBarItem.badgeValue isEqualToString:tabBadgeInput]);
 
@@ -369,9 +370,8 @@
 	self.options.layout.orientation = supportedOrientations;
 	NSMutableArray* controllers = [[NSMutableArray alloc] initWithArray:@[self.uut]];
     __unused RNNBottomTabsController* vc = [RNNBottomTabsController createWithChildren:controllers];
-
-	[self.uut viewWillAppear:false];
-
+	[vc viewWillAppear:NO];
+	[self.uut viewWillAppear:NO];
 	UIInterfaceOrientationMask expectedOrientation = UIInterfaceOrientationMaskPortrait;
 	XCTAssertTrue(self.uut.tabBarController.supportedInterfaceOrientations == expectedOrientation);
 }
@@ -381,8 +381,8 @@
 	self.options.layout.orientation = supportedOrientations;
     NSMutableArray* controllers = [[NSMutableArray alloc] initWithArray:@[self.uut]];
     __unused RNNBottomTabsController* vc = [RNNBottomTabsController createWithChildren:controllers];
-
-	[self.uut viewWillAppear:false];
+	[vc viewWillAppear:NO];
+	[self.uut viewWillAppear:NO];
 
 	UIInterfaceOrientationMask expectedOrientation = (UIInterfaceOrientationMaskPortrait | UIInterfaceOrientationMaskLandscape);
 	XCTAssertTrue(self.uut.tabBarController.supportedInterfaceOrientations == expectedOrientation);
@@ -393,8 +393,8 @@
 	self.options.layout.orientation = supportedOrientations;
 	NSMutableArray* controllers = [[NSMutableArray alloc] initWithArray:@[self.uut]];
 	__unused RNNBottomTabsController* vc = [RNNBottomTabsController createWithChildren:controllers];
-
-	[self.uut viewWillAppear:false];
+	[vc viewWillAppear:NO];
+	[self.uut viewWillAppear:NO];
 
 	UIInterfaceOrientationMask expectedOrientation = UIInterfaceOrientationMaskAll;
 	XCTAssertTrue(self.uut.tabBarController.supportedInterfaceOrientations == expectedOrientation);
@@ -553,7 +553,7 @@
 
 - (RNNStackController *)createNavigationController {
 	RNNStackController* nav = [[RNNStackController alloc] initWithLayoutInfo:nil creator:nil options:[[RNNNavigationOptions alloc] initEmptyOptions] defaultOptions:nil presenter:[[RNNStackPresenter alloc] init] eventEmitter:nil childViewControllers:@[self.uut]];
-	
+
 	return nav;
 }
 

playground/ios/NavigationTests/UIViewController+LayoutProtocolTest.m

@@ -37,6 +37,24 @@
 	NSArray* childViewControllers = @[child1, child2];
 	UINavigationController* uut = [[UINavigationController alloc] initWithLayoutInfo:nil creator:nil options:nil defaultOptions:nil presenter:nil eventEmitter:nil childViewControllers:childViewControllers];
 	
+	XCTAssertEqual(uut.viewControllers.count, 2);
+}
+
+- (void)testInitBottomTabsWithLayoutInfoShouldNotSetChildViewControllers {
+	UIViewController* child1 = [UIViewController new];
+	UIViewController* child2 = [UIViewController new];
+	NSArray* childViewControllers = @[child1, child2];
+	RNNBottomTabsController* uut = [[RNNBottomTabsController alloc] initWithLayoutInfo:nil creator:nil options:nil defaultOptions:nil presenter:nil eventEmitter:nil childViewControllers:childViewControllers];
+	
+	XCTAssertEqual(uut.viewControllers.count, 0);
+}
+
+- (void)testLoadChildrenShouldSetChildViewControllers {
+	UIViewController* child1 = [UIViewController new];
+	UIViewController* child2 = [UIViewController new];
+	NSArray* childViewControllers = @[child1, child2];
+	UINavigationController* uut = [[UINavigationController alloc] initWithLayoutInfo:nil creator:nil options:nil defaultOptions:nil presenter:nil eventEmitter:nil childViewControllers:childViewControllers];
+	[uut loadChildren:childViewControllers];
 	XCTAssertEqual(uut.viewControllers[0], child1);
 	XCTAssertEqual(uut.viewControllers[1], child2);
 }

playground/src/screens/SetRootScreen.js

@@ -5,7 +5,10 @@ const Navigation = require('./../services/Navigation');
 const {
   NAVIGATION_TAB,
   SET_MULTIPLE_ROOTS_BTN,
-  SET_ROOT_BTN
+  SET_ROOT_BTN,
+  LAYOUTS_TAB,
+  SET_ROOT_HIDES_BOTTOM_TABS_BTN,
+  SET_ROOT_WITH_STACK_HIDES_BOTTOM_TABS_BTN
 } = require('../testIDs');
 const Screens = require('./Screens');
 const { logLifecycleEvent } = require('./StaticLifecycleOverlay');
@@ -37,6 +40,8 @@ class SetRootScreen  extends React.Component {
       <Root componentId={this.props.componentId}>
         <Button label='Set Root' testID={SET_ROOT_BTN} onPress={this.setSingleRoot} />
         <Button label='Set Multiple Roots' testID={SET_MULTIPLE_ROOTS_BTN} onPress={this.setMultipleRoot} />
+        <Button label='Set Root - hides bottomTabs' testID={SET_ROOT_HIDES_BOTTOM_TABS_BTN} onPress={this.setRootHidesBottomTabs} />
+        <Button label='Set Root with stack - hides bottomTabs' testID={SET_ROOT_WITH_STACK_HIDES_BOTTOM_TABS_BTN} onPress={this.setRootWithStackHidesBottomTabs} />
       </Root>
     );
   }
@@ -68,6 +73,68 @@ class SetRootScreen  extends React.Component {
       }
     }
   });
+  
+  setRootHidesBottomTabs = async () => await Navigation.setRoot({
+    root: {
+      bottomTabs: {
+        children: [{
+          stack: {
+            id: 'stack',
+            children: [{
+              component: {
+                id: 'component',
+                name: Screens.Pushed,
+                options: {
+                  bottomTabs: {
+                    visible: false
+                  }
+                }
+              }
+            }]
+          }
+        }],
+        options: {
+          bottomTabs: {
+            testID: LAYOUTS_TAB
+          }
+        }
+      }
+    }
+  });
+
+  setRootWithStackHidesBottomTabs = async () => await Navigation.setRoot({
+    root: {
+      bottomTabs: {
+        children: [{
+          stack: {
+            id: 'stack',
+            children: [{
+              component: {
+                id: 'component',
+                name: Screens.Pushed
+              }
+            },
+            {
+              component: {
+                id: 'component2',
+                name: Screens.Pushed,
+                options: {
+                  bottomTabs: {
+                    visible: false
+                  }
+                }
+              }
+            }]
+          }
+        }],
+        options: {
+          bottomTabs: {
+            testID: LAYOUTS_TAB
+          }
+        }
+      }
+    }
+  });
 }
 
 module.exports = SetRootScreen;

playground/src/testIDs.js

@@ -69,6 +69,8 @@ module.exports = {
   PUSH_TO_TEST_DID_DISAPPEAR_BTN: 'PUSH_TO_TEST_DID_DISAPPEAR_BTN',
   SET_ROOT_BTN: 'SET_ROOT_BTN',
   SET_MULTIPLE_ROOTS_BTN: 'SET_MULTIPLE_ROOTS_BTN',
+  SET_ROOT_WITH_STACK_HIDES_BOTTOM_TABS_BTN: 'SET_ROOT_WITH_STACK_HIDES_BOTTOM_TABS_BTN',
+  SET_ROOT_HIDES_BOTTOM_TABS_BTN: 'SET_ROOT_HIDES_BOTTOM_TABS_BTN',
   ADD_BACK_HANDLER: 'ADD_BACK_HANDLER',
   REMOVE_BACK_HANDLER: 'REMOVE_BACK_HANDLER',
   OPEN_LEFT_SIDE_MENU_BTN: 'OPEN_LEFT_SIDE_MENU_BTN',