Browse Source

pass the tests, while best practice isn't achieve :(

Ran Greenberg 7 years ago
parent
commit
5fe3a296a8
2 changed files with 5 additions and 17 deletions
  1. 5
    5
      lib/ios/RNNNavigationOptions.h
  2. 0
    12
      lib/ios/RNNNavigationOptions.m

+ 5
- 5
lib/ios/RNNNavigationOptions.h View File

@@ -3,11 +3,11 @@
3 3
 
4 4
 @interface RNNNavigationOptions : NSObject
5 5
 
6
-@property (nonatomic, strong, readonly) NSNumber* topBarBackgroundColor;
7
-@property (nonatomic, strong, readonly) NSNumber* topBarTextColor;
8
-@property (nonatomic, strong, readonly) NSNumber* statusBarHidden;
9
-@property (nonatomic, strong, readonly) NSString* title;
10
-@property (nonatomic, strong, readonly) NSString* setTabBadge;
6
+@property (nonatomic, strong) NSNumber* topBarBackgroundColor;
7
+@property (nonatomic, strong) NSNumber* topBarTextColor;
8
+@property (nonatomic, strong) NSNumber* statusBarHidden;
9
+@property (nonatomic, strong) NSString* title;
10
+@property (nonatomic, strong) NSString* setTabBadge;
11 11
 
12 12
 -(instancetype)init;
13 13
 -(instancetype)initWithDict:(NSDictionary *)navigationOptions;

+ 0
- 12
lib/ios/RNNNavigationOptions.m View File

@@ -2,18 +2,6 @@
2 2
 #import <React/RCTConvert.h>
3 3
 
4 4
 
5
-
6
-@interface RNNNavigationOptions ()
7
-
8
-@property (nonatomic, strong, readwrite) NSNumber* topBarBackgroundColor;
9
-@property (nonatomic, strong, readwrite) NSNumber* topBarTextColor;
10
-@property (nonatomic, strong, readwrite) NSNumber* statusBarHidden;
11
-@property (nonatomic, strong, readwrite) NSString* title;
12
-@property (nonatomic, strong, readwrite) NSString* setTabBadge;
13
-
14
-
15
-@end
16
-
17 5
 @implementation RNNNavigationOptions
18 6
 
19 7
 -(instancetype)init {