Remove push overload

lib/android/app/src/main/java/com/reactnativenavigation/parse/LayoutFactory.java

@@ -3,6 +3,7 @@ package com.reactnativenavigation.parse;
 import android.app.Activity;
 
 import com.facebook.react.ReactInstanceManager;
+import com.reactnativenavigation.utils.CommandListenerAdapter;
 import com.reactnativenavigation.utils.ImageLoader;
 import com.reactnativenavigation.utils.TypefaceLoader;
 import com.reactnativenavigation.viewcontrollers.ComponentViewController;
@@ -136,7 +137,7 @@ public class LayoutFactory {
 
     private void addChildrenToStack(List<LayoutNode> children, StackController stackController) {
         for (LayoutNode child : children) {
-            stackController.push(create(child));
+            stackController.push(create(child), new CommandListenerAdapter());
         }
     }
 

lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/StackController.java

@@ -89,10 +89,6 @@ public class StackController extends ParentController<StackLayout> {
         topBarController.clear();
     }
 
-    public void push(ViewController child) {
-        push(child, new CommandListenerAdapter());
-    }
-
     public void push(ViewController child, CommandListener listener) {
         final ViewController toRemove = stack.peek();
         child.setParentController(this);

lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/BottomTabsControllerTest.java

@@ -137,7 +137,7 @@ public class BottomTabsControllerTest extends BaseTest {
 
         StackController stack = spy(createStack("stack"));
         stack.ensureViewIsCreated();
-        stack.push(uut);
+        stack.push(uut, new CommandListenerAdapter());
 
         child1.onViewAppeared();
         ArgumentCaptor<Options> optionsCaptor = ArgumentCaptor.forClass(Options.class);

lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/FloatingActionButtonTest.java

@@ -83,25 +83,25 @@ public class FloatingActionButtonTest extends BaseTest {
 
     @Test
     public void showOnPush() {
-        stackController.push(childFab);
+        stackController.push(childFab, new CommandListenerAdapter());
         childFab.onViewAppeared();
         assertThat(hasFab()).isTrue();
     }
 
     @Test
     public void hideOnPush() {
-        stackController.push(childFab);
+        stackController.push(childFab, new CommandListenerAdapter());
         childFab.onViewAppeared();
         assertThat(hasFab()).isTrue();
-        stackController.push(childNoFab);
+        stackController.push(childNoFab, new CommandListenerAdapter());
         childNoFab.onViewAppeared();
         assertThat(hasFab()).isFalse();
     }
 
     @Test
     public void hideOnPop() {
-        stackController.push(childNoFab);
-        stackController.push(childFab);
+        stackController.push(childNoFab, new CommandListenerAdapter());
+        stackController.push(childFab, new CommandListenerAdapter());
         childFab.onViewAppeared();
         assertThat(hasFab()).isTrue();
         stackController.pop(new CommandListenerAdapter());
@@ -114,8 +114,8 @@ public class FloatingActionButtonTest extends BaseTest {
         childFab.options.animated = new Bool(false);
         childNoFab.options.animated = new Bool(false);
 
-        stackController.push(childFab);
-        stackController.push(childNoFab);
+        stackController.push(childFab, new CommandListenerAdapter());
+        stackController.push(childNoFab, new CommandListenerAdapter());
         childNoFab.onViewAppeared();
         assertThat(hasFab()).isFalse();
         stackController.pop(new CommandListenerAdapter());
@@ -126,7 +126,7 @@ public class FloatingActionButtonTest extends BaseTest {
     @Test
     public void hasChildren() {
         childFab = new SimpleViewController(activity, "child1", getOptionsWithFabActions());
-        stackController.push(childFab);
+        stackController.push(childFab, new CommandListenerAdapter());
         childFab.onViewAppeared();
         assertThat(hasFab()).isTrue();
         assertThat(containsActions()).isTrue();

lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/NavigatorTest.java

@@ -340,7 +340,7 @@ public class NavigatorTest extends BaseTest {
     public void pushIntoModal() {
         uut.setRoot(parentController, new MockPromise());
         StackController stackController = newStack();
-        stackController.push(child1);
+        stackController.push(child1, new CommandListenerAdapter());
         uut.showModal(stackController, new MockPromise());
         uut.push(stackController.getId(), child2, new CommandListenerAdapter());
         assertIsChildById(stackController.getView(), child2.getView());
@@ -353,10 +353,10 @@ public class NavigatorTest extends BaseTest {
         StackController parent = newStack();
         parent.ensureViewIsCreated();
         uut.setRoot(parent, new MockPromise());
-        parent.push(parentController);
+        parent.push(parentController, new CommandListenerAdapter());
 
-        parentController.push(child1);
-        parentController.push(child2);
+        parentController.push(child1, new CommandListenerAdapter());
+        parentController.push(child2, new CommandListenerAdapter());
         assertThat(parentController.getChildControllers().size()).isEqualTo(2);
         child1.ensureViewIsCreated();
         child2.ensureViewIsCreated();

lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/OptionsApplyingTest.java

@@ -193,7 +193,7 @@ public class OptionsApplyingTest extends BaseTest {
         json.put("component", new JSONObject().put("name","someComponent").put("componentId", "id"));
         uut.options.topBarOptions.background = TopBarBackgroundOptions.parse(json);
         uut.ensureViewIsCreated();
-        stackController.push(uut);
+        stackController.push(uut, new CommandListenerAdapter());
         uut.onViewAppeared();
 
         assertThat(((ColorDrawable) stackController.getTopBar().getTitleBar().getBackground()).getColor()).isEqualTo(Color.TRANSPARENT);
@@ -206,7 +206,7 @@ public class OptionsApplyingTest extends BaseTest {
         json.put("text", "sub");
         uut.options.topBarOptions.subtitle = SubtitleOptions.parse(new TypefaceLoaderMock(), json);
         uut.ensureViewIsCreated();
-        stackController.push(uut);
+        stackController.push(uut, new CommandListenerAdapter());
         uut.onViewAppeared();
 
         assertThat(stackController.getTopBar().getTitleBar().getSubtitle()).isEqualTo("sub");

lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/TopTabsViewControllerTest.java

@@ -64,7 +64,7 @@ public class TopTabsViewControllerTest extends BaseTest {
         tabControllers.forEach(viewController -> viewController.setParentController(uut));
 
         parentController = spy(createStackController("stackId"));
-        parentController.push(uut);
+        parentController.push(uut, new CommandListenerAdapter());
         uut.setParentController(parentController);
     }
 
@@ -233,8 +233,8 @@ public class TopTabsViewControllerTest extends BaseTest {
         );
         first.options.animated = new Bool(false);
         uut.options.animated = new Bool(false);
-        stackController.push(first);
-        stackController.push(uut);
+        stackController.push(first, new CommandListenerAdapter());
+        stackController.push(uut, new CommandListenerAdapter());
 
         first.ensureViewIsCreated();
         uut.ensureViewIsCreated();