fix lint of old code

ios/RCCNavigationController.m

@@ -200,7 +200,7 @@ NSString const *CALLBACK_ASSOCIATED_ID = @"RCCNavigationController.CALLBACK_ASSO
     BOOL animatedBool = animated ? [animated boolValue] : YES;
     
     NSNumber *setHidden = actionParams[@"hidden"];
-    BOOL isHiddenBool = setHidden ? [setHidden boolValue] : NO;
+//    BOOL isHiddenBool = setHidden ? [setHidden boolValue] : NO; 
     
     RCCViewController *topViewController = ((RCCViewController*)self.topViewController);
     topViewController.navigatorStyle[@"navBarHidden"] = setHidden;
@@ -213,12 +213,12 @@ NSString const *CALLBACK_ASSOCIATED_ID = @"RCCNavigationController.CALLBACK_ASSO
 {
   NSString *callbackId = objc_getAssociatedObject(barButtonItem, &CALLBACK_ASSOCIATED_KEY);
   if (!callbackId) return;
-  NSString *buttonId = objc_getAssociatedObject(barButtonItem, &CALLBACK_ASSOCIATED_ID);
-  [[[RCCManager sharedInstance] getBridge].eventDispatcher sendAppEventWithName:callbackId body:@
-   {
-     @"type": @"NavBarButtonPress",
-     @"id": buttonId ? buttonId : [NSNull null]
-   }];
+//  NSString *buttonId = objc_getAssociatedObject(barButtonItem, &CALLBACK_ASSOCIATED_ID);
+//  [[[RCCManager sharedInstance] getBridge].eventDispatcher sendAppEventWithName:callbackId body:@
+//   {
+//     @"type": @"NavBarButtonPress",
+//     @"id": buttonId ? buttonId : [NSNull null]
+//   }];
 }
 
 -(void)setButtons:(NSArray*)buttons viewController:(UIViewController*)viewController side:(NSString*)side animated:(BOOL)animated

ios/RCCNotification.m

@@ -32,7 +32,7 @@
         [self.reactView.contentView.layer addObserver:self forKeyPath:@"frame" options:0 context:nil];
         [self.reactView.contentView.layer addObserver:self forKeyPath:@"bounds" options:0 context:NULL];
         
-        [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(onRNReload) name:RCTReloadNotification object:nil];
+//        [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(onRNReload) name:RCTReloadNotification object:nil];
         
         if ([params[@"dismissWithSwipe"] boolValue])
         {
@@ -434,7 +434,7 @@ static NSMutableArray *gShownNotificationViews = nil;
 
 +(void)dismissWithParams:(NSDictionary*)params resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject
 {
-    int count = [gShownNotificationViews count];
+    int count = (int)[gShownNotificationViews count];
     for (int i = count - 1 ; i >= 0; i--)
     {
         NotificationView *notificationView = [gShownNotificationViews objectAtIndex:i];

ios/RNNBridgeModule.m

@@ -14,16 +14,10 @@ RCT_EXPORT_MODULE(NativeNavigation);
 
 RCT_EXPORT_METHOD(startApp:(NSDictionary*)layout)
 {
-    dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(0.1 * NSEC_PER_SEC)), dispatch_get_main_queue(), ^{
-        
-        RCTBridge* bridge = RNNStore.sharedInstance.bridge;
-        
-        RNNStore.appDelegate.window.rootViewController = [RNNControllerFactory createRootViewController:layout];
-        [RNNStore.appDelegate.window makeKeyAndVisible];
-    });
-    
-    
+    RCTBridge* bridge = RNNStore.sharedInstance.bridge;
     
+    RNNStore.appDelegate.window.rootViewController = [RNNControllerFactory createRootViewController:layout];
+    [RNNStore.appDelegate.window makeKeyAndVisible];
 }
 
 @end

ios/RNNSplashScreen.h

@@ -2,6 +2,6 @@
 
 @interface RNNSplashScreen : NSObject
 
-+(void)showSplashScreenWhileLoadingJS;
++(void)show;
 
 @end

ios/RNNSplashScreen.m

@@ -4,7 +4,7 @@
 
 @implementation RNNSplashScreen
 
-+(void)showSplashScreenWhileLoadingJS
++(void)show
 {
     CGRect screenBounds = [UIScreen mainScreen].bounds;
     UIView *splashView = nil;

ios/ReactNativeNavigation.m

@@ -3,7 +3,7 @@
 #import "RNNStore.h"
 #import "RCTBridge.h"
 #import "RNNSplashScreen.h"
-#import "RCTRootView.h";
+#import "RCTRootView.h"
 
 @implementation ReactNativeNavigation
 
@@ -14,15 +14,12 @@
 
 +(void)bootstrap:(NSURL *)jsCodeLocation launchOptions:(NSDictionary *)launchOptions
 {
+    RNNStore.appDelegate.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds];
+    RNNStore.appDelegate.window.backgroundColor = [UIColor whiteColor];
     
-        RNNStore.appDelegate.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds];
-        RNNStore.appDelegate.window.backgroundColor = [UIColor whiteColor];
-        
-        [RNNSplashScreen showSplashScreenWhileLoadingJS];
-        
-        RNNStore.sharedInstance.bridge = [[RCTBridge alloc] initWithBundleURL:jsCodeLocation moduleProvider:nil launchOptions:launchOptions];
-        
+    [RNNSplashScreen show];
     
+    RNNStore.sharedInstance.bridge = [[RCTBridge alloc] initWithBundleURL:jsCodeLocation moduleProvider:nil launchOptions:launchOptions];
 }
 
 @end

ios/ReactNativeNavigation.xcodeproj/project.pbxproj

@@ -257,18 +257,18 @@
 		D8AFADB41BEE6F3F00A4592D = {
 			isa = PBXGroup;
 			children = (
-				7BC9346C1E26886E00EFA125 /* RNNControllerFactory.h */,
-				7BC9346D1E26886E00EFA125 /* RNNControllerFactory.m */,
-				7BC934691E267BAD00EFA125 /* RNNCommandsHandler.h */,
-				7BC9346A1E267BAD00EFA125 /* RNNCommandsHandler.m */,
 				7BA500731E2544B9001B9E1B /* ReactNativeNavigation.h */,
 				7BA500741E2544B9001B9E1B /* ReactNativeNavigation.m */,
 				7BA500761E254908001B9E1B /* RNNSplashScreen.h */,
 				7BA500771E254908001B9E1B /* RNNSplashScreen.m */,
-				7BBFE55F1E253F97002A6182 /* RNNStore.h */,
-				7BBFE5601E253F97002A6182 /* RNNStore.m */,
 				7BBFE5421E25330E002A6182 /* RNNBridgeModule.h */,
 				7BBFE5431E25330E002A6182 /* RNNBridgeModule.m */,
+				7BC9346C1E26886E00EFA125 /* RNNControllerFactory.h */,
+				7BC9346D1E26886E00EFA125 /* RNNControllerFactory.m */,
+				7BC934691E267BAD00EFA125 /* RNNCommandsHandler.h */,
+				7BC9346A1E267BAD00EFA125 /* RNNCommandsHandler.m */,
+				7BBFE55F1E253F97002A6182 /* RNNStore.h */,
+				7BBFE5601E253F97002A6182 /* RNNStore.m */,
 				7BBFE53F1E253144002A6182 /* old */,
 				D8AFADBE1BEE6F3F00A4592D /* Products */,
 			);
@@ -482,6 +482,7 @@
 		D8AFADC71BEE6F3F00A4592D /* Debug */ = {
 			isa = XCBuildConfiguration;
 			buildSettings = {
+				GCC_TREAT_WARNINGS_AS_ERRORS = YES;
 				HEADER_SEARCH_PATHS = (
 					"$(inherited)",
 					"$(SRCROOT)/../../react-native/React/**",
@@ -495,6 +496,7 @@
 		D8AFADC81BEE6F3F00A4592D /* Release */ = {
 			isa = XCBuildConfiguration;
 			buildSettings = {
+				GCC_TREAT_WARNINGS_AS_ERRORS = YES;
 				HEADER_SEARCH_PATHS = (
 					"$(inherited)",
 					"$(SRCROOT)/../../react-native/React/**",

package.json

@@ -42,8 +42,9 @@
     "lodash": "4.x.x"
   },
   "devDependencies": {
-    "react-native": "0.38.0",
-    "react": "15.4.1",
+    "react-native": "0.40.0",
+    "react": "15.4.2",
+    "react-test-renderer": "15.4.2",
     "babel-cli": "6.x.x",
     "babel-core": "6.x.x",
     "babel-polyfill": "6.x.x",
@@ -56,7 +57,6 @@
     "eslint-plugin-react-native": "2.x.x",
     "jest": "18.x.x",
     "jest-cli": "18.x.x",
-    "react-test-renderer": "15.4.1",
     "remx": "0.1.x",
     "semver": "5.x.x",
     "shell-utils": "1.x.x"