Browse Source

fix tests

Daniel Zlotin 7 years ago
parent
commit
71ebedbd1d

+ 1
- 21
lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/ParentControllerTest.java View File

81
 	}
81
 	}
82
 
82
 
83
 	@Test
83
 	@Test
84
-	public void lifecycleMethodsPassDownToChildren_onAppear() throws Exception {
85
-		ViewController child1 = spy(new SimpleViewController(activity, "child1"));
86
-		children.add(child1);
87
-
88
-		verify(child1, times(0)).onViewAppeared();
89
-		uut.onViewAppeared();
90
-		verify(child1, times(1)).onViewAppeared();
91
-	}
92
-
93
-	@Test
94
-	public void lifecycleMethodsPassDownToChildren_onDisappear() throws Exception {
95
-		ViewController child1 = spy(new SimpleViewController(activity, "child1"));
96
-		children.add(child1);
97
-
98
-		verify(child1, times(0)).onViewDisappear();
99
-		uut.onViewDisappear();
100
-		verify(child1, times(1)).onViewDisappear();
101
-	}
102
-
103
-	@Test
104
-	public void lifecycleMethodsPassDownToChildren_onDestroy() throws Exception {
84
+	public void destory_DestorysChildren() throws Exception {
105
 		ViewController child1 = spy(new SimpleViewController(activity, "child1"));
85
 		ViewController child1 = spy(new SimpleViewController(activity, "child1"));
106
 		children.add(child1);
86
 		children.add(child1);
107
 
87
 

+ 6
- 2
lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/ViewControllerTest.java View File

3
 import android.app.Activity;
3
 import android.app.Activity;
4
 import android.view.View;
4
 import android.view.View;
5
 import android.view.ViewParent;
5
 import android.view.ViewParent;
6
+import android.widget.LinearLayout;
6
 
7
 
7
 import com.reactnativenavigation.BaseTest;
8
 import com.reactnativenavigation.BaseTest;
8
 import com.reactnativenavigation.mocks.SimpleViewController;
9
 import com.reactnativenavigation.mocks.SimpleViewController;
13
 
14
 
14
 import java.lang.reflect.Field;
15
 import java.lang.reflect.Field;
15
 
16
 
16
-import static org.assertj.core.api.Assertions.fail;
17
 import static org.assertj.core.api.Java6Assertions.assertThat;
17
 import static org.assertj.core.api.Java6Assertions.assertThat;
18
 import static org.mockito.Mockito.mock;
18
 import static org.mockito.Mockito.mock;
19
 import static org.mockito.Mockito.spy;
19
 import static org.mockito.Mockito.spy;
174
 
174
 
175
 	@Test
175
 	@Test
176
 	public void onDestroy_RemovesSelfFromParentIfExists() throws Exception {
176
 	public void onDestroy_RemovesSelfFromParentIfExists() throws Exception {
177
-		fail("implement");
177
+		LinearLayout parent = new LinearLayout(activity);
178
+		parent.addView(uut.getView());
179
+
180
+		uut.destroy();
181
+		assertThat(parent.getChildCount()).withFailMessage("expected not to have children").isZero();
178
 	}
182
 	}
179
 }
183
 }
180
 
184