POC snackbar and FAB works. some minor formatting

android/app/src/main/java/com/reactnativenavigation/activities/BaseReactActivity.java

@@ -46,9 +46,6 @@ import java.util.List;
 
 import javax.annotation.Nullable;
 
-/**
- * Base Activity for React Native applications.
- */
 public abstract class BaseReactActivity extends AppCompatActivity implements DefaultHardwareBackBtnHandler {
 
     protected static final String KEY_ANIMATED = "animated";
@@ -157,6 +154,7 @@ public abstract class BaseReactActivity extends AppCompatActivity implements Def
         ContextProvider.setActivityContext(this);
         mReactInstanceManager = createReactInstanceManager();
         handleOnCreate();
+
     }
 
     /**
@@ -176,14 +174,15 @@ public abstract class BaseReactActivity extends AppCompatActivity implements Def
 
     @CallSuper
     protected void handleOnCreate() {
-        if (getUseDeveloperSupport() && Build.VERSION.SDK_INT >= 23) {
-            // Get permission to show redbox in dev builds.
-            if (!Settings.canDrawOverlays(this)) {
-                Intent serviceIntent = new Intent(Settings.ACTION_MANAGE_OVERLAY_PERMISSION);
-                startActivity(serviceIntent);
-                FLog.w(ReactConstants.TAG, REDBOX_PERMISSION_MESSAGE);
-                Toast.makeText(this, REDBOX_PERMISSION_MESSAGE, Toast.LENGTH_LONG).show();
-            }
+        permissionToShowRedboxIfNeeded();
+    }
+
+    private void permissionToShowRedboxIfNeeded() {
+        if (getUseDeveloperSupport() && Build.VERSION.SDK_INT >= 23 && !Settings.canDrawOverlays(this)) {
+            Intent serviceIntent = new Intent(Settings.ACTION_MANAGE_OVERLAY_PERMISSION);
+            startActivity(serviceIntent);
+            FLog.w(ReactConstants.TAG, REDBOX_PERMISSION_MESSAGE);
+            Toast.makeText(this, REDBOX_PERMISSION_MESSAGE, Toast.LENGTH_LONG).show();
         }
     }
 
@@ -230,7 +229,7 @@ public abstract class BaseReactActivity extends AppCompatActivity implements Def
             mToolbar.update(screen);
 
             if (getCurrentNavigatorId().equals(screen.navigatorId) &&
-                getScreenStackSize() >= 1) {
+                    getScreenStackSize() >= 1) {
                 mToolbar.setNavUpButton(screen);
             }
         }
@@ -239,8 +238,8 @@ public abstract class BaseReactActivity extends AppCompatActivity implements Def
     @CallSuper
     public Screen pop(String navigatorId) {
         if (mToolbar != null &&
-            getCurrentNavigatorId().equals(navigatorId) &&
-            getScreenStackSize() <= 2) {
+                getCurrentNavigatorId().equals(navigatorId) &&
+                getScreenStackSize() <= 2) {
             mToolbar.setNavUpButton();
         }
 
@@ -303,8 +302,8 @@ public abstract class BaseReactActivity extends AppCompatActivity implements Def
     @Override
     public boolean onOptionsItemSelected(MenuItem item) {
         if (mDrawerToggle != null &&
-            getScreenStackSize() == 1 &&
-            mDrawerToggle.onOptionsItemSelected(item)) {
+                getScreenStackSize() == 1 &&
+                mDrawerToggle.onOptionsItemSelected(item)) {
             return true;
         }
 
@@ -342,7 +341,7 @@ public abstract class BaseReactActivity extends AppCompatActivity implements Def
     @Override
     public boolean onKeyUp(int keyCode, KeyEvent event) {
         if (mReactInstanceManager != null &&
-            mReactInstanceManager.getDevSupportManager().getDevSupportEnabled()) {
+                mReactInstanceManager.getDevSupportManager().getDevSupportEnabled()) {
             if (keyCode == KeyEvent.KEYCODE_MENU) {
                 mReactInstanceManager.showDevOptionsDialog();
                 return true;
@@ -400,7 +399,7 @@ public abstract class BaseReactActivity extends AppCompatActivity implements Def
         mDrawerToggle = mToolbar.setupDrawer(mDrawerLayout, drawer.left, screen);
     }
 
-    public void setNavigationButtons(ReadableMap buttons){
+    public void setNavigationButtons(ReadableMap buttons) {
         if (mToolbar == null) {
             return;
         }

android/app/src/main/java/com/reactnativenavigation/activities/BottomTabActivity.java

@@ -22,9 +22,6 @@ import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.Map;
 
-/**
- * Created by guyc on 02/04/16.
- */
 public class BottomTabActivity extends BaseReactActivity implements AHBottomNavigation.OnTabSelectedListener {
     public static final String DRAWER_PARAMS = "drawerParams";
     public static final String EXTRA_SCREENS = "extraScreens";
@@ -84,7 +81,7 @@ public class BottomTabActivity extends BaseReactActivity implements AHBottomNavi
     @Override
     protected void onResume() {
         super.onResume();
-        if(mScreenStacks != null) {
+        if (mScreenStacks != null) {
             StyleHelper.updateStyles(mToolbar, getCurrentScreen());
         }
     }
@@ -100,8 +97,7 @@ public class BottomTabActivity extends BaseReactActivity implements AHBottomNavi
     private static int getColor(Bundle bundle, String key, int defaultColor) {
         if (bundle.containsKey(key)) {
             return Color.parseColor(bundle.getString(key));
-        }
-        else {
+        } else {
             return defaultColor;
         }
     }
@@ -127,7 +123,7 @@ public class BottomTabActivity extends BaseReactActivity implements AHBottomNavi
     @Override
     public Screen pop(String navigatorId) {
         super.pop(navigatorId);
-        for (ScreenStack stack: mScreenStacks) {
+        for (ScreenStack stack : mScreenStacks) {
             if (stack.peek().navigatorId.equals(navigatorId)) {
                 Screen popped = stack.pop();
                 StyleHelper.updateStyles(mToolbar, getCurrentScreen());
@@ -140,7 +136,7 @@ public class BottomTabActivity extends BaseReactActivity implements AHBottomNavi
     @Override
     public Screen popToRoot(String navigatorId) {
         super.popToRoot(navigatorId);
-        for (ScreenStack stack: mScreenStacks) {
+        for (ScreenStack stack : mScreenStacks) {
             if (stack.peek().navigatorId.equals(navigatorId)) {
                 Screen popped = stack.popToRoot();
                 StyleHelper.updateStyles(mToolbar, getCurrentScreen());
@@ -261,7 +257,7 @@ public class BottomTabActivity extends BaseReactActivity implements AHBottomNavi
 
     private void setTabsWithIcons(ArrayList<Screen> screens, Map<Screen, Drawable> icons) {
         mScreenStacks = new ArrayList<>();
-        for(Screen screen: screens) {
+        for (Screen screen : screens) {
             ScreenStack stack = new ScreenStack(this);
             stack.push(screen);
             mScreenStacks.add(stack);

android/app/src/main/java/com/reactnativenavigation/activities/RootActivity.java

@@ -1,5 +1,7 @@
 package com.reactnativenavigation.activities;
 
+import android.view.ViewGroup;
+
 import com.facebook.react.ReactRootView;
 import com.reactnativenavigation.core.objects.Screen;
 
@@ -26,7 +28,7 @@ public class RootActivity extends BaseReactActivity {
         finish();
     }
 
-     // No need to implement stack interface since this activity is only used to start other
+    // No need to implement stack interface since this activity is only used to start other
     // activities such as TabActivity or SingleScreenActivity.
     @Override
     public Screen getCurrentScreen() {
@@ -42,4 +44,5 @@ public class RootActivity extends BaseReactActivity {
     public int getScreenStackSize() {
         return 0;
     }
+
 }

android/app/src/main/java/com/reactnativenavigation/activities/SingleScreenActivity.java

@@ -10,9 +10,6 @@ import com.reactnativenavigation.utils.StyleHelper;
 import com.reactnativenavigation.views.RnnToolBar;
 import com.reactnativenavigation.views.ScreenStack;
 
-/**
- * Created by guyc on 05/04/16.
- */
 public class SingleScreenActivity extends BaseReactActivity {
 
     public static final String DRAWER_PARAMS = "drawerParams";

android/app/src/main/java/com/reactnativenavigation/activities/TabActivity.java

@@ -1,7 +1,9 @@
 package com.reactnativenavigation.activities;
 
+import android.support.design.widget.CoordinatorLayout;
 import android.support.v4.view.ViewPager;
 import android.view.Menu;
+import android.view.ViewGroup;
 
 import com.reactnativenavigation.R;
 import com.reactnativenavigation.adapters.ViewPagerAdapter;

android/app/src/main/java/com/reactnativenavigation/modules/RctActivityModule.java

@@ -23,9 +23,6 @@ import com.reactnativenavigation.utils.ContextProvider;
 
 import java.util.ArrayList;
 
-/**
- * Created by guyc on 10/03/16.
- */
 public class RctActivityModule extends ReactContextBaseJavaModule {
     public static final String REACT_CLASS = "RctActivity";
     private static final String KEY_NAVIGATOR_ID = "navigatorID";
@@ -321,7 +318,6 @@ public class RctActivityModule extends ReactContextBaseJavaModule {
         }
     }
 
-
     /**
      * Dismisses the top modal (the last modal pushed).
      */

android/app/src/main/java/com/reactnativenavigation/packages/RnnPackage.java

@@ -11,10 +11,6 @@ import java.util.Arrays;
 import java.util.Collections;
 import java.util.List;
 
-/**
- *
- * Created by guyc on 07/03/16.
- */
 public class RnnPackage implements ReactPackage {
 
     @Override

android/app/src/main/res/layout/bottom_tab_activity.xml

@@ -1,45 +1,48 @@
 <?xml version="1.0" encoding="utf-8"?>
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:tools="http://schemas.android.com/tools"
     xmlns:app="http://schemas.android.com/apk/res-auto"
-    android:orientation="vertical"
+    xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
-    tools:context=".activities.TabActivity"
-    android:animateLayoutChanges="true">
+    android:animateLayoutChanges="true"
+    android:orientation="vertical"
+    tools:context=".activities.BottomTabActivity">
 
     <android.support.design.widget.AppBarLayout
         android:id="@+id/appbar"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:fitsSystemWindows="true">
+
         <com.reactnativenavigation.views.RnnToolBar
             android:id="@+id/toolbar"
             android:layout_width="match_parent"
             android:layout_height="?attr/actionBarSize"
-            app:layout_scrollFlags="scroll|enterAlways"/>
+            app:layout_scrollFlags="scroll|enterAlways" />
     </android.support.design.widget.AppBarLayout>
 
     <android.support.v4.widget.DrawerLayout
-        xmlns:android="http://schemas.android.com/apk/res/android"
         android:id="@+id/drawerLayout"
         android:layout_width="match_parent"
         android:layout_height="0dp"
         android:layout_weight="1">
+
         <FrameLayout
             android:id="@+id/contentFrame"
             android:layout_width="match_parent"
             android:layout_height="0dp"
-            android:layout_weight="1"/>
-        <FrameLayout android:id="@+id/drawerFrame"
+            android:layout_weight="1" />
+
+        <FrameLayout
+            android:id="@+id/drawerFrame"
             android:layout_width="240dp"
             android:layout_height="match_parent"
-            android:layout_gravity="start"/>
+            android:layout_gravity="start" />
     </android.support.v4.widget.DrawerLayout>
 
     <com.aurelhubert.ahbottomnavigation.AHBottomNavigation
         android:id="@+id/bottom_tab_bar"
         android:layout_width="match_parent"
-        android:layout_height="wrap_content"/>
+        android:layout_height="wrap_content" />
 
 </LinearLayout>

android/app/src/main/res/layout/modal_layout.xml

@@ -1,25 +1,26 @@
 <?xml version="1.0" encoding="utf-8"?>
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
-    android:background="@android:color/transparent"
-    android:orientation="vertical"
     android:layout_width="match_parent"
-    android:layout_height="match_parent">
+    android:layout_height="match_parent"
+    android:background="@android:color/transparent"
+    android:orientation="vertical">
 
     <android.support.design.widget.AppBarLayout
         android:id="@+id/appbar"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:fitsSystemWindows="true">
+
         <com.reactnativenavigation.views.RnnToolBar
             android:id="@+id/toolbar"
             android:layout_width="match_parent"
             android:layout_height="?attr/actionBarSize"
-            app:layout_scrollFlags="scroll|enterAlways"/>
+            app:layout_scrollFlags="scroll|enterAlways" />
     </android.support.design.widget.AppBarLayout>
 
     <com.reactnativenavigation.views.ScreenStack
         android:id="@+id/screenStack"
         android:layout_width="match_parent"
-        android:layout_height="match_parent"/>
+        android:layout_height="match_parent" />
 </LinearLayout>

android/app/src/main/res/layout/single_screen_activity.xml

@@ -1,34 +1,37 @@
 <?xml version="1.0" encoding="utf-8"?>
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
-    android:orientation="vertical"
     android:layout_width="match_parent"
-    android:layout_height="match_parent">
+    android:layout_height="match_parent"
+    android:orientation="vertical">
 
     <android.support.design.widget.AppBarLayout
         android:id="@+id/appbar"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:fitsSystemWindows="true">
+
         <com.reactnativenavigation.views.RnnToolBar
             android:id="@+id/toolbar"
             android:layout_width="match_parent"
             android:layout_height="?attr/actionBarSize"
-            app:layout_scrollFlags="scroll|enterAlways"/>
+            app:layout_scrollFlags="scroll|enterAlways" />
     </android.support.design.widget.AppBarLayout>
 
     <android.support.v4.widget.DrawerLayout
-        xmlns:android="http://schemas.android.com/apk/res/android"
         android:id="@+id/drawerLayout"
         android:layout_width="match_parent"
         android:layout_height="match_parent">
+
         <FrameLayout
             android:id="@+id/contentFrame"
             android:layout_width="match_parent"
-            android:layout_height="match_parent"/>
-        <FrameLayout android:id="@+id/drawerFrame"
+            android:layout_height="match_parent" />
+
+        <FrameLayout
+            android:id="@+id/drawerFrame"
             android:layout_width="240dp"
             android:layout_height="match_parent"
-            android:layout_gravity="start"/>
+            android:layout_gravity="start" />
     </android.support.v4.widget.DrawerLayout>
 </LinearLayout>

android/app/src/main/res/layout/tab_activity.xml

@@ -1,10 +1,10 @@
 <?xml version="1.0" encoding="utf-8"?>
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:tools="http://schemas.android.com/tools"
     xmlns:app="http://schemas.android.com/apk/res-auto"
-    android:orientation="vertical"
+    xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
+    android:orientation="vertical"
     tools:context=".activities.TabActivity">
 
     <android.support.design.widget.AppBarLayout
@@ -12,21 +12,23 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:fitsSystemWindows="true">
+
         <com.reactnativenavigation.views.RnnToolBar
             android:id="@+id/toolbar"
             android:layout_width="match_parent"
             android:layout_height="?attr/actionBarSize"
-            app:layout_scrollFlags="scroll|enterAlways"/>
+            app:layout_scrollFlags="scroll|enterAlways" />
+
         <com.reactnativenavigation.views.RnnTabLayout
             android:id="@+id/tabLayout"
             android:layout_width="match_parent"
             android:layout_height="?attr/actionBarSize"
-            app:layout_scrollFlags="scroll|enterAlways"/>
+            app:layout_scrollFlags="scroll|enterAlways" />
     </android.support.design.widget.AppBarLayout>
 
     <android.support.v4.view.ViewPager
         android:id="@+id/viewPager"
-        app:layout_behavior="@string/appbar_scrolling_view_behavior"
         android:layout_width="match_parent"
-        android:layout_height="match_parent"/>
+        android:layout_height="match_parent"
+        app:layout_behavior="@string/appbar_scrolling_view_behavior" />
 </LinearLayout>