Fix title bar not displayed if it was initially hidden (#1341)

Also cleaned up VisibilityAnimator.

android/app/src/main/java/com/reactnativenavigation/animation/VisibilityAnimator.java

@@ -1,27 +1,23 @@
 package com.reactnativenavigation.animation;
 
-import android.animation.Animator;
-import android.animation.AnimatorListenerAdapter;
 import android.animation.ObjectAnimator;
 import android.support.v4.view.animation.LinearOutSlowInInterpolator;
 import android.view.View;
 
 public class VisibilityAnimator {
 
+    private final LinearOutSlowInInterpolator interpolator = new LinearOutSlowInInterpolator();
+    private ObjectAnimator animator;
+
     public enum HideDirection {
         Up, Down
     }
 
-    private enum VisibilityState {
-        Hidden, AnimateHide, Shown, AnimateShow
-    }
-
     private static final int SHOW_END_VALUE = 0;
     private static final int DURATION = 300;
 
     private final View view;
     private final int hiddenEndValue;
-    private VisibilityState visibilityState = VisibilityState.Shown;
 
     public VisibilityAnimator(View view, HideDirection hideDirection, int height) {
         this.view = view;
@@ -29,56 +25,45 @@ public class VisibilityAnimator {
     }
 
     public void setVisible(boolean visible, boolean animate) {
-        if (visible && isHiding()) {
+        cancelAnimator();
+        if (visible) {
             show(animate);
-        } else if (!visible && isShowing()) {
+        } else {
             hide(animate);
         }
     }
 
+    private void cancelAnimator() {
+        if (animator != null && animator.isRunning()) {
+            view.clearAnimation();
+            animator.cancel();
+        }
+    }
+
     private void show(boolean animate) {
         if (animate) {
-            ObjectAnimator animator = createAnimator(true);
+            animator = createAnimator(true);
             animator.start();
         } else {
-            visibilityState = VisibilityState.Shown;
-            view.setVisibility(View.VISIBLE);
+            view.setTranslationY(SHOW_END_VALUE);
+            view.setY(SHOW_END_VALUE);
         }
     }
 
     private void hide(boolean animate) {
         if (animate) {
-            ObjectAnimator animator = createAnimator(false);
+            animator = createAnimator(false);
             animator.start();
         } else {
-            visibilityState = VisibilityState.Hidden;
-            view.setVisibility(View.GONE);
+            view.setTranslationY(hiddenEndValue);
+            view.setY(hiddenEndValue);
         }
     }
 
-    private boolean isShowing() {
-        return visibilityState == VisibilityState.Shown || visibilityState == VisibilityState.AnimateShow;
-    }
-
-    private boolean isHiding() {
-        return visibilityState == VisibilityState.Hidden || visibilityState == VisibilityState.AnimateHide;
-    }
-
     private ObjectAnimator createAnimator(final boolean show) {
-        ObjectAnimator animator = ObjectAnimator.ofFloat(view, View.TRANSLATION_Y, show ? SHOW_END_VALUE : hiddenEndValue);
+        final ObjectAnimator animator = ObjectAnimator.ofFloat(view, View.TRANSLATION_Y, show ? SHOW_END_VALUE : hiddenEndValue);
         animator.setDuration(DURATION);
-        animator.setInterpolator(new LinearOutSlowInInterpolator());
-        animator.addListener(new AnimatorListenerAdapter() {
-            @Override
-            public void onAnimationStart(Animator animation) {
-                visibilityState = show ? VisibilityState.AnimateShow : VisibilityState.AnimateHide;
-            }
-
-            @Override
-            public void onAnimationEnd(Animator animation) {
-                visibilityState = show ? VisibilityState.Shown : VisibilityState.Hidden;
-            }
-        });
+        animator.setInterpolator(interpolator);
         return animator;
     }
 }

android/app/src/main/java/com/reactnativenavigation/views/TitleBar.java

@@ -32,11 +32,6 @@ public class TitleBar extends Toolbar {
         super(context);
     }
 
-    @Override
-    protected void onLayout(boolean changed, int l, int t, int r, int b) {
-        super.onLayout(changed, l, t, r, b);
-    }
-
     @Override
     public void onViewAdded(View child) {
         super.onViewAdded(child);
@@ -76,7 +71,6 @@ public class TitleBar extends Toolbar {
     }
 
     public void setStyle(StyleParams params) {
-        setVisibility(params.titleBarHidden ? GONE : VISIBLE);
         setTitleTextColor(params);
         setTitleTextFont(params);
         setSubtitleTextColor(params);