yogevbd 6 years ago
parent
commit
7974b00307
2 changed files with 3 additions and 3 deletions
  1. 2
    2
      e2e/StaticLifecycleEvents.test.js
  2. 1
    1
      lib/ios/RNNRootViewController.m

+ 2
- 2
e2e/StaticLifecycleEvents.test.js View File

16
     await expect(elementByLabel('componentDidDisappear | navigation.playground.WelcomeScreen')).toBeVisible();
16
     await expect(elementByLabel('componentDidDisappear | navigation.playground.WelcomeScreen')).toBeVisible();
17
   });
17
   });
18
 
18
 
19
-  it(':android: unmounts when dismissed', async () => {
19
+  it('unmounts when dismissed', async () => {
20
     await elementById(testIDs.PUSH_STATIC_LIFECYCLE_BUTTON).tap();
20
     await elementById(testIDs.PUSH_STATIC_LIFECYCLE_BUTTON).tap();
21
     await expect(elementByLabel('Static Lifecycle Events Overlay')).toBeVisible();
21
     await expect(elementByLabel('Static Lifecycle Events Overlay')).toBeVisible();
22
     await elementById(testIDs.DISMISS_BUTTON).tap();
22
     await elementById(testIDs.DISMISS_BUTTON).tap();
23
     await expect(elementByLabel('Overlay Unmounted')).toBeVisible();
23
     await expect(elementByLabel('Overlay Unmounted')).toBeVisible();
24
-    await elementById(testIDs.OK_BUTTON).tap();
24
+    await elementByLabel('OK').tap();
25
   });
25
   });
26
 });
26
 });

+ 1
- 1
lib/ios/RNNRootViewController.m View File

14
 @property (nonatomic) BOOL _statusBarHidden;
14
 @property (nonatomic) BOOL _statusBarHidden;
15
 @property (nonatomic) BOOL isExternalComponent;
15
 @property (nonatomic) BOOL isExternalComponent;
16
 @property (nonatomic) BOOL _optionsApplied;
16
 @property (nonatomic) BOOL _optionsApplied;
17
-@property (nonatomic, copy) void (^rotationBlock)(void);
17
+@property (nonatomic, weak) void (^rotationBlock)(void);
18
 @end
18
 @end
19
 
19
 
20
 @implementation RNNRootViewController
20
 @implementation RNNRootViewController