android: trying and failing to avoid OverlayPermissions

android/app/src/main/java/com/reactnativenavigation/react/ReactDevPermission.java

@@ -13,10 +13,8 @@ import com.reactnativenavigation.controllers.NavigationApplication;
 
 public class ReactDevPermission {
 
-    private static boolean hasRequestedPermissions = false;
-
     public static boolean shouldAskPermission() {
-        return !hasRequestedPermissions && NavigationApplication.instance.isDebug() &&
+        return NavigationApplication.instance.isDebug() &&
                 Build.VERSION.SDK_INT >= 23 &&
                 !Settings.canDrawOverlays(NavigationApplication.instance);
     }
@@ -24,7 +22,6 @@ public class ReactDevPermission {
     @TargetApi(23)
     public static void askPermission(Context context) {
         if (shouldAskPermission()) {
-            hasRequestedPermissions = true;
             Intent serviceIntent = new Intent(Settings.ACTION_MANAGE_OVERLAY_PERMISSION);
             context.startActivity(serviceIntent);
             String msg = "Overlay permissions needs to be granted in order for react native apps to run in dev mode";

android/app/src/main/java/com/reactnativenavigation/utils/ViewIdGenerator.java

@@ -1,6 +1,7 @@
 package com.reactnativenavigation.utils;
 
 import android.os.Build;
+import android.support.v4.view.ViewCompat;
 import android.view.View;
 
 import java.util.concurrent.atomic.AtomicInteger;
@@ -17,7 +18,7 @@ public class ViewIdGenerator {
     }
 
     private static int compatGenerateViewId() {
-        while(true) {
+        while (true) {
             final int result = viewId.get();
             // aapt-generated IDs have the high byte nonzero; clamp to the range under that.
             int newValue = result + 1;

playground/android/app/src/androidTest/java/com/reactnativenavigation/playground/ApplicationLifecycleTest.java

@@ -1,7 +1,6 @@
 package com.reactnativenavigation.playground;
 
 import android.provider.Settings;
-import android.support.annotation.RequiresApi;
 import android.support.test.espresso.Espresso;
 import android.support.test.espresso.IdlingResource;
 import android.support.test.filters.SdkSuppress;
@@ -24,12 +23,9 @@ import static android.support.test.espresso.assertion.ViewAssertions.matches;
 import static android.support.test.espresso.matcher.ViewMatchers.isDisplayed;
 import static android.support.test.espresso.matcher.ViewMatchers.withText;
 import static org.assertj.core.api.Java6Assertions.assertThat;
-import static org.junit.Assume.assumeFalse;
-import static org.junit.Assume.assumeTrue;
 
 @RunWith(AndroidJUnit4.class)
 @SdkSuppress(minSdkVersion = 23)
-@RequiresApi(api = 23)
 public class ApplicationLifecycleTest {
 
     @Rule
@@ -37,11 +33,11 @@ public class ApplicationLifecycleTest {
         @Override
         protected void afterActivityLaunched() {
             super.afterActivityLaunched();
-            registerIdlingResource(rule.getActivity());
+            registerReactIdlingResource(rule.getActivity());
         }
     };
 
-    private void registerIdlingResource(final NavigationActivity activity) {
+    private void registerReactIdlingResource(final NavigationActivity activity) {
         Espresso.registerIdlingResources(new IdlingResource() {
             @Override
             public String getName() {
@@ -91,20 +87,12 @@ public class ApplicationLifecycleTest {
     }
 
     @Test
-    public void startApp_RequiredOverlayPermissions_LoadsBridge_ThenShowsWelcomeScreen() throws Exception {
-        assumeFalse(Settings.canDrawOverlays(getInstrumentation().getContext()));
+    public void acceptsOverlayPermissions_ShowsWelcomeScreen() throws Exception {
         launchActivity();
         acceptOverlayPermissionIfNeeded();
         onView(withText("React Native Navigation!")).check(matches(isDisplayed()));
     }
 
-    @Test
-    public void startApp_NoPermissionRequired_ShowsWelcomeScreen() {
-        assumeTrue(Settings.canDrawOverlays(getInstrumentation().getContext()));
-        launchActivity();
-        onView(withText("React Native Navigation!")).check(matches(isDisplayed()));
-    }
-
     @Test
     public void showsSplashOnStartup() throws Exception {
         launchActivity();

playground/src/containers/WelcomeScreen.js

@@ -19,6 +19,7 @@ class WelcomeScreen extends Component {
         <Button title="Switch to lifecycle screen" onPress={this.onClickLifecycleScreen} />
         <Button title="Push" onPress={this.onClickPush} />
         <Button title="Show Modal" onPress={this.onClickShowModal} />
+        <Button title="Show Redbox" onPress={this.onClickShowRedbox} />
         <Text style={styles.footer}>{`this.props.id = ${this.props.id}`}</Text>
       </View>
     );
@@ -114,6 +115,10 @@ class WelcomeScreen extends Component {
       }
     });
   }
+
+  onClickShowRedbox() {
+    undefined();
+  }
 }
 
 export default WelcomeScreen;