Fix topBar.noBorder option on iOS 13 (#5705)

* Fix topBar.noBorder option on iOS 13

* Fix unit tests

* empty commit

lib/ios/UINavigationBar+utils.h

@@ -8,4 +8,6 @@
 
 - (void)rnn_setBackIndicatorImage:(UIImage *)image;
 
+- (void)rnn_showBorder:(BOOL)showBorder;
+
 @end

lib/ios/UINavigationBar+utils.m

@@ -56,6 +56,17 @@ const NSInteger TOP_BAR_TRANSPARENT_TAG = 78264803;
     }
 }
 
+- (void)rnn_showBorder:(BOOL)showBorder {
+    if (@available(iOS 13.0, *)) {
+        UIColor* shadowColor = showBorder ? [[UINavigationBarAppearance new] shadowColor] : nil;
+        [[self getNavigaitonBarStandardAppearance] setShadowColor:shadowColor];
+        [[self getNavigaitonBarCompactAppearance] setShadowColor:shadowColor];
+        [[self getNavigaitonBarScrollEdgeAppearance] setShadowColor:shadowColor];
+    } else {
+        [self setShadowImage:showBorder ? nil : [UIImage new]];
+    }
+}
+
 - (void)removeTransparentView {
     UIView *transparentView = [self viewWithTag:TOP_BAR_TRANSPARENT_TAG];
     if (transparentView){

lib/ios/UINavigationController+RNNOptions.m

@@ -36,11 +36,7 @@ const NSInteger BLUR_TOPBAR_TAG = 78264802;
 }
 
 - (void)setNavigationBarNoBorder:(BOOL)noBorder {
-	if (noBorder) {
-		[self.navigationBar setShadowImage:[[UIImage alloc] init]];
-	} else {
-		[self.navigationBar setShadowImage:nil];
-	}
+	[self.navigationBar rnn_showBorder:!noBorder];
 }
 
 - (void)setBarStyle:(UIBarStyle)barStyle {

playground/ios/NavigationTests/RNNRootViewControllerTest.m

@@ -461,7 +461,7 @@
 	self.options.topBar.noBorder = [[Bool alloc] initWithValue:topBarNoBorderInput];
 	__unused RNNStackController* nav = [self createNavigationController];
 	[self.uut viewWillAppear:false];
-	XCTAssertNotNil(self.uut.navigationController.navigationBar.shadowImage);
+	XCTAssertNil(self.uut.navigationController.navigationBar.standardAppearance.shadowColor);
 }
 
 -(void)testTopBarNoBorderOff {
@@ -469,7 +469,7 @@
 	self.options.topBar.noBorder = [[Bool alloc] initWithValue:topBarNoBorderInput];
 	__unused RNNStackController* nav = [self createNavigationController];
 	[self.uut viewWillAppear:false];
-	XCTAssertNil(self.uut.navigationController.navigationBar.shadowImage);
+	XCTAssertEqual(self.uut.navigationController.navigationBar.standardAppearance.shadowColor, [UINavigationBarAppearance new].shadowColor);
 }
 
 -(void)testStatusBarBlurOn {