linted

.eslintrc

@@ -302,7 +302,7 @@
     "no-whitespace-before-property": "error",
     "object-curly-spacing": [
       "error",
-      "never"
+      "always"
     ],
     "one-var": 0,
     "one-var-declaration-per-line": 0,
@@ -481,23 +481,6 @@
      *                              react-native plugin
      */
     "react-native/no-unused-styles": "error",
-    "react-native/split-platform-components": "error",
-    /*
-     *                              babel plugin
-     */
-    "babel/new-cap": [
-      "error",
-      {
-        "capIsNewExceptions": [
-          "Immutable"
-        ]
-      }
-    ],
-    "babel/object-curly-spacing": [
-      "error",
-      "never"
-    ],
-    "babel/object-shorthand": 0,
-    "babel/no-await-in-loop": 0
+    "react-native/split-platform-components": "error"
   }
 }

integration/env.test.js

@@ -1,12 +1,12 @@
 describe('test environment', () => {
   it('handles object spread', () => {
-    const {x, y, ...z} = {x: 1, y: 2, a: 3, b: 4};
+    const { x, y, ...z } = { x: 1, y: 2, a: 3, b: 4 };
     expect(x).toEqual(1);
     expect(y).toEqual(2);
-    expect(z).toEqual({a: 3, b: 4});
+    expect(z).toEqual({ a: 3, b: 4 });
   });
 
-  it('handles async await', async() => {
+  it('handles async await', async () => {
     const result = await new Promise((r) => r('hello'));
     expect(result).toEqual('hello');
   });

integration/remx/component.js

@@ -1,9 +1,9 @@
-import {Text} from 'react-native';
-import React, {Component} from 'react';
+import { Text } from 'react-native';
+import React, { Component } from 'react';
 
-import {connect} from 'remx/react-native';
+import { connect } from 'remx/react-native';
 
-import {selectors} from './store';
+import { selectors } from './store';
 
 class MyContainer extends Component {
   constructor(props) {

integration/remx/store.js

@@ -13,7 +13,7 @@ export const mutators = remx.setters({
   },
 
   setAge(age) {
-    state.merge({person: {age}});
+    state.merge({ person: { age } });
   }
 });
 

jsconfig.json

@@ -1,9 +1,14 @@
 {
     "compilerOptions": {
         "allowJs": true,
-        "allowSyntheticDefaultImports": true
+        "allowSyntheticDefaultImports": true,
+        "target": "ES6"
     },
     "exclude": [
-        "node_modules"
-    ]
-}
+        "node_modules",
+        "playground/node_modules"
+    ],
+    "react-native-tools": {
+        "projectRoot": "./"
+    }
+}

package.json

@@ -26,7 +26,7 @@
   "main": "src/index.js",
   "scripts": {
     "build": ":",
-    "lint": "eslint src",
+    "lint": "eslint src integration scripts playground/src playground/e2e playground/scripts",
     "test-js": "BABEL_ENV=test jest --coverage",
     "test-android": "node ./scripts/test.android.js",
     "test-ios": "node ./scripts/test.ios.js",

playground/e2e/app.test.js

@@ -7,7 +7,7 @@ describe('app', () => {
     expect(elementByLabel('React Native Navigation!')).toBeVisible();
   });
 
-  xit('switch to tab based app', () => {
+  it('switch to tab based app', () => {
     elementByLabel('Switch to tab based app').tap();
     expect(elementByLabel('This is a tab screen')).toBeVisible();
   });

playground/e2e/init.js

@@ -5,15 +5,15 @@ const detoxConfig = require('../package.json').detox;
 
 detoxConfig['ios-simulator'].app = process.env.detoxAppBuildPath;
 
-before(function(done) {
+before(function (done) {
   detox.config(detoxConfig);
   detox.start(done);
 });
 
-afterEach(function(done) {
+afterEach(function (done) {
   detox.waitForTestResult(done);
 });
 
-after(function(done) {
+after(function (done) {
   detox.cleanup(done);
 });

playground/src/app.js

@@ -1,6 +1,6 @@
 import Navigation from 'react-native-navigation';
 
-import {registerContainers} from './containers';
+import { registerContainers } from './containers';
 
 export function start() {
   registerContainers();

playground/src/containers/SimpleTabScreen.js

@@ -1,5 +1,5 @@
-import React, {Component} from 'react';
-import {View, Text} from 'react-native';
+import React, { Component } from 'react';
+import { View, Text } from 'react-native';
 
 export default class SimpleTabScreen extends Component {
   render() {

playground/src/containers/WelcomeScreen.js

@@ -1,11 +1,14 @@
-import React, {Component} from 'react';
-import {View, Text} from 'react-native';
+import React, { Component } from 'react';
+import { View, Text, Button } from 'react-native';
 
 export default class WelcomeScreen extends Component {
   render() {
     return (
       <View style={styles.root}>
         <Text style={styles.h1}>{`React Native Navigation!`}</Text>
+        <Button>
+          <Text style={styles.h1}>{`Switch to tab based app`}</Text>
+        </Button>
       </View>
     );
   }

playground/src/index.js

@@ -1,3 +1,3 @@
-import {start} from './app';
+import { start } from './app';
 
 start();

scripts/release.js

@@ -1,3 +1,4 @@
+/*eslint-disable no-console*/
 const shellUtils = require('shell-utils');
 const p = require('path');
 const semver = require('semver');

src/adapters/NativeCommandsSender.js

@@ -1,4 +1,4 @@
-import {NativeModules} from 'react-native';
+import { NativeModules } from 'react-native';
 
 export default class NativeCommandsSender {
   constructor() {

src/adapters/NativeEventsReceiver.js

@@ -1,4 +1,4 @@
-import {NativeModules, NativeEventEmitter} from 'react-native';
+import { NativeModules, NativeEventEmitter } from 'react-native';
 
 export default class NativeEventsReceiver {
   constructor() {

src/adapters/NativeEventsReceiver.test.js

@@ -1,6 +1,6 @@
 describe('NativeEventsReceiver', () => {
   let uut;
-  const eventEmitterMock = {addListener: jest.fn()};
+  const eventEmitterMock = { addListener: jest.fn() };
 
   beforeEach(() => {
     require('react-native').NativeModules.RNNEventEmitter = {};

src/commands/LayoutTreeParser.test.js

@@ -4,7 +4,7 @@ describe('LayoutTreeParser', () => {
   let uut;
 
   beforeEach(() => {
-    const uniqueIdProvider = {generate: (prefix) => `${prefix}+UNIQUE_ID`};
+    const uniqueIdProvider = { generate: (prefix) => `${prefix}+UNIQUE_ID` };
     const LayoutTreeParser = require('./LayoutTreeParser').default;
     uut = new LayoutTreeParser(uniqueIdProvider);
   });
@@ -108,8 +108,8 @@ describe('LayoutTreeParser', () => {
   });
 
   xit('adds uniqueId to containers', () => {
-    const input = {container: {}};
-    expect(uut.parse(input)).toEqual({container: {id: 'Container+UNIQUE_ID'}});
+    const input = { container: {} };
+    expect(uut.parse(input)).toEqual({ container: { id: 'Container+UNIQUE_ID' } });
   });
 
   xit('parses side menus', () => {

src/containers/ContainerRegistry.js

@@ -1,4 +1,4 @@
-import {AppRegistry} from 'react-native';
+import { AppRegistry } from 'react-native';
 import ContainerWrapper from './ContainerWrapper';
 
 export default class ContainerRegistry {

src/containers/ContainerRegistry.test.js

@@ -1,5 +1,5 @@
-import React, {Component} from 'react';
-import {AppRegistry, Text} from 'react-native';
+import React, { Component } from 'react';
+import { AppRegistry, Text } from 'react-native';
 import renderer from 'react-test-renderer';
 
 describe('ContainerRegistry', () => {
@@ -28,7 +28,7 @@ describe('ContainerRegistry', () => {
   it('resulting in a normal component', () => {
     uut.registerContainer('example.MyContainer.name', () => MyContainer);
     const Container = AppRegistry.registerComponent.mock.calls[0][1]();
-    const tree = renderer.create(<Container containerId="123"/>);
+    const tree = renderer.create(<Container containerId="123" />);
     expect(tree.toJSON().children).toEqual(['Hello, World!']);
   });
 });

src/containers/ContainerWrapper.js

@@ -1,4 +1,4 @@
-import React, {Component} from 'react';
+import React, { Component } from 'react';
 
 export default class ContainerWrapper {
   static wrap(containerName, OriginalContainer, propStore) {
@@ -10,13 +10,13 @@ export default class ContainerWrapper {
         }
         this.state = {
           containerId: props.containerId,
-          allProps: {...props, ...propStore.getPropsForContainerId(props.containerId)}
+          allProps: { ...props, ...propStore.getPropsForContainerId(props.containerId) }
         };
       }
 
       componentWillReceiveProps(nextProps) {
         this.setState({
-          allProps: {...nextProps, ...propStore.getPropsForContainerId(this.state.containerId)}
+          allProps: { ...nextProps, ...propStore.getPropsForContainerId(this.state.containerId) }
         });
       }
 

src/containers/ContainerWrapper.test.js

@@ -1,5 +1,5 @@
-import React, {Component} from 'react';
-import {AppRegistry, Text} from 'react-native';
+import React, { Component } from 'react';
+import { AppRegistry, Text } from 'react-native';
 import renderer from 'react-test-renderer';
 
 describe('ContainerWrapper', () => {
@@ -25,13 +25,13 @@ describe('ContainerWrapper', () => {
       super(props);
       testParentRef = this; //eslint-disable-line
       this.ChildClass = props.ChildClass;
-      this.state = {propsFromState: {}};
+      this.state = { propsFromState: {} };
     }
 
     render() {
       const Child = this.ChildClass;
       return (
-        <Child containerId="container1" {...this.state.propsFromState}/>
+        <Child containerId="container1" {...this.state.propsFromState} />
       );
     }
   }
@@ -45,55 +45,55 @@ describe('ContainerWrapper', () => {
   it('must have containerId as prop', () => {
     const NavigationContainer = ContainerWrapper.wrap(containerName, MyContainer, store);
     expect(() => {
-      renderer.create(<NavigationContainer/>);
+      renderer.create(<NavigationContainer />);
     }).toThrow(new Error('Container example.MyContainer does not have a containerId!'));
   });
 
   it('wraps the container and saves to store', () => {
     const NavigationContainer = ContainerWrapper.wrap(containerName, MyContainer, store);
     expect(NavigationContainer).not.toBeInstanceOf(MyContainer);
-    const tree = renderer.create(<NavigationContainer containerId={'container1'}/>);
+    const tree = renderer.create(<NavigationContainer containerId={'container1'} />);
     expect(tree.toJSON().children).toEqual(['Hello, World!']);
     expect(myContainerRef).toBeInstanceOf(MyContainer);
   });
 
   it('injects props from wrapper into original container', () => {
     const NavigationContainer = ContainerWrapper.wrap(containerName, MyContainer, store);
-    renderer.create(<NavigationContainer containerId={'container1'} myProp={'yo'}/>);
+    renderer.create(<NavigationContainer containerId={'container1'} myProp={'yo'} />);
     expect(myContainerRef.props.myProp).toEqual('yo');
   });
 
   it('updates props from wrapper into original container', () => {
     const NavigationContainer = ContainerWrapper.wrap(containerName, MyContainer, store);
-    renderer.create(<TestParent ChildClass={NavigationContainer}/>);
+    renderer.create(<TestParent ChildClass={NavigationContainer} />);
     expect(myContainerRef.props.foo).toEqual(undefined);
-    testParentRef.setState({propsFromState: {foo: 'yo'}});
+    testParentRef.setState({ propsFromState: { foo: 'yo' } });
     expect(myContainerRef.props.foo).toEqual('yo');
   });
 
   it('pulls props from the store and injects them into the inner container', () => {
-    store.setPropsForContainerId('container123', {numberProp: 1, stringProp: 'hello', objectProp: {a: 2}});
+    store.setPropsForContainerId('container123', { numberProp: 1, stringProp: 'hello', objectProp: { a: 2 } });
     const NavigationContainer = ContainerWrapper.wrap(containerName, MyContainer, store);
-    renderer.create(<NavigationContainer containerId={'container123'}/>);
-    expect(myContainerRef.props).toEqual({containerId: 'container123', numberProp: 1, stringProp: 'hello', objectProp: {a: 2}});
+    renderer.create(<NavigationContainer containerId={'container123'} />);
+    expect(myContainerRef.props).toEqual({ containerId: 'container123', numberProp: 1, stringProp: 'hello', objectProp: { a: 2 } });
   });
 
   it('updates props from store into inner container', () => {
     const NavigationContainer = ContainerWrapper.wrap(containerName, MyContainer, store);
-    renderer.create(<TestParent ChildClass={NavigationContainer}/>);
-    store.setPropsForContainerId('container1', {myProp: 'hello'});
+    renderer.create(<TestParent ChildClass={NavigationContainer} />);
+    store.setPropsForContainerId('container1', { myProp: 'hello' });
     expect(myContainerRef.props.foo).toEqual(undefined);
     expect(myContainerRef.props.myProp).toEqual(undefined);
-    testParentRef.setState({propsFromState: {foo: 'yo'}});
+    testParentRef.setState({ propsFromState: { foo: 'yo' } });
     expect(myContainerRef.props.foo).toEqual('yo');
     expect(myContainerRef.props.myProp).toEqual('hello');
   });
 
   it('protects containerId from change', () => {
     const NavigationContainer = ContainerWrapper.wrap(containerName, MyContainer, store);
-    renderer.create(<TestParent ChildClass={NavigationContainer}/>);
+    renderer.create(<TestParent ChildClass={NavigationContainer} />);
     expect(myContainerRef.props.containerId).toEqual('container1');
-    testParentRef.setState({propsFromState: {containerId: 'ERROR'}});
+    testParentRef.setState({ propsFromState: { containerId: 'ERROR' } });
     expect(myContainerRef.props.containerId).toEqual('container1');
   });
 });

src/containers/Store.test.js

@@ -11,8 +11,8 @@ describe('Store', () => {
   });
 
   it('holds props by containerId', () => {
-    uut.setPropsForContainerId('container1', {a: 1, b: 2});
-    expect(uut.getPropsForContainerId('container1')).toEqual({a: 1, b: 2});
+    uut.setPropsForContainerId('container1', { a: 1, b: 2 });
+    expect(uut.getPropsForContainerId('container1')).toEqual({ a: 1, b: 2 });
   });
 
   it('defensive for invalid containerId and props', () => {

src/index.test.js

@@ -1,11 +1,11 @@
-jest.mock('./Navigation', () => ({startApp: () => 'import'}));
+jest.mock('./Navigation', () => ({ startApp: () => 'import' }));
 import Navigation from './index';
 
 describe('index', () => {
   let uut;
 
   beforeEach(() => {
-    jest.mock('./Navigation', () => ({startApp: () => 'require'}));
+    jest.mock('./Navigation', () => ({ startApp: () => 'require' }));
     uut = require('./index');
   });