Browse Source

Fix modalpresentationstyle (#6077)

* Fix invalid popover enum value for modal presentation style

The correct enum value as defined in lib/ios/RNNConvert.m is "popover" not "popOver", in line with UIModalPresentationPopover.

* Add to documentation on modal presentation styles

Add popover value and link to iOS documentation.

Co-authored-by: Yogev Ben David <yogev132@gmail.com>
rfnd 4 years ago
parent
commit
951a07bb55
No account linked to committer's email address

+ 1
- 1
docs/api/OptionsModalPresentationStyle.md View File

@@ -7,4 +7,4 @@
7 7
 - overCurrentContext
8 8
 - overFullScreen
9 9
 - pageSheet
10
-- popOver
10
+- popover

+ 4
- 1
docs/docs/options-migration.md View File

@@ -374,11 +374,14 @@ topBar: {
374 374
 Controls the behavior of screens displayed modally. 
375 375
 
376 376
 ### Options supported on iOS
377
-* overCurrentContext - Content is displayed over the previous screen. Useful for **transparent modals**
377
+* `overCurrentContext` - Content is displayed over the previous screen. Useful for **transparent modals**
378 378
 * `formSheet` - Content is centered in the screen
379 379
 * `pageSheet` -Content partially covers the underlying content
380 380
 * `overFullScreen` - Content covers the screen, without detaching previous content.
381 381
 * `fullScreen` - Content covers the screen, previous content is detached.
382
+* `popover` - Content is displayed in a popover view.
383
+
384
+More information on the different styles for iOS can be found on https://developer.apple.com/documentation/uikit/uimodalpresentationstyle
382 385
 
383 386
 ### Options supported on Android
384 387
 * `overCurrentContext` - Content is displayed over the previous screen. Useful for **transparent modals**

+ 1
- 1
lib/src/interfaces/Options.ts View File

@@ -119,7 +119,7 @@ export enum OptionsModalPresentationStyle {
119 119
   overFullScreen = 'overFullScreen',
120 120
   overCurrentContext = 'overCurrentContext',
121 121
   currentContext = 'currentContext',
122
-  popOver = 'popOver',
122
+  popover = 'popover',
123 123
   fullScreen = 'fullScreen',
124 124
   none = 'none'
125 125
 }