Don’t warn when a navigationButtonPress event was not handled by a component

The motivation behind this feature was to warn when a user declared a button but forgot register
a handler in a component to handle button press event.
Since buttons can be handled globally using Navigation.events().registerNavigationButtonPressedListener, this feature
is meaningless.
closes #4017

lib/src/events/ComponentEventsObserver.test.tsx

@@ -5,7 +5,7 @@ import { NativeEventsReceiver } from '../adapters/NativeEventsReceiver.mock';
 
 describe('ComponentEventsObserver', () => {
   const mockEventsReceiver = new NativeEventsReceiver();
-  let uut;
+  const uut = new ComponentEventsObserver(mockEventsReceiver);
   const didAppearFn = jest.fn();
   const didDisappearFn = jest.fn();
   const didMountFn = jest.fn();
@@ -70,10 +70,6 @@ describe('ComponentEventsObserver', () => {
     }
   }
 
-  beforeEach(() => {
-    uut = new ComponentEventsObserver(mockEventsReceiver);
-  });
-
   it(`bindComponent expects a component with componentId`, () => {
     const tree = renderer.create(<SimpleScreen />);
     expect(() => uut.bindComponent(tree.getInstance() as any)).toThrow('');
@@ -202,29 +198,4 @@ describe('ComponentEventsObserver', () => {
     expect(mockEventsReceiver.registerSearchBarCancelPressedListener).toHaveBeenCalledTimes(1);
     expect(mockEventsReceiver.registerPreviewCompletedListener).toHaveBeenCalledTimes(1);
   });
-
-  it(`warn when button event is not getting handled`, () => {
-    const tree1 = renderer.create(<SimpleScreen componentId={'myCompId'} />);
-    const instance1 = tree1.getInstance() as any;
-    console.warn = jest.fn();
-    uut.bindComponent(instance1);
-
-    uut.notifyNavigationButtonPressed({ componentId: 'myCompId', buttonId: 'myButtonId' });
-
-    expect(console.warn).toHaveBeenCalledTimes(1);
-    expect(console.warn).toHaveBeenCalledWith(`navigationButtonPressed for button 'myButtonId' was not handled`);
-  });
-
-  it(`doesn't warn when button event is getting handled`, () => {
-    const tree1 = renderer.create(<SimpleScreen componentId={'myCompId'} />);
-    const instance1 = tree1.getInstance() as any;
-    console.warn = jest.fn();
-    
-    instance1.navigationButtonPressed = jest.fn();
-    uut.bindComponent(instance1);
-
-    uut.notifyNavigationButtonPressed({ componentId: 'myCompId', buttonId: 'myButtonId' });
-
-    expect(console.warn).toHaveBeenCalledTimes(0);
-  });
 });

lib/src/events/ComponentEventsObserver.ts

@@ -65,11 +65,7 @@ export class ComponentEventsObserver {
   }
 
   notifyNavigationButtonPressed(event: NavigationButtonPressedEvent) {
-    const listenersTriggered = this.triggerOnAllListenersByComponentId(event, 'navigationButtonPressed');
-    if (listenersTriggered === 0) {
-      // tslint:disable-next-line:no-console
-      console.warn(`navigationButtonPressed for button '${event.buttonId}' was not handled`);
-    }
+    this.triggerOnAllListenersByComponentId(event, 'navigationButtonPressed');
   }
 
   notifyModalDismissed(event: ModalDismissedEvent) {
@@ -89,14 +85,10 @@ export class ComponentEventsObserver {
   }
 
   private triggerOnAllListenersByComponentId(event: ComponentEvent, method: string) {
-    let listenersTriggered = 0;
     _.forEach(this.listeners[event.componentId], (component) => {
       if (_.isObject(component) && _.isFunction(component[method])) {
         component[method](event);
-        listenersTriggered++;
       }
     });
-
-    return listenersTriggered;
   }
 }