Browse Source

Rename Modal classes

Remove temporary suffixes
Guy Carmeli 6 years ago
parent
commit
9d8f9934a6

lib/android/app/src/main/java/com/reactnativenavigation/anim/ModalAnimator2.java → lib/android/app/src/main/java/com/reactnativenavigation/anim/ModalAnimator.java View File

8
 
8
 
9
 import com.reactnativenavigation.parse.AnimationOptions;
9
 import com.reactnativenavigation.parse.AnimationOptions;
10
 
10
 
11
-public class ModalAnimator2 extends BaseAnimator {
11
+public class ModalAnimator extends BaseAnimator {
12
 
12
 
13
     private Animator animator;
13
     private Animator animator;
14
 
14
 
15
-    public ModalAnimator2(Context context) {
15
+    public ModalAnimator(Context context) {
16
         super(context);
16
         super(context);
17
     }
17
     }
18
 
18
 

+ 4
- 5
lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/Navigator.java View File

9
 import android.widget.FrameLayout;
9
 import android.widget.FrameLayout;
10
 
10
 
11
 import com.facebook.react.bridge.Promise;
11
 import com.facebook.react.bridge.Promise;
12
-import com.reactnativenavigation.anim.ModalAnimator2;
12
+import com.reactnativenavigation.anim.ModalAnimator;
13
 import com.reactnativenavigation.anim.NavigationAnimator;
13
 import com.reactnativenavigation.anim.NavigationAnimator;
14
 import com.reactnativenavigation.parse.Options;
14
 import com.reactnativenavigation.parse.Options;
15
 import com.reactnativenavigation.presentation.NavigationOptionsListener;
15
 import com.reactnativenavigation.presentation.NavigationOptionsListener;
17
 import com.reactnativenavigation.utils.CommandListenerAdapter;
17
 import com.reactnativenavigation.utils.CommandListenerAdapter;
18
 import com.reactnativenavigation.utils.CompatUtils;
18
 import com.reactnativenavigation.utils.CompatUtils;
19
 import com.reactnativenavigation.viewcontrollers.modal.ModalPresenter;
19
 import com.reactnativenavigation.viewcontrollers.modal.ModalPresenter;
20
-import com.reactnativenavigation.viewcontrollers.modal.ModalStack2;
20
+import com.reactnativenavigation.viewcontrollers.modal.ModalStack;
21
 
21
 
22
 import java.util.Collection;
22
 import java.util.Collection;
23
 import java.util.Collections;
23
 import java.util.Collections;
30
         void onError(String message);
30
         void onError(String message);
31
     }
31
     }
32
 
32
 
33
-    private final ModalStack2 modalStack;
33
+    private final ModalStack modalStack;
34
     private ViewController root;
34
     private ViewController root;
35
     private FrameLayout rootLayout;
35
     private FrameLayout rootLayout;
36
     private FrameLayout contentLayout;
36
     private FrameLayout contentLayout;
39
 
39
 
40
     public Navigator(final Activity activity) {
40
     public Navigator(final Activity activity) {
41
         super(activity, "navigator" + CompatUtils.generateViewId(), new Options());
41
         super(activity, "navigator" + CompatUtils.generateViewId(), new Options());
42
-        modalStack = new ModalStack2(new ModalPresenter(new ModalAnimator2(activity)));
42
+        modalStack = new ModalStack(new ModalPresenter(new ModalAnimator(activity)));
43
     }
43
     }
44
 
44
 
45
     public FrameLayout getContentLayout() {
45
     public FrameLayout getContentLayout() {
87
         }
87
         }
88
 
88
 
89
         root = viewController;
89
         root = viewController;
90
-
91
         contentLayout.addView(viewController.getView());
90
         contentLayout.addView(viewController.getView());
92
         if (viewController.options.animations.startApp.hasValue()) {
91
         if (viewController.options.animations.startApp.hasValue()) {
93
             new NavigationAnimator(viewController.getActivity(), viewController.options.animations)
92
             new NavigationAnimator(viewController.getActivity(), viewController.options.animations)

+ 3
- 3
lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/modal/ModalPresenter.java View File

4
 import android.animation.AnimatorListenerAdapter;
4
 import android.animation.AnimatorListenerAdapter;
5
 import android.view.ViewGroup;
5
 import android.view.ViewGroup;
6
 
6
 
7
-import com.reactnativenavigation.anim.ModalAnimator2;
7
+import com.reactnativenavigation.anim.ModalAnimator;
8
 import com.reactnativenavigation.viewcontrollers.Navigator.CommandListener;
8
 import com.reactnativenavigation.viewcontrollers.Navigator.CommandListener;
9
 import com.reactnativenavigation.viewcontrollers.ViewController;
9
 import com.reactnativenavigation.viewcontrollers.ViewController;
10
 
10
 
13
 public class ModalPresenter {
13
 public class ModalPresenter {
14
 
14
 
15
     private ViewGroup content;
15
     private ViewGroup content;
16
-    private ModalAnimator2 animator;
16
+    private ModalAnimator animator;
17
 
17
 
18
-    public ModalPresenter(ModalAnimator2 animator) {
18
+    public ModalPresenter(ModalAnimator animator) {
19
         this.animator = animator;
19
         this.animator = animator;
20
     }
20
     }
21
 
21
 

lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/modal/ModalStack2.java → lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/modal/ModalStack.java View File

11
 
11
 
12
 import javax.annotation.Nullable;
12
 import javax.annotation.Nullable;
13
 
13
 
14
-public class ModalStack2 {
14
+public class ModalStack {
15
     private List<ViewController> modals = new ArrayList<>();
15
     private List<ViewController> modals = new ArrayList<>();
16
     private final ModalPresenter presenter;
16
     private final ModalPresenter presenter;
17
 
17
 
18
-    public ModalStack2(ModalPresenter presenter) {
18
+    public ModalStack(ModalPresenter presenter) {
19
         this.presenter = presenter;
19
         this.presenter = presenter;
20
     }
20
     }
21
 
21
 

+ 2
- 2
lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/modal/ModalAnimatorMock.java View File

4
 import android.content.Context;
4
 import android.content.Context;
5
 import android.view.View;
5
 import android.view.View;
6
 
6
 
7
-import com.reactnativenavigation.anim.ModalAnimator2;
7
+import com.reactnativenavigation.anim.ModalAnimator;
8
 import com.reactnativenavigation.parse.AnimationOptions;
8
 import com.reactnativenavigation.parse.AnimationOptions;
9
 
9
 
10
-public class ModalAnimatorMock extends ModalAnimator2 {
10
+public class ModalAnimatorMock extends ModalAnimator {
11
 
11
 
12
     ModalAnimatorMock(Context context) {
12
     ModalAnimatorMock(Context context) {
13
         super(context);
13
         super(context);

+ 3
- 3
lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/modal/ModalPresenterTest.java View File

4
 import android.widget.FrameLayout;
4
 import android.widget.FrameLayout;
5
 
5
 
6
 import com.reactnativenavigation.BaseTest;
6
 import com.reactnativenavigation.BaseTest;
7
-import com.reactnativenavigation.anim.ModalAnimator2;
7
+import com.reactnativenavigation.anim.ModalAnimator;
8
 import com.reactnativenavigation.mocks.SimpleViewController;
8
 import com.reactnativenavigation.mocks.SimpleViewController;
9
 import com.reactnativenavigation.parse.Options;
9
 import com.reactnativenavigation.parse.Options;
10
 import com.reactnativenavigation.utils.CommandListenerAdapter;
10
 import com.reactnativenavigation.utils.CommandListenerAdapter;
28
     private ViewController modal2;
28
     private ViewController modal2;
29
     private ModalPresenter uut;
29
     private ModalPresenter uut;
30
     private FrameLayout contentLayout;
30
     private FrameLayout contentLayout;
31
-    private ModalAnimator2 animator;
31
+    private ModalAnimator animator;
32
 
32
 
33
     @Override
33
     @Override
34
     public void beforeEach() {
34
     public void beforeEach() {
35
         Activity activity = newActivity();
35
         Activity activity = newActivity();
36
-        animator = spy(new ModalAnimator2(activity));
36
+        animator = spy(new ModalAnimator(activity));
37
         uut = new ModalPresenter(animator);
37
         uut = new ModalPresenter(animator);
38
         contentLayout = new FrameLayout(activity);
38
         contentLayout = new FrameLayout(activity);
39
         activity.setContentView(contentLayout);
39
         activity.setContentView(contentLayout);

+ 4
- 4
lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/modal/ModalStackTest2.java View File

5
 import android.widget.FrameLayout;
5
 import android.widget.FrameLayout;
6
 
6
 
7
 import com.reactnativenavigation.BaseTest;
7
 import com.reactnativenavigation.BaseTest;
8
-import com.reactnativenavigation.anim.ModalAnimator2;
8
+import com.reactnativenavigation.anim.ModalAnimator;
9
 import com.reactnativenavigation.mocks.SimpleViewController;
9
 import com.reactnativenavigation.mocks.SimpleViewController;
10
 import com.reactnativenavigation.parse.Options;
10
 import com.reactnativenavigation.parse.Options;
11
 import com.reactnativenavigation.utils.CommandListenerAdapter;
11
 import com.reactnativenavigation.utils.CommandListenerAdapter;
31
     private static final String MODAL_ID_2 = "modalId2";
31
     private static final String MODAL_ID_2 = "modalId2";
32
     private static final String MODAL_ID_3 = "modalId3";
32
     private static final String MODAL_ID_3 = "modalId3";
33
 
33
 
34
-    private ModalStack2 uut;
34
+    private ModalStack uut;
35
     private ViewController modal1;
35
     private ViewController modal1;
36
     private ViewController modal2;
36
     private ViewController modal2;
37
     private ViewController modal3;
37
     private ViewController modal3;
38
     private Activity activity;
38
     private Activity activity;
39
     private ModalPresenter presenter;
39
     private ModalPresenter presenter;
40
-    private ModalAnimator2 animator;
40
+    private ModalAnimator animator;
41
 
41
 
42
     @Override
42
     @Override
43
     public void beforeEach() {
43
     public void beforeEach() {
46
         activity.setContentView(root);
46
         activity.setContentView(root);
47
         animator = spy(new ModalAnimatorMock(activity));
47
         animator = spy(new ModalAnimatorMock(activity));
48
         presenter = spy(new ModalPresenter(animator));
48
         presenter = spy(new ModalPresenter(animator));
49
-        uut = new ModalStack2(presenter);
49
+        uut = new ModalStack(presenter);
50
         uut.setContentLayout(root);
50
         uut.setContentLayout(root);
51
         modal1 = spy(new SimpleViewController(activity, MODAL_ID_1, new Options()));
51
         modal1 = spy(new SimpleViewController(activity, MODAL_ID_1, new Options()));
52
         modal2 = spy(new SimpleViewController(activity, MODAL_ID_2, new Options()));
52
         modal2 = spy(new SimpleViewController(activity, MODAL_ID_2, new Options()));