removed unnecessary duct tape tests

lib/src/Navigation.test.js

@@ -1,111 +0,0 @@
-describe('Navigation', () => {
-  let Navigation;
-
-  beforeEach(() => {
-    //TODO don't mock here, just create the actual object and assert on basic behavior
-    jest.mock('./adapters/UniqueIdProvider');
-    jest.mock('./adapters/NativeCommandsSender');
-    jest.mock('./adapters/NativeEventsReceiver');
-
-    jest.mock('./containers/ContainerRegistry');
-    jest.mock('./commands/Commands');
-
-    Navigation = require('./Navigation').default;
-  });
-
-  it('registerContainer delegates to ContainerRegistry', () => {
-    expect(Navigation.containerRegistry.registerContainer).not.toHaveBeenCalled();
-    const fn = jest.fn();
-    Navigation.registerContainer('name', fn);
-    expect(Navigation.containerRegistry.registerContainer).toHaveBeenCalledTimes(1);
-    expect(Navigation.containerRegistry.registerContainer).toHaveBeenCalledWith('name', fn);
-  });
-
-  it('setRoot delegates to Commands', async () => {
-    Navigation.commands.setRoot.mockReturnValue(Promise.resolve('result'));
-    const params = {};
-    const result = await Navigation.setRoot(params);
-    expect(result).toEqual('result');
-    expect(Navigation.commands.setRoot).toHaveBeenCalledTimes(1);
-    expect(Navigation.commands.setRoot).toHaveBeenCalledWith(params);
-  });
-
-  it('setOptions delegates to Commands', async () => {
-    const theContainerId = "7";
-    const params = { title: "T" };
-    Navigation.setOptions(theContainerId, params);
-    expect(Navigation.commands.setOptions).toHaveBeenCalledTimes(1);
-    expect(Navigation.commands.setOptions).toHaveBeenCalledWith(theContainerId, params);
-  });
-
-  it('showModal delegates to Commands', async () => {
-    Navigation.commands.showModal.mockReturnValue(Promise.resolve('result'));
-    const params = {};
-    const result = await Navigation.showModal(params);
-    expect(result).toEqual('result');
-    expect(Navigation.commands.showModal).toHaveBeenCalledWith(params);
-    expect(Navigation.commands.showModal).toHaveBeenCalledTimes(1);
-  });
-
-  it('dismissModal delegates to Commands', async () => {
-    Navigation.commands.dismissModal.mockReturnValue(Promise.resolve('result'));
-    const params = {};
-    const result = await Navigation.dismissModal(params);
-    expect(result).toEqual('result');
-    expect(Navigation.commands.dismissModal).toHaveBeenCalledTimes(1);
-    expect(Navigation.commands.dismissModal).toHaveBeenCalledWith(params);
-  });
-
-  it('dismissAllModals', async () => {
-    Navigation.commands.dismissAllModals.mockReturnValue(Promise.resolve('result'));
-    const result = await Navigation.dismissAllModals();
-    expect(Navigation.commands.dismissAllModals).toHaveBeenCalledTimes(1);
-    expect(result).toEqual('result');
-  });
-
-  it('events return public events', () => {
-    const cb = jest.fn();
-    Navigation.events().onAppLaunched(cb);
-    expect(Navigation.nativeEventsReceiver.appLaunched).toHaveBeenCalledTimes(1);
-    expect(Navigation.nativeEventsReceiver.appLaunched).toHaveBeenCalledWith(cb);
-  });
-
-  it('starts listening and handles internal events', () => {
-    expect(Navigation.nativeEventsReceiver.containerStart).toHaveBeenCalledTimes(1);
-  });
-
-  it('push delegates to commands', async () => {
-    Navigation.commands.push.mockReturnValue(Promise.resolve('result'));
-    const params = {};
-    const result = await Navigation.push('theContainerId', params);
-    expect(result).toEqual('result');
-    expect(Navigation.commands.push).toHaveBeenCalledWith('theContainerId', params);
-    expect(Navigation.commands.push).toHaveBeenCalledTimes(1);
-  });
-
-  it('pop delegates to commands', async () => {
-    Navigation.commands.pop.mockReturnValue(Promise.resolve('result'));
-    const result = await Navigation.pop('theContainerId');
-    expect(result).toEqual('result');
-    expect(Navigation.commands.pop).toHaveBeenCalledWith('theContainerId');
-    expect(Navigation.commands.pop).toHaveBeenCalledTimes(1);
-  });
-
-  it('popTo delegates to commands', async () => {
-    Navigation.commands.popTo.mockReturnValue(Promise.resolve('result'));
-    const params = {};
-    const result = await Navigation.popTo('theContainerId');
-    expect(result).toEqual('result');
-    expect(Navigation.commands.popTo).toHaveBeenCalledWith('theContainerId');
-    expect(Navigation.commands.popTo).toHaveBeenCalledTimes(1);
-  });
-
-  it('popToRoot delegates to commands', async () => {
-    Navigation.commands.popToRoot.mockReturnValue(Promise.resolve('result'));
-    const params = {};
-    const result = await Navigation.popToRoot('theContainerId');
-    expect(result).toEqual('result');
-    expect(Navigation.commands.popToRoot).toHaveBeenCalledWith('theContainerId');
-    expect(Navigation.commands.popToRoot).toHaveBeenCalledTimes(1);
-  });
-});

lib/src/adapters/NativeCommandsSender.test.js

@@ -1,80 +0,0 @@
-import { NativeModules } from 'react-native';
-import NativeCommandsSender from './NativeCommandsSender';
-
-describe('NativeCommandsSender', () => {
-  let uut, mockNativeModule;
-
-  beforeEach(() => {
-    mockNativeModule = {
-      setRoot: jest.fn(),
-      setOptions: jest.fn(),
-      push: jest.fn(),
-      pop: jest.fn(),
-      popTo: jest.fn(),
-      popToRoot: jest.fn(),
-      showModal: jest.fn(),
-      dismissModal: jest.fn(),
-      dismissAllModals: jest.fn()
-    };
-    NativeModules.RNNBridgeModule = mockNativeModule;
-    uut = new NativeCommandsSender();
-  });
-
-  it('delegates to native', () => {
-    uut.setRoot();
-    expect(mockNativeModule.setRoot).toHaveBeenCalledTimes(1);
-  });
-
-  it('returns promise with resolved layout', async () => {
-    const result = await uut.setRoot({});
-    expect(result).toBeDefined();
-  });
-
-  it('setOptions sends to native with containerId and params', () => {
-    uut.setOptions('theContainerId', { title: "Title" });
-    expect(mockNativeModule.setOptions).toHaveBeenCalledTimes(1);
-  });
-
-  it('push sends to native and resolves with promise', async () => {
-    const theNewContainer = {};
-    const result = await uut.push('theContainerId', theNewContainer);
-    expect(mockNativeModule.push).toHaveBeenCalledTimes(1);
-    expect(result).toBeDefined();
-  });
-
-  it('pop sends to native with containerId', async () => {
-    const result = await uut.pop('theContainerId');
-    expect(mockNativeModule.pop).toHaveBeenCalledTimes(1);
-    expect(result).toBeDefined();
-  });
-
-  it('popTo sends to native with containerId and targetId', async () => {
-    const result = await uut.popTo('theContainerId', 'targetId');
-    expect(mockNativeModule.popTo).toHaveBeenCalledTimes(1);
-    expect(result).toBeDefined();
-  });
-
-  it('popToRoot', async () => {
-    const result = await uut.popToRoot('theContainerId');
-    expect(mockNativeModule.popToRoot).toHaveBeenCalledTimes(1);
-    expect(result).toBeDefined();
-  });
-
-  it('showModal sends to native', async () => {
-    const result = await uut.showModal({});
-    expect(mockNativeModule.showModal).toHaveBeenCalledTimes(1);
-    expect(result).toBeDefined();
-  });
-
-  it('dismissModal', async () => {
-    const result = await uut.dismissModal('id');
-    expect(mockNativeModule.dismissModal).toHaveBeenCalledTimes(1);
-    expect(result).toEqual('id');
-  });
-
-  it('dismissAllModals', async () => {
-    const result = await uut.dismissAllModals();
-    expect(mockNativeModule.dismissAllModals).toHaveBeenCalledTimes(1);
-    expect(result).toBe(true);
-  });
-});

lib/src/adapters/NativeEventsReceiver.test.js

@@ -1,37 +0,0 @@
-import { NativeModules } from 'react-native';
-import NativeEventsReceiver from './NativeEventsReceiver';
-
-describe('NativeEventsReceiver', () => {
-  let uut;
-  const eventEmitterMock = { addListener: jest.fn() };
-
-  beforeEach(() => {
-    NativeModules.RNNEventEmitter = {};
-    uut = new NativeEventsReceiver();
-    uut.emitter = eventEmitterMock;
-  });
-
-  it('register for appLaunched', () => {
-    const callback = jest.fn();
-    uut.appLaunched(callback);
-    expect(callback).not.toHaveBeenCalled();
-    expect(eventEmitterMock.addListener).toHaveBeenCalledTimes(1);
-    expect(eventEmitterMock.addListener).toHaveBeenCalledWith('RNN.appLaunched', callback);
-  });
-
-  it('containerStart', () => {
-    const callback = jest.fn();
-    uut.containerStart(callback);
-    expect(callback).not.toHaveBeenCalled();
-    expect(eventEmitterMock.addListener).toHaveBeenCalledTimes(1);
-    expect(eventEmitterMock.addListener).toHaveBeenCalledWith('RNN.containerStart', callback);
-  });
-
-  it('containerStop', () => {
-    const callback = jest.fn();
-    uut.containerStop(callback);
-    expect(callback).not.toHaveBeenCalled();
-    expect(eventEmitterMock.addListener).toHaveBeenCalledTimes(1);
-    expect(eventEmitterMock.addListener).toHaveBeenCalledWith('RNN.containerStop', callback);
-  });
-});

lib/src/adapters/UniqueIdProvider.test.js

@@ -1,21 +0,0 @@
-import UniqueIdProvider from './UniqueIdProvider';
-
-describe('UniqueIdProvider', () => {
-  let uut;
-
-  beforeEach(() => {
-    uut = new UniqueIdProvider();
-  });
-
-  it('provides uniqueId with optional prefix', () => {
-    expect(uut.generate()).toEqual('1');
-    expect(uut.generate()).toEqual('2');
-    expect(uut.generate('prefix')).toEqual('prefix3');
-    expect(uut.generate('prefix')).toEqual('prefix4');
-    expect(uut.generate('other')).toEqual('other5');
-  });
-
-  it('id is unique across instances', () => {
-    expect(uut.generate()).not.toEqual('1');
-  });
-});

lib/src/index.test.js

@@ -1,16 +0,0 @@
-jest.mock('./Navigation', () => ({ startApp: () => 'import' }));
-import Navigation from './index';
-
-describe('index', () => {
-  let uut;
-
-  beforeEach(() => {
-    jest.mock('./Navigation', () => ({ startApp: () => 'require' }));
-    uut = require('./index');
-  });
-
-  it('exposes Navigation', () => {
-    expect(uut.startApp()).toEqual('require');
-    expect(Navigation.startApp()).toEqual('import');
-  });
-});

package.json

@@ -87,6 +87,13 @@
       "<rootDir>/lib/src/",
       "<rootDir>/integration/"
     ],
+    "collectCoverageFrom": [
+      "lib/src/**/*.js",
+      "integration/**/*.js",
+      "!lib/src/index.js",
+      "!lib/src/Navigation.js",
+      "!lib/src/adapters/**/*"
+    ],
     "resetMocks": true,
     "resetModules": true,
     "coverageThreshold": {