Browse Source

Don't cache values for constants() call (#5442)

* Don't cache values for constants() call

The reason we can not cache the values is because the implementation differs per OS. Android returns static values while iOS will actually crawl the layout and return it's heights. The caching mechanism here meant that iOS would only return the heights of the layout it calculated the first time.

* Update docs regarding inconsistencies in Constants
Alberto Blanco 5 years ago
parent
commit
a99e138839
2 changed files with 4 additions and 7 deletions
  1. 2
    0
      docs/docs/constants.md
  2. 2
    7
      lib/src/adapters/Constants.ts

+ 2
- 0
docs/docs/constants.md View File

1
 # Constants
1
 # Constants
2
 
2
 
3
+!> Note! iOS resolves the values from the currently displayed root. If the current root doesn't contain BottomTabs - it will return 0 as the BottomTabs height while Android will always return a static value.
4
+
3
 ## statusBarHeight
5
 ## statusBarHeight
4
 ```js
6
 ```js
5
 const constants = await Navigation.constants();
7
 const constants = await Navigation.constants();

+ 2
- 7
lib/src/adapters/Constants.ts View File

9
 
9
 
10
 export class Constants {
10
 export class Constants {
11
   static async get(): Promise<NavigationConstants> {
11
   static async get(): Promise<NavigationConstants> {
12
-    if (!this.instance) {
13
-      const constants: NavigationConstants = await NativeModules.RNNBridgeModule.getConstants();
14
-      this.instance = new Constants(constants);
15
-    }
16
-    return this.instance;
12
+    const constants: NavigationConstants = await NativeModules.RNNBridgeModule.getConstants();
13
+    return new Constants(constants);
17
   }
14
   }
18
 
15
 
19
-  private static instance: Constants;
20
-
21
   public readonly statusBarHeight: number;
16
   public readonly statusBarHeight: number;
22
   public readonly backButtonId: string;
17
   public readonly backButtonId: string;
23
   public readonly topBarHeight: number;
18
   public readonly topBarHeight: number;