Fix BottomTabs size not adjusted after orientation change (#6166)

Fixes #4710

lib/android/app/src/main/java/com/reactnativenavigation/views/BottomTabs.java

@@ -34,6 +34,11 @@ public class BottomTabs extends AHBottomNavigation {
         if (shouldCreateItems) createItems();
     }
 
+    @Override
+    public void onSizeChanged(int w, int h, int oldw, int oldh) {
+        if (hasItemsAndIsMeasured(w, h, oldw, oldh)) createItems();
+    }
+
     @Override
     protected void createItems() {
         if (itemsCreationEnabled) {
@@ -43,11 +48,6 @@ public class BottomTabs extends AHBottomNavigation {
         }
     }
 
-    @Override
-    protected void onSizeChanged(int w, int h, int oldw, int oldh) {
-        // NOOP - don't recreate views on size change
-    }
-
     public void superCreateItems() {
         super.createItems();
     }
@@ -96,4 +96,8 @@ public class BottomTabs extends AHBottomNavigation {
          LinearLayout tabsContainer = findChildByClass(this, LinearLayout.class);
         if (tabsContainer != null) tabsContainer.setLayoutDirection(direction.get());
     }
+
+    private boolean hasItemsAndIsMeasured(int w, int h, int oldw, int oldh) {
+        return w != 0 && h != 0 && (w != oldw || h != oldh) && getItemsCount() > 0;
+    }
 }

lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/bottomtabs/BottomTabsControllerTest.java

@@ -192,6 +192,26 @@ public class BottomTabsControllerTest extends BaseTest {
         verify(bottomTabs, times(2)).superCreateItems(); // first time when view is created, second time when options are applied
     }
 
+    @Test
+    public void onSizeChanged_recreateItemsIfSizeHasChanged() {
+        int numberOfPreviousInvocations = 2;
+        bottomTabs.onSizeChanged(0, 0, 0, 0);
+        verify(bottomTabs, times(numberOfPreviousInvocations)).superCreateItems();
+
+        bottomTabs.onSizeChanged(100, 0, 0, 0);
+        verify(bottomTabs, times(numberOfPreviousInvocations)).superCreateItems();
+
+        bottomTabs.onSizeChanged(1080, 147, 0, 0);
+        verify(bottomTabs, times(numberOfPreviousInvocations + 1)).superCreateItems();
+
+        bottomTabs.onSizeChanged(1920, 147, 0, 0);
+        verify(bottomTabs, times(numberOfPreviousInvocations + 2)).superCreateItems();
+
+        when(bottomTabs.getItemsCount()).thenReturn(0);
+        bottomTabs.onSizeChanged(1080, 147, 0, 0);
+        verify(bottomTabs, times(numberOfPreviousInvocations + 2)).superCreateItems();
+    }
+
     @Test
     public void mergeOptions_currentTabIndex() {
         uut.ensureViewIsCreated();