Implement BottomTabs.titleDisplayMode styling option

This option allows to control when tab titles are displayed

* showWhenActive: when a tab is focused
* alwaysShow: show regardless of which tab is in
* alwaysHide: never show tab titles

docs/docs/styling.md

@@ -193,6 +193,9 @@ Navigation.mergeOptions(this.props.componentId, {
     title: {
       height: 70 // TitleBar height in dp.
     }
+  },
+  bottomTabs: {
+    titleDisplayMode: 'alwaysShow' | 'showWhenActive' | 'alwaysHide' // Sets the title state for each tab.
   }
 }
 ```

lib/android/app/src/main/java/com/reactnativenavigation/parse/BottomTabsOptions.java

@@ -8,6 +8,7 @@ import com.reactnativenavigation.parse.params.NullNumber;
 import com.reactnativenavigation.parse.params.NullText;
 import com.reactnativenavigation.parse.params.Number;
 import com.reactnativenavigation.parse.params.Text;
+import com.reactnativenavigation.parse.params.TitleDisplayMode;
 import com.reactnativenavigation.parse.parsers.BoolParser;
 import com.reactnativenavigation.parse.parsers.ColorParser;
 import com.reactnativenavigation.parse.parsers.NumberParser;
@@ -30,6 +31,7 @@ public class BottomTabsOptions {
         options.drawBehind = BoolParser.parse(json, "drawBehind");
 		options.animate = BoolParser.parse(json,"animate");
         options.testId = TextParser.parse(json, "testID");
+        options.titleDisplayMode = TitleDisplayMode.fromString(json.optString("titleDisplayMode"));
 
 		return options;
 	}
@@ -43,61 +45,30 @@ public class BottomTabsOptions {
 	public Number currentTabIndex = new NullNumber();
 	public Text currentTabId = new NullText();
     public Text testId = new NullText();
+    public TitleDisplayMode titleDisplayMode = TitleDisplayMode.UNDEFINED;
 
 	void mergeWith(final BottomTabsOptions other) {
-		if (other.currentTabId.hasValue()) {
-			currentTabId = other.currentTabId;
-		}
-		if (other.currentTabIndex.hasValue()) {
-            currentTabIndex = other.currentTabIndex;
-		}
-		if (other.visible.hasValue()) {
-			visible = other.visible;
-		}
-        if (other.drawBehind.hasValue()) {
-            drawBehind = other.drawBehind;
-        }
-		if (other.animate.hasValue()) {
-			animate = other.animate;
-		}
-        if (other.tabColor.hasValue()) {
-            tabColor = other.tabColor;
-        }
-        if (other.selectedTabColor.hasValue()) {
-            selectedTabColor = other.selectedTabColor;
-        }
-        if (other.backgroundColor.hasValue()) {
-		    backgroundColor = other.backgroundColor;
-        }
-        if (other.testId.hasValue()) {
-            testId = other.testId;
-        }
+		if (other.currentTabId.hasValue()) currentTabId = other.currentTabId;
+		if (other.currentTabIndex.hasValue()) currentTabIndex = other.currentTabIndex;
+		if (other.visible.hasValue()) visible = other.visible;
+        if (other.drawBehind.hasValue()) drawBehind = other.drawBehind;
+		if (other.animate.hasValue()) animate = other.animate;
+        if (other.tabColor.hasValue()) tabColor = other.tabColor;
+        if (other.selectedTabColor.hasValue()) selectedTabColor = other.selectedTabColor;
+        if (other.backgroundColor.hasValue()) backgroundColor = other.backgroundColor;
+        if (other.testId.hasValue()) testId = other.testId;
+        if (other.titleDisplayMode.hasValue()) titleDisplayMode = other.titleDisplayMode;
     }
 
     void mergeWithDefault(final BottomTabsOptions defaultOptions) {
-        if (!currentTabId.hasValue()) {
-            currentTabId = defaultOptions.currentTabId;
-        }
-        if (!currentTabIndex.hasValue()) {
-            currentTabIndex = defaultOptions.currentTabIndex;
-        }
-        if (!visible.hasValue()) {
-            visible = defaultOptions.visible;
-        }
-        if (!drawBehind.hasValue()) {
-            drawBehind = defaultOptions.drawBehind;
-        }
-        if (!animate.hasValue()) {
-            animate = defaultOptions.animate;
-        }
-        if (!tabColor.hasValue()) {
-            tabColor = defaultOptions.tabColor;
-        }
-        if (!selectedTabColor.hasValue()) {
-            selectedTabColor = defaultOptions.selectedTabColor;
-        }
-        if (!backgroundColor.hasValue()) {
-            backgroundColor = defaultOptions.backgroundColor;
-        }
+        if (!currentTabId.hasValue()) currentTabId = defaultOptions.currentTabId;
+        if (!currentTabIndex.hasValue()) currentTabIndex = defaultOptions.currentTabIndex;
+        if (!visible.hasValue()) visible = defaultOptions.visible;
+        if (!drawBehind.hasValue()) drawBehind = defaultOptions.drawBehind;
+        if (!animate.hasValue()) animate = defaultOptions.animate;
+        if (!tabColor.hasValue()) tabColor = defaultOptions.tabColor;
+        if (!selectedTabColor.hasValue()) selectedTabColor = defaultOptions.selectedTabColor;
+        if (!backgroundColor.hasValue()) backgroundColor = defaultOptions.backgroundColor;
+        if (!titleDisplayMode.hasValue()) titleDisplayMode = defaultOptions.titleDisplayMode;
     }
 }

lib/android/app/src/main/java/com/reactnativenavigation/parse/params/TitleDisplayMode.java

@@ -0,0 +1,46 @@
+package com.reactnativenavigation.parse.params;
+
+import android.support.annotation.NonNull;
+
+import com.aurelhubert.ahbottomnavigation.AHBottomNavigation.TitleState;
+
+import javax.annotation.Nullable;
+
+public enum TitleDisplayMode {
+    ALWAYS_SHOW(TitleState.ALWAYS_SHOW), SHOW_WHEN_ACTIVE(TitleState.SHOW_WHEN_ACTIVE), ALWAYS_HIDE(TitleState.ALWAYS_HIDE), UNDEFINED(null);
+
+    public static TitleDisplayMode fromString(String mode) {
+        switch (mode) {
+            case Constants.ALWAYS_SHOW:
+                return ALWAYS_SHOW;
+            case Constants.SHOW_WHEN_ACTIVE:
+                return SHOW_WHEN_ACTIVE;
+            case Constants.ALWAYS_HIDE:
+                return ALWAYS_HIDE;
+            default:
+                return UNDEFINED;
+        }
+    }
+
+    @Nullable private TitleState state;
+
+    TitleDisplayMode(@Nullable TitleState state) {
+        this.state = state;
+    }
+
+    public boolean hasValue() {
+        return state != null;
+    }
+
+    @NonNull
+    public TitleState toState() {
+        if (state == null) throw new RuntimeException("TitleDisplayMode is undefined");
+        return state;
+    }
+
+    private static class Constants {
+        static final String ALWAYS_SHOW = "alwaysShow";
+        static final String SHOW_WHEN_ACTIVE = "showWhenActive";
+        static final String ALWAYS_HIDE = "alwaysHide";
+    }
+}

lib/android/app/src/main/java/com/reactnativenavigation/presentation/BottomTabsOptionsPresenter.java

@@ -52,15 +52,15 @@ public class BottomTabsOptionsPresenter {
         if (options.drawBehind.isTrue()) {
             lp.bottomMargin = 0;
         }
-
-        // Allocate space for the bottom tabs only if it is visible and it should not draw behind.
         if (options.visible.isTrueOrUndefined() && options.drawBehind.isFalseOrUndefined()) {
             lp.bottomMargin = bottomTabs.getHeight();
         }
-
     }
 
     private void applyBottomTabsOptions(BottomTabsOptions options, AnimationsOptions animationsOptions) {
+        if (options.titleDisplayMode.hasValue()) {
+            bottomTabs.setTitleState(options.titleDisplayMode.toState());
+        }
         if (options.backgroundColor.hasValue()) {
             bottomTabs.setBackgroundColor(options.backgroundColor.get());
         }

lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/bottomtabs/BottomTabsController.java

@@ -137,7 +137,7 @@ public class BottomTabsController extends ParentController implements AHBottomNa
                 bottomTabs.addItems(tabs);
                 bottomTabs.post(() -> {
                     for (int i = 0; i < bottomTabOptionsList.size(); i++) {
-                        bottomTabs.setTabTag(i, bottomTabOptionsList.get(i).testId);
+                        bottomTabs.setTabTestId(i, bottomTabOptionsList.get(i).testId);
                     }
                 });
                 selectTab(0);

lib/android/app/src/main/java/com/reactnativenavigation/views/BottomTabs.java

@@ -18,7 +18,7 @@ public class BottomTabs extends AHBottomNavigation {
         setContentDescription("BottomTabs");
     }
 
-    public void setTabTag(int index, Text testId) {
+    public void setTabTestId(int index, Text testId) {
         if (!testId.hasValue()) return;
         View view = getViewAtPosition(index);
         view.setTag(testId.get());
@@ -43,4 +43,9 @@ public class BottomTabs extends AHBottomNavigation {
     public void setInactiveColor(int inactiveColor) {
         if (getInactiveColor() != inactiveColor) super.setInactiveColor(inactiveColor);
     }
+
+    @Override
+    public void setTitleState(TitleState titleState) {
+        if (getTitleState() != titleState) super.setTitleState(titleState);
+    }
 }

playground/src/screens/WelcomeScreen.js

@@ -124,6 +124,7 @@ class WelcomeScreen extends Component {
           options: {
             bottomTabs: {
               tabColor: 'red',
+              titleDisplayMode: 'alwaysShow',
               selectedTabColor: 'blue',
               fontFamily: 'HelveticaNeue-Italic',
               fontSize: 13,