added lint rules for JS

.babelrc

@@ -0,0 +1,8 @@
+{
+  "presets": [
+    "es2015",
+    "react",
+    "stage-0"
+  ],
+  "retainLines": true
+}

.eslintrc

@@ -0,0 +1,529 @@
+{
+  "parser": "babel-eslint",
+  "env": {
+    "es6": true,
+    "node": true
+  },
+  "parserOptions": {
+    "ecmaVersion": 7,
+    "sourceType": "module",
+    "ecmaFeatures": {
+      "impliedStrict": true,
+      "jsx": true,
+      "experimentalObjectRestSpread": true
+    }
+  },
+  "plugins": [
+    "react",
+    "react-native",
+    "babel"
+  ],
+  "rules": {
+    /*
+     *                          possible errors
+     */
+    "comma-dangle": "error",
+    "no-cond-assign": [
+      "error",
+      "except-parens"
+    ],
+    "no-console": "warn",
+    "no-constant-condition": "error",
+    "no-control-regex": "error",
+    "no-debugger": "warn",
+    "no-dupe-args": "error",
+    "no-dupe-keys": "error",
+    "no-duplicate-case": "error",
+    "no-empty": "error",
+    "no-empty-character-class": "error",
+    "no-ex-assign": "error",
+    "no-extra-boolean-cast": "error",
+    "no-extra-parens": 0,
+    "no-extra-semi": "error",
+    "no-func-assign": "error",
+    "no-inner-declarations": "error",
+    "no-invalid-regexp": "error",
+    "no-irregular-whitespace": "error",
+    "no-negated-in-lhs": "error",
+    "no-obj-calls": "error",
+    "no-regex-spaces": "error",
+    "no-sparse-arrays": "error",
+    "no-unexpected-multiline": "error",
+    "no-unreachable": "error",
+    "use-isnan": "error",
+    "valid-jsdoc": 0,
+    "valid-typeof": "error",
+    /*
+     *                          best practices
+     */
+    "accessor-pairs": "warn",
+    "array-callback-return": 0,
+    "block-scoped-var": "error",
+    "complexity": 0,
+    "consistent-return": "error",
+    "curly": [
+      "error",
+      "all"
+    ],
+    "default-case": "error",
+    "dot-location": [
+      "error",
+      "property"
+    ],
+    "dot-notation": "error",
+    "eqeqeq": "error",
+    "guard-for-in": "error",
+    "no-alert": "error",
+    "no-caller": "error",
+    "no-case-declarations": "error",
+    "no-div-regex": 0,
+    "no-else-return": 0,
+    "no-empty-function": "error",
+    "no-empty-pattern": "error",
+    "no-eq-null": "error",
+    "no-eval": "error",
+    "no-extend-native": "error",
+    "no-extra-bind": "error",
+    "no-extra-label": "error",
+    "no-fallthrough": "error",
+    "no-floating-decimal": "error",
+    "no-implicit-coercion": "error",
+    "no-implicit-globals": 0,
+    "no-implied-eval": "error",
+    "no-invalid-this": 0,
+    "no-iterator": "error",
+    "no-labels": "error",
+    "no-lone-blocks": "error",
+    "no-loop-func": "error",
+    "no-magic-numbers": 0,
+    "no-multi-spaces": "error",
+    "no-multi-str": 0,
+    "no-native-reassign": "error",
+    "no-new": "error",
+    "no-new-func": "error",
+    "no-new-wrappers": "error",
+    "no-octal": "error",
+    "no-octal-escape": "error",
+    "no-param-reassign": "error",
+    "no-proto": "error",
+    "no-redeclare": 0,
+    "no-return-assign": "error",
+    "no-script-url": "error",
+    "no-self-assign": "error",
+    "no-self-compare": "error",
+    "no-sequences": "error",
+    "no-throw-literal": "error",
+    "no-unmodified-loop-condition": 0,
+    "no-unused-expressions": "error",
+    "no-unused-labels": 0,
+    "no-useless-call": "error",
+    "no-useless-concat": "error",
+    "no-void": "error",
+    "no-warning-comments": 0,
+    "no-with": "error",
+    "radix": 0,
+    "vars-on-top": 0,
+    "wrap-iife": "error",
+    "yoda": 0,
+    "strict": [
+      "error",
+      "never"
+    ],
+    /*
+     *                           variables
+     */
+    "init-declarations": 0,
+    "no-catch-shadow": "error",
+    "no-delete-var": "error",
+    "no-label-var": "error",
+    "no-restricted-globals": "error",
+    "no-shadow": "error",
+    "no-shadow-restricted-names": "error",
+    "no-undef": 0,
+    "no-undef-init": "error",
+    "no-undefined": 0,
+    "no-unused-vars": 0,
+    "no-use-before-define": 0,
+    /*
+     *                          Node.js
+     */
+    "callback-return": 0,
+    "global-require": 0,
+    "handle-callback-err": 0,
+    "no-mixed-requires": "error",
+    "no-new-require": "error",
+    "no-path-concat": "error",
+    "no-process-env": 0,
+    "no-process-exit": "error",
+    "no-restricted-modules": 0,
+    "no-sync": 0,
+    /*
+     *                          style
+     */
+    "array-bracket-spacing": [
+      "error",
+      "never"
+    ],
+    "block-spacing": "error",
+    "brace-style": [
+      "error",
+      "1tbs"
+    ],
+    "camelcase": [
+      "error",
+      {
+        "properties": "never"
+      }
+    ],
+    "comma-spacing": [
+      "error",
+      {
+        "before": false,
+        "after": true
+      }
+    ],
+    "comma-style": [
+      "error",
+      "last"
+    ],
+    "computed-property-spacing": [
+      "error",
+      "never"
+    ],
+    "consistent-this": [
+      "error",
+      "self"
+    ],
+    "eol-last": [
+      "error",
+      "unix"
+    ],
+    "func-names": 0,
+    "func-style": 0,
+    "id-blacklist": 0,
+    "id-length": 0,
+    "id-match": 0,
+    "indent": [
+      "error",
+      2,
+      {
+        "SwitchCase": 1
+      }
+    ],
+    "jsx-quotes": "error",
+    "key-spacing": [
+      "error",
+      {
+        "singleLine": {
+          "beforeColon": false,
+          "afterColon": true,
+          "mode": "strict"
+        },
+        "multiLine": {
+          "beforeColon": false,
+          "afterColon": true,
+          "mode": "strict"
+        }
+      }
+    ],
+    "keyword-spacing": [
+      "error",
+      {
+        "before": true,
+        "after": true
+      }
+    ],
+    "linebreak-style": [
+      "error",
+      "unix"
+    ],
+    "lines-around-comment": 0,
+    "max-depth": [
+      "error",
+      4
+    ],
+    "max-len": [
+      "warn",
+      150
+    ],
+    "max-nested-callbacks": [
+      "error",
+      4
+    ],
+    "max-params": [
+      "error",
+      6
+    ],
+    "max-statements": [
+      "error",
+      15,
+      {
+        "ignoreTopLevelFunctions": true
+      }
+    ],
+    "new-cap": [
+      "error",
+      {
+        "capIsNewExceptions": [
+          "Immutable"
+        ]
+      }
+    ],
+    "new-parens": "error",
+    "newline-after-var": 0,
+    "newline-before-return": 0,
+    "newline-per-chained-call": 0,
+    "no-array-constructor": "error",
+    "no-bitwise": 0,
+    "no-continue": 0,
+    "no-inline-comments": 0,
+    "no-lonely-if": "error",
+    "no-mixed-spaces-and-tabs": 0,
+    "no-multiple-empty-lines": [
+      "error",
+      {
+        "max": 1
+      }
+    ],
+    "no-negated-condition": 0,
+    "no-nested-ternary": "error",
+    "no-new-object": "error",
+    "no-plusplus": 0,
+    "no-restricted-syntax": 0,
+    "no-spaced-func": "error",
+    "no-ternary": 0,
+    "no-trailing-spaces": [
+      "error",
+      {
+        "skipBlankLines": true
+      }
+    ],
+    "no-underscore-dangle": 0,
+    "no-unneeded-ternary": "error",
+    "no-whitespace-before-property": "error",
+    "object-curly-spacing": [
+      "error",
+      "never"
+    ],
+    "one-var": 0,
+    "one-var-declaration-per-line": 0,
+    "operator-assignment": 0,
+    "operator-linebreak": [
+      "error",
+      "before"
+    ],
+    "padded-blocks": [
+      "error",
+      "never"
+    ],
+    "quote-props": [
+      "error",
+      "consistent-as-needed"
+    ],
+    "quotes": 0,
+    "require-jsdoc": 0,
+    "semi": [
+      "error",
+      "always"
+    ],
+    "semi-spacing": [
+      "error",
+      {
+        "before": false,
+        "after": true
+      }
+    ],
+    "sort-imports": 0,
+    "sort-vars": 0,
+    "space-before-blocks": [
+      "error",
+      "always"
+    ],
+    "space-before-function-paren": [
+      "error",
+      "never"
+    ],
+    "space-in-parens": [
+      "error",
+      "never"
+    ],
+    "space-infix-ops": "error",
+    "space-unary-ops": "error",
+    "spaced-comment": 0,
+    "wrap-regex": "error",
+    /*
+     *                             ECMAScript 6
+     */
+    "arrow-body-style": 0,
+    "arrow-parens": 0,
+    "arrow-spacing": [
+      "error",
+      {
+        "before": true,
+        "after": true
+      }
+    ],
+    "constructor-super": "error",
+    "generator-star-spacing": 0,
+    "no-class-assign": "error",
+    "no-confusing-arrow": "error",
+    "no-const-assign": "error",
+    "no-dupe-class-members": "error",
+    "no-new-symbol": "error",
+    "no-restricted-imports": 0,
+    "no-this-before-super": "error",
+    "no-useless-constructor": 0,
+    "no-var": "error",
+    "object-shorthand": 0,
+    "prefer-arrow-callback": 0,
+    "prefer-const": "error",
+    "prefer-reflect": 0,
+    "prefer-rest-params": "error",
+    "prefer-spread": "error",
+    "prefer-template": 0,
+    "require-yield": 0,
+    "template-curly-spacing": [
+      "error",
+      "never"
+    ],
+    "yield-star-spacing": [
+      "error",
+      "after"
+    ],
+    /*
+     *                              react plugin
+     */
+    "react/display-name": 0,
+    "react/forbid-prop-types": [
+      "error",
+      {
+        "forbid": [
+          "any"
+        ]
+      }
+    ],
+    "react/no-danger": "error",
+    "react/no-deprecated": "error",
+    "react/no-did-mount-set-state": [
+      "error",
+      "allow-in-func"
+    ],
+    "react/no-did-update-set-state": [
+      "error",
+      "allow-in-func"
+    ],
+    "react/no-direct-mutation-state": "error",
+    "react/no-is-mounted": "error",
+    "react/no-multi-comp": "error",
+    "react/no-set-state": 0,
+    "react/no-string-refs": 0,
+    "react/no-unknown-property": 0,
+    "react/prefer-es6-class": [
+      "error",
+      "always"
+    ],
+    "react/prefer-stateless-function": 0,
+    "react/prop-types": "error",
+    "react/react-in-jsx-scope": "error",
+    "react/require-extension": 0,
+    "react/self-closing-comp": "error",
+    "react/sort-comp": [
+      "error",
+      {
+        "order": [
+          "static-methods",
+          "lifecycle",
+          "/^on.+$/",
+          "/^(get|set)(?!(InitialState$|DefaultProps$|ChildContext$)).+$/",
+          "everything-else",
+          "/^render.+$/",
+          "render"
+        ]
+      }
+    ],
+    "react/sort-prop-types": 0,
+    "react/wrap-multilines": "error",
+    "react/jsx-boolean-value": [
+      "error",
+      "always"
+    ],
+    "react/jsx-closing-bracket-location": "error",
+    "react/jsx-curly-spacing": [
+      "error",
+      "never"
+    ],
+    "react/jsx-equals-spacing": [
+      "error",
+      "never"
+    ],
+    "react/jsx-handler-names": [
+      "error",
+      {
+        "eventHandlerPropPrefix": "handle"
+      }
+    ],
+    "react/jsx-indent-props": [
+      0,
+      2
+    ],
+    "react/jsx-indent": [
+      "error",
+      2
+    ],
+    "react/jsx-key": "error",
+    "react/jsx-max-props-per-line": [
+      "error",
+      {
+        "maximum": 2
+      }
+    ],
+    "react/jsx-no-bind": 0,
+    "react/jsx-no-duplicate-props": [
+      "error",
+      {
+        "ignoreCase": true
+      }
+    ],
+    "react/jsx-no-literals": "error",
+    "react/jsx-no-undef": "error",
+    "react/jsx-pascal-case": "error",
+    "react/jsx-sort-props": 0,
+    "react/jsx-space-before-closing": 0,
+    "react/jsx-uses-react": "error",
+    "react/jsx-uses-vars": "error",
+    /*
+     *                              react-native plugin
+     */
+    "react-native/no-unused-styles": "error",
+    "react-native/split-platform-components": "error",
+    /*
+     *                              babel plugin
+     */
+    "babel/generator-star-spacing": [
+      "error",
+      "after"
+    ],
+    "babel/new-cap": [
+      "error",
+      {
+        "capIsNewExceptions": [
+          "Immutable"
+        ]
+      }
+    ],
+    "babel/array-bracket-spacing": [
+      "error",
+      "never"
+    ],
+    "babel/object-curly-spacing": [
+      "error",
+      "never"
+    ],
+    "babel/object-shorthand": 0,
+    "babel/arrow-parens": [
+      "error",
+      "always"
+    ],
+    "babel/no-await-in-loop": 0
+  }
+}

package.json

@@ -18,6 +18,13 @@
   "main": "src/index.js",
   "author": "Tal Kol <talkol@gmail.com>",
   "license": "MIT",
+  "scripts": {
+    "build": ":",
+    "lint": "eslint src test",
+    "pretest": "npm run lint",
+    "test": ":",
+    "release": ":"
+  },
   "peerDependencies": {
     "react-native": ">=0.25.1",
     "react": ">=0.14.5"

src/Navigation.js

@@ -1,5 +1,5 @@
 import React from 'react';
-import { AppRegistry } from 'react-native';
+import {AppRegistry} from 'react-native';
 import platformSpecific from './platformSpecific';
 import Screen from './Screen';
 
@@ -24,6 +24,7 @@ function _registerComponentNoRedux(screenID, generator) {
     return class extends Screen {
       static navigatorStyle = InternalComponent.navigatorStyle || {};
       static navigatorButtons = InternalComponent.navigatorButtons || {};
+
       render() {
         return (
           <InternalComponent navigator={this.navigator} {...this.props} />
@@ -41,6 +42,7 @@ function _registerComponentRedux(screenID, generator, store, Provider) {
     return class extends Screen {
       static navigatorStyle = InternalComponent.navigatorStyle || {};
       static navigatorButtons = InternalComponent.navigatorButtons || {};
+
       render() {
         return (
           <Provider store={store}>
@@ -57,7 +59,7 @@ function _registerComponentRedux(screenID, generator, store, Provider) {
 function getRegisteredScreen(screenID) {
   const generator = registeredScreens[screenID];
   if (!generator) {
-    console.error('Navigation.getRegisteredScreen: ' + screenID + ' used but not yet registered');
+    console.error(`Navigation.getRegisteredScreen: ${screenID} used but not yet registered`);
     return;
   }
   return generator();
@@ -91,7 +93,7 @@ function dismissInAppNotification(params = {}) {
   return platformSpecific.dismissInAppNotification(params);
 }
 
-export default {
+module.exports = {
   registerScreen,
   getRegisteredScreen,
   registerComponent,
@@ -104,4 +106,4 @@ export default {
   dismissInAppNotification,
   startTabBasedApp: platformSpecific.startTabBasedApp,
   startSingleScreenApp: platformSpecific.startSingleScreenApp
-}
+};

src/index.js

@@ -1,11 +1,5 @@
-import Navigation from './src/Navigation';
-import Screen from './src/Screen';
-import RctActivity from './src/modules/RctActivity';
-import { NavigationToolBarIOS } from 'react-native-controllers';
+import Navigation from './Navigation';
 
-export {
-  Navigation,
-  Screen,
-  RctActivity,
-  NavigationToolBarIOS
+module.exports = {
+  Navigation
 };

src/modules/RctActivity.js

@@ -1,2 +0,0 @@
-import { NativeModules } from 'react-native';
-module.exports = NativeModules.RctActivity;