tabBarHidden for iOS (#1753)

README.md

@@ -85,7 +85,7 @@ Note:  v1 properties with names beginning with 'navBar' are replaced in v2 with
 | drawUnderTopBar       |  ✅     |    WIP @gran33     |      [Contribute](CONTRIBUTING.md)       ||
 | statusBarBlur         |  ✅     |    ✅     |      [Contribute](CONTRIBUTING.md)       | @gtchance|
 | topBarBlur            | ✅      |    [Contribute](CONTRIBUTING.md)     |      [Contribute](CONTRIBUTING.md)       |
-| tabBarHidden  |   ✅  |   [Contribute](CONTRIBUTING.md)     |    [Contribute](CONTRIBUTING.md)        |
+| tabBarHidden  |   ✅  |   ✅     |    [Contribute](CONTRIBUTING.md)        | @gtchance|
 | statusBarTextColorScheme |  ✅   |   in development      |      / iOS specific    |
 | statusBarTextColorSchemeSingleScreen|  ✅   |     in development    |     / iOS specific      |
 | navBarSubtitleColor          |  ✅   |   [Contribute](CONTRIBUTING.md)     |      [Contribute](CONTRIBUTING.md)      |

lib/ios/RNNNavigationOptions.h

@@ -22,6 +22,7 @@ extern const NSInteger BLUR_STATUS_TAG;
 @property (nonatomic, strong) NSNumber* topBarNoBorder;
 @property (nonatomic, strong) NSNumber* statusBarBlur;
 @property (nonatomic, strong) NSNumber* statusBarHideWithTopBar;
+@property (nonatomic, strong) NSNumber* tabBarHidden;
 
 -(instancetype)init;
 -(instancetype)initWithDict:(NSDictionary *)navigationOptions;

lib/ios/RNNNavigationOptions.m

@@ -26,6 +26,7 @@ const NSInteger BLUR_STATUS_TAG = 78264801;
 	self.leftButtons = [navigationOptions objectForKey:@"leftButtons"];
 	self.rightButtons = [navigationOptions objectForKey:@"rightButtons"];
 	self.topBarNoBorder = [navigationOptions objectForKey:@"topBarNoBorder"];
+	self.tabBarHidden = [navigationOptions objectForKey:@"tabBarHidden"];
 
 	return self;
 }

lib/ios/RNNRootViewController.m

@@ -49,6 +49,14 @@
 	return NO;
 }
 
+- (BOOL)hidesBottomBarWhenPushed
+{
+	if (self.navigationOptions.tabBarHidden) {
+		return [self.navigationOptions.tabBarHidden boolValue];
+	}
+	return NO;
+}
+
 -(void)viewDidAppear:(BOOL)animated {
 	[super viewDidAppear:animated];
 	[self.eventEmitter sendContainerDidAppear:self.containerId];

lib/ios/ReactNativeNavigationTests/RNNRootViewControllerTest.m

@@ -318,5 +318,28 @@
 	XCTAssertNil([self.uut.view viewWithTag:BLUR_STATUS_TAG]);
 }
 
+- (void)testTabBarHidden_default {
+	__unused UINavigationController* nav = [[UINavigationController alloc] initWithRootViewController:self.uut];
+	[self.uut viewWillAppear:false];
+
+	XCTAssertFalse([self.uut hidesBottomBarWhenPushed]);
+}
+
+
+- (void)testTabBarHidden_true {
+	self.options.tabBarHidden = @(1);
+	__unused UINavigationController* nav = [[UINavigationController alloc] initWithRootViewController:self.uut];
+	[self.uut viewWillAppear:false];
+
+	XCTAssertTrue([self.uut hidesBottomBarWhenPushed]);
+}
+
+- (void)testTabBarHidden_false {
+	self.options.tabBarHidden = @(0);
+	__unused UINavigationController* nav = [[UINavigationController alloc] initWithRootViewController:self.uut];
+	[self.uut viewWillAppear:false];
+
+	XCTAssertFalse([self.uut hidesBottomBarWhenPushed]);
+}
 
 @end