Closes #3787 (#3934)

* Closes #3787

* Merge options only when viewController conforms to RNNRootViewProtocol

* better practice

* Fixes e2e

lib/ios/RNNCommandsHandler.m

@@ -67,29 +67,14 @@ static NSString* const setDefaultOptions	= @"setDefaultOptions";
 - (void)mergeOptions:(NSString*)componentId options:(NSDictionary*)options completion:(RNNTransitionCompletionBlock)completion {
 	[self assertReady];
 	
-	UIViewController* vc = [_store findComponentForId:componentId];
-	if([vc isKindOfClass:[RNNRootViewController class]]) {
-		RNNRootViewController* rootVc = (RNNRootViewController*)vc;
-		[rootVc.options mergeWith:options];
+	UIViewController<RNNRootViewProtocol>* vc = (UIViewController<RNNRootViewProtocol>*)[_store findComponentForId:componentId];
+	if ([vc conformsToProtocol:@protocol(RNNRootViewProtocol)] || [vc isKindOfClass:[RNNRootViewController class]]) {
+		[vc.getLeafViewController.options mergeWith:options];
 		[CATransaction begin];
 		[CATransaction setCompletionBlock:completion];
-		
-		[rootVc.options applyOn:vc];
-		
-		[CATransaction commit];
-	}
-	
-	if ([vc isKindOfClass:[RNNSplitViewController class]]) {
-		RNNSplitViewController* splitVc = (RNNSplitViewController*)vc;
-		[splitVc.options mergeWith:options];
-		[CATransaction begin];
-		[CATransaction setCompletionBlock:completion];
-		
-		[splitVc.options applyOn:vc];
-		
+		[vc.getLeafViewController.options applyOn:vc.getLeafViewController];
 		[CATransaction commit];
 	}
-	
 }
 
 - (void)setDefaultOptions:(NSDictionary*)optionsDict completion:(RNNTransitionCompletionBlock)completion {

lib/ios/RNNTabBarController.h

@@ -7,7 +7,6 @@
 
 - (instancetype)initWithEventEmitter:(RNNEventEmitter*)eventEmitter;
 
-- (void)setTabBarHidden:(BOOL)hidden animated:(BOOL)animated;
 - (void)setSelectedIndexByComponentID:(NSString *)componentID;
 
 @end

lib/ios/RNNTabBarController.m

@@ -19,18 +19,6 @@
 	return self.selectedViewController.supportedInterfaceOrientations;
 }
 
-- (void)setTabBarHidden:(BOOL)hidden animated:(BOOL)animated {
-	CGRect frame = self.tabBar.frame;
-	CGFloat height = frame.size.height;
-	CGFloat offsetY = (hidden ? self.view.frame.size.height : self.view.frame.size.height-height);
-	frame.origin.y = offsetY;
-	NSTimeInterval duration = animated ? kTabBarHiddenDuration : 0.0;
-	
-	[UIView animateWithDuration:duration animations:^{
-		self.tabBar.frame = frame;
-	}];
-}
-
 - (void)setSelectedIndexByComponentID:(NSString *)componentID {
 	for (id child in self.childViewControllers) {
 		RNNRootViewController* vc = child;