소스 검색

Fix order of `registerComponentWithRedux` arguments (#3933)

The actual `registerComponentWithRedux` function definition is the following:
```
    registerComponentWithRedux(componentName, getComponentClassFunc, ReduxProvider, reduxStore) {
        return this.componentRegistry.registerComponent(componentName, getComponentClassFunc, ReduxProvider, reduxStore);
    }
```

Note the order of `store` and `provider` are the opposite as shown in the original documentation.  This will fix it, but it's worth mentioning that v1 has the order shown in the original documentation, so it would be nice to keep the parameter order the same in v2.
Adam Terlson 6 년 전
부모
커밋
c21b5efa6f
1개의 변경된 파일3개의 추가작업 그리고 3개의 파일을 삭제
  1. 3
    3
      docs/docs/third-party.md

+ 3
- 3
docs/docs/third-party.md 파일 보기

@@ -2,10 +2,10 @@
2 2
 
3 3
 ## Redux
4 4
 
5
-### registerComponentWithRedux(screenID, generator, store, provider)
5
+### registerComponentWithRedux(screenID, generator, Provider, store)
6 6
 Utility helper function like registerComponent,
7 7
 wraps the provided component with a react-redux Provider with the passed redux store
8 8
 
9 9
 ```js
10
-Navigation.registerComponentWithRedux('navigation.playground.WelcomeScreen', () => WelcomeScreen, store, provider);
11
-```
10
+Navigation.registerComponentWithRedux('navigation.playground.WelcomeScreen', () => WelcomeScreen, Provider, store);
11
+```