Detox android (#2811)

* Make detox android test suit pass

Disabled emulator animations due to limitation of espresso/detox which can't wait until
a push/pop animation ends

* Fix orientation parsing and enable detox orientation tests

* remove only

* Fix BottomTabs testId

* Support user orientation

* Fix rightButtons testId

* Add Modals tests

* e2e fix ios

AndroidE2E/app/src/androidTest/java/com/reactnativenavigation/e2e/androide2e/OverlayTest.java

@@ -12,7 +12,7 @@ public class OverlayTest extends BaseTest {
 		elementByText("PUSH OPTIONS SCREEN").click();
         elementByText("SHOW OVERLAY").click();
 		assertExists(By.text("Test view"));
-        assetDismissed();
+        assertDismissed();
 	}
 
     @Test
@@ -22,10 +22,10 @@ public class OverlayTest extends BaseTest {
 		assertExists(By.text("Test view"));
         elementByText("DYNAMIC OPTIONS").click();
         assertExists(By.text("Dynamic Title"));
-        assetDismissed();
+        assertDismissed();
 	}
 
-    private void assetDismissed() throws UiObjectNotFoundException {
+    private void assertDismissed() throws UiObjectNotFoundException {
         elementByText("OK").click();
         assertExists(By.text("Overlay disappeared"));
         elementByText("OK").click();

e2e/Modals.test.js

@@ -1,7 +1,7 @@
 const Utils = require('./Utils');
 const testIDs = require('../playground/src/testIDs');
 
-const { elementByLabel, elementById } = Utils;
+const { elementByLabel, elementById, tapDeviceBackAndroid } = Utils;
 
 describe('modal', () => {
   beforeEach(async () => {
@@ -92,4 +92,18 @@ describe('modal', () => {
     await elementById(testIDs.DISMISS_ALL_MODALS_BUTTON).tap();
     await expect(elementById(testIDs.WELCOME_SCREEN_HEADER)).toBeVisible();
   });
+
+  it('push into modal', async () => {
+    await elementById(testIDs.SHOW_MODAL_BUTTON).tap();
+    await elementById(testIDs.PUSH_BUTTON).tap();
+    await expect(elementByLabel('Pushed Screen')).toBeVisible();
+  });
+
+  it(':android: push into modal', async () => {
+    await elementById(testIDs.SHOW_MODAL_BUTTON).tap();
+    await elementById(testIDs.PUSH_BUTTON).tap();
+    await elementById(testIDs.PUSH_BUTTON).tap();
+    tapDeviceBackAndroid();
+    await expect(elementByLabel('Pushed Screen')).toBeVisible();
+  });
 });

e2e/Orientations.test.js

@@ -4,7 +4,8 @@ const testIDs = require('../playground/src/testIDs');
 
 const { elementById } = Utils;
 
-describe(':ios: orientation', () => {
+describe('orientation', () => {
+
   beforeEach(async () => {
     await device.relaunchApp();
   });
@@ -31,7 +32,7 @@ describe(':ios: orientation', () => {
     await elementById(testIDs.DISMISS_BUTTON).tap();
   });
 
-  it('portrait only', async () => {
+  it(':ios: portrait only', async () => {
     await elementById(testIDs.ORIENTATION_BUTTON).tap();
     await elementById(testIDs.PORTRAIT_ORIENTATION_BUTTON).tap();
     await expect(elementById(testIDs.PORTRAIT_ELEMENT)).toBeVisible();
@@ -42,7 +43,7 @@ describe(':ios: orientation', () => {
     await elementById(testIDs.DISMISS_BUTTON).tap();
   });
 
-  it('landscape only', async () => {
+  it(':ios: landscape only', async () => {
     await elementById(testIDs.ORIENTATION_BUTTON).tap();
     await elementById(testIDs.LANDSCAPE_ORIENTATION_BUTTON).tap();
     await device.setOrientation('landscape');

e2e/ScreenStyle.test.js

@@ -21,7 +21,6 @@ describe('screen style', () => {
   });
 
   it('set dynamic options with valid options will do something and not crash', async () => {
-    // we have no way of testing individual styles for the screen
     await elementById(testIDs.PUSH_OPTIONS_BUTTON).tap();
     await elementById(testIDs.DYNAMIC_OPTIONS_BUTTON).tap();
     await expect(elementById(testIDs.OPTIONS_SCREEN_HEADER)).toBeVisible();
@@ -35,14 +34,14 @@ describe('screen style', () => {
     await expect(elementById(testIDs.TOP_BAR_ELEMENT)).toBeVisible();
   });
 
-  it(':ios: hides topBar onScroll down and shows it on scroll up', async () => {
+  it('hides topBar onScroll down and shows it on scroll up', async () => {
     await elementById(testIDs.PUSH_OPTIONS_BUTTON).tap();
     await elementById(testIDs.SCROLLVIEW_SCREEN_BUTTON).tap();
     await elementById(testIDs.TOGGLE_TOP_BAR_HIDE_ON_SCROLL).tap();
     await expect(elementById(testIDs.TOP_BAR_ELEMENT)).toBeVisible();
     await element(by.id(testIDs.SCROLLVIEW_ELEMENT)).swipe('up', 'slow');
     await expect(elementById(testIDs.TOP_BAR_ELEMENT)).toBeNotVisible();
-    await element(by.id(testIDs.SCROLLVIEW_ELEMENT)).swipe('down', 'slow');
+    await element(by.id(testIDs.SCROLLVIEW_ELEMENT)).swipe('down', 'fast');
     await expect(elementById(testIDs.TOP_BAR_ELEMENT)).toBeVisible();
   });
 
@@ -52,14 +51,14 @@ describe('screen style', () => {
     await expect(element(by.text('TeSt'))).toBeVisible();
   });
 
-  it(':ios: hide Tab Bar', async () => {
+  it('hide Tab Bar', async () => {
     await elementById(testIDs.TAB_BASED_APP_BUTTON).tap();
     await expect(elementById(testIDs.BOTTOM_TABS_ELEMENT)).toBeVisible();
     await elementById(testIDs.HIDE_BOTTOM_TABS_BUTTON).tap();
     await expect(elementById(testIDs.BOTTOM_TABS_ELEMENT)).toBeNotVisible();
   });
 
-  it(':ios: show Tab Bar', async () => {
+  it('show Tab Bar', async () => {
     await elementById(testIDs.TAB_BASED_APP_BUTTON).tap();
     await elementById(testIDs.HIDE_BOTTOM_TABS_BUTTON).tap();
     await expect(elementById(testIDs.BOTTOM_TABS_ELEMENT)).toBeNotVisible();
@@ -83,7 +82,7 @@ describe('screen style', () => {
     await expect(elementById(testIDs.CENTERED_TEXT_HEADER)).toBeVisible();
   });
 
-  it(':ios: set right buttons', async () => {
+  it('set right buttons', async () => {
     await elementById(testIDs.PUSH_OPTIONS_BUTTON).tap();
     await expect(elementById('buttonOne')).toBeVisible();
     await elementById('buttonOne').tap();
@@ -126,8 +125,6 @@ describe('screen style', () => {
 
   it('stack options should not override component options', async () => {
     await elementById(testIDs.TAB_BASED_APP_BUTTON).tap();
-    await expect(elementById(testIDs.TOP_BAR_ELEMENT)).toBeNotVisible();
-    await elementById(testIDs.SECOND_TAB_BAR_BUTTON).tap();
     await expect(elementById(testIDs.TOP_BAR_ELEMENT)).toBeVisible();
   });
 });

e2e/Utils.js

@@ -1,3 +1,5 @@
+const exec = require('shell-utils').exec;
+
 module.exports = {
   elementByLabel: (label) => {
     return element(by.text(label));
@@ -11,5 +13,8 @@ module.exports = {
     } catch (err) {
       return element(by.type('_UIModernBarButton').and(by.label('Back'))).tap();
     }
+  },
+  tapDeviceBackAndroid: () => {
+    exec.execSync('adb shell input keyevent 4');
   }
 };

e2e/init.js

@@ -1,10 +1,19 @@
 const detox = require('detox');
 const config = require('../package.json').detox;
+const exec = require('shell-utils').exec;
 
 before(async () => {
   await detox.init(config, { launchApp: false });
+  disableAndroidEmulatorAnimations();
 });
 
 after(async () => {
   await detox.cleanup();
 });
+
+// Temporary solution, #2809
+function disableAndroidEmulatorAnimations() {
+  exec.execAsync(`adb shell settings put global window_animation_scale 0.0`);
+  exec.execAsync(`adb shell settings put global transition_animation_scale 0.0`);
+  exec.execAsync(`adb shell settings put global animator_duration_scale 0.0`);
+}

lib/android/app/src/main/java/com/reactnativenavigation/parse/BottomTabsOptions.java

@@ -64,6 +64,9 @@ public class BottomTabsOptions implements DEFAULT_VALUES {
         if (other.backgroundColor.hasValue()) {
 		    backgroundColor = other.backgroundColor;
         }
+        if (other.testId.hasValue()) {
+            testId = other.testId;
+        }
     }
 
     void mergeWithDefault(final BottomTabsOptions defaultOptions) {

lib/android/app/src/main/java/com/reactnativenavigation/parse/Options.java

@@ -19,7 +19,7 @@ public class Options implements DEFAULT_VALUES {
         Options result = new Options();
         if (json == null) return result;
 
-        result.orientationOptions = OrientationOptions.parse(json.optJSONArray("orientation"));
+        result.orientationOptions = OrientationOptions.parse(json);
         result.topBarOptions = TopBarOptions.parse(typefaceManager, json.optJSONObject("topBar"));
         result.topTabsOptions = TopTabsOptions.parse(json.optJSONObject("topTabs"));
         result.topTabOptions = TopTabOptions.parse(typefaceManager, json.optJSONObject("topTab"));

lib/android/app/src/main/java/com/reactnativenavigation/parse/OrientationOptions.java

@@ -3,26 +3,33 @@ package com.reactnativenavigation.parse;
 import com.reactnativenavigation.parse.params.Orientation;
 
 import org.json.JSONArray;
+import org.json.JSONObject;
 
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
 
 public class OrientationOptions {
-    Orientation[] orientations = new Orientation[0];
+    List<Orientation> orientations = new ArrayList<>();
 
-    public static OrientationOptions parse(JSONArray orientations) {
+    public static OrientationOptions parse(JSONObject json) {
         OrientationOptions options = new OrientationOptions();
-        if (orientations == null) return options;
+        if (json == null) return options;
 
-        List<Orientation> parsed = new ArrayList<>();
-        for (int i = 0; i < orientations.length(); i++) {
-            Orientation o = Orientation.fromString(orientations.optString(i, "default"));
-            if (o != null) {
-                parsed.add(o);
+        JSONArray orientations = json.optJSONArray("orientation");
+        if (orientations == null) {
+            String orientation = json.optString("orientation", Orientation.Default.name);
+            options.orientations.add(Orientation.fromString(orientation));
+        } else {
+            List<Orientation> parsed = new ArrayList<>();
+            for (int i = 0; i < orientations.length(); i++) {
+                Orientation o = Orientation.fromString(orientations.optString(i, "default"));
+                if (o != null) {
+                    parsed.add(o);
+                }
             }
+            options.orientations = parsed;
         }
-        options.orientations = parsed.toArray(new Orientation[0]);
 
         return options;
     }
@@ -30,11 +37,15 @@ public class OrientationOptions {
     public int getValue() {
         if (!hasValue()) return Orientation.Default.orientationCode;
 
-        int result = 0;
-        for (Orientation orientation : orientations) {
-            result |= orientation.orientationCode;
+        switch (orientations.get(0)) {
+            case Landscape:
+                return orientations.contains(Orientation.Portrait) ? Orientation.PortraitLandscape.orientationCode : Orientation.Landscape.orientationCode;
+            case Portrait:
+                return orientations.contains(Orientation.Landscape) ? Orientation.PortraitLandscape.orientationCode : Orientation.Portrait.orientationCode;
+            default:
+            case Default:
+                return Orientation.Default.orientationCode;
         }
-        return result;
     }
 
     public void mergeWith(OrientationOptions other) {
@@ -42,7 +53,7 @@ public class OrientationOptions {
     }
 
     private boolean hasValue() {
-        return orientations.length > 0;
+        return !orientations.isEmpty();
     }
 
     public void mergeWithDefault(OrientationOptions defaultOptions) {
@@ -51,6 +62,6 @@ public class OrientationOptions {
 
     @Override
     public String toString() {
-        return hasValue() ? Arrays.toString(orientations) : Orientation.Default.toString();
+        return hasValue() ? Arrays.toString(orientations.toArray(new Orientation[0])) : Orientation.Default.toString();
     }
 }

lib/android/app/src/main/java/com/reactnativenavigation/parse/params/Orientation.java

@@ -7,7 +7,8 @@ import android.support.annotation.Nullable;
 public enum Orientation {
     Portrait("portrait", Configuration.ORIENTATION_PORTRAIT, ActivityInfo.SCREEN_ORIENTATION_PORTRAIT),
     Landscape("landscape", Configuration.ORIENTATION_LANDSCAPE, ActivityInfo.SCREEN_ORIENTATION_LANDSCAPE),
-    Default("default", Configuration.ORIENTATION_UNDEFINED, ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED);
+    Default("default", Configuration.ORIENTATION_UNDEFINED, ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED),
+    PortraitLandscape("sensor", Configuration.ORIENTATION_UNDEFINED, ActivityInfo.SCREEN_ORIENTATION_USER);
 
     public String name;
     public int configurationCode;

lib/android/app/src/main/java/com/reactnativenavigation/views/TitleBarButton.java

@@ -158,7 +158,7 @@ public class TitleBarButton implements MenuItem.OnMenuItemClickListener {
             ActionMenuView buttonsLayout = ViewUtils.findChildByClass(toolbar, ActionMenuView.class);
             List<TextView> buttons = ViewUtils.findChildrenByClass(buttonsLayout, TextView.class);
             for (TextView view : buttons) {
-                if (button.title.hasValue() && button.title.get().equals(view.getText())) {
+                if (button.title.hasValue() && button.title.get().equals(view.getText().toString())) {
                     view.setTag(testId.get());
                 } else if (button.icon.hasValue() && ArrayUtils.contains(view.getCompoundDrawables(), icon)) {
                     view.setTag(testId.get());

lib/android/app/src/test/java/com/reactnativenavigation/parse/OrientationOptionsTest.java

@@ -4,6 +4,8 @@ import com.reactnativenavigation.BaseTest;
 import com.reactnativenavigation.parse.params.Orientation;
 
 import org.json.JSONArray;
+import org.json.JSONException;
+import org.json.JSONObject;
 import org.junit.Test;
 
 import java.util.Arrays;
@@ -26,16 +28,34 @@ public class OrientationOptionsTest extends BaseTest {
     @Test
     public void parseOrientations() throws Exception {
         OrientationOptions options = OrientationOptions.parse(create("default", "landscape", "portrait"));
-        assertThat(options.orientations[0]).isEqualTo(Orientation.Default);
-        assertThat(options.orientations[1]).isEqualTo(Orientation.Landscape);
-        assertThat(options.orientations[2]).isEqualTo(Orientation.Portrait);
+        assertThat(options.orientations.get(0)).isEqualTo(Orientation.Default);
+        assertThat(options.orientations.get(1)).isEqualTo(Orientation.Landscape);
+        assertThat(options.orientations.get(2)).isEqualTo(Orientation.Portrait);
+    }
+
+    @Test
+    public void parseSingleOrientation() throws Exception {
+        OrientationOptions options = OrientationOptions.parse(create("landscape"));
+        assertThat(options.orientations.get(0)).isEqualTo(Orientation.Landscape);
+    }
+
+    @Test
+    public void landscapePortrait_regardedAsUserOrientation() throws Exception {
+        OrientationOptions options = OrientationOptions.parse(create("landscape", "portrait"));
+        assertThat(options.getValue()).isEqualTo(Orientation.PortraitLandscape.orientationCode);
+    }
+
+    @Test
+    public void portraitLandscape_regardedAsUserOrientation() throws Exception {
+        OrientationOptions options = OrientationOptions.parse(create("portrait", "landscape"));
+        assertThat(options.getValue()).isEqualTo(Orientation.PortraitLandscape.orientationCode);
     }
 
     @Test
     public void unsupportedOrientationsAreIgnored() throws Exception {
         OrientationOptions options = OrientationOptions.parse(create("default", "autoRotate"));
         assertThat(options.orientations).hasSize(1);
-        assertThat(options.orientations[0]).isEqualTo(Orientation.Default);
+        assertThat(options.orientations.get(0)).isEqualTo(Orientation.Default);
     }
 
     @Test
@@ -44,7 +64,13 @@ public class OrientationOptionsTest extends BaseTest {
         assertThat(options.getValue()).isEqualTo(Orientation.Default.orientationCode);
     }
 
-    private JSONArray create(String... orientations) {
-        return new JSONArray(Arrays.asList(orientations));
+    private JSONObject create(String... orientations) {
+        JSONObject orientation = new JSONObject();
+        try {
+            orientation.putOpt("orientation", orientations.length > 1 ? new JSONArray(Arrays.asList(orientations)) : orientations[0]);
+        } catch (JSONException e) {
+            throw new RuntimeException("Unable to create orientation object");
+        }
+        return orientation;
     }
 }

lib/ios/RNNNavigationOptions.m

@@ -41,11 +41,24 @@ const NSInteger TOP_BAR_TRANSPARENT_TAG = 78264803;
 	for (id key in otherOptions) {
 		if ([self hasProperty:key]) {
 			if ([[self valueForKey:key] isKindOfClass:[RNNOptions class]]) {
-			RNNOptions* options = [self valueForKey:key];
-			[options mergeWith:[otherOptions objectForKey:key]];
-		} else {
-			[self setValue:[otherOptions objectForKey:key] forKey:key];
-		} 		
+				RNNOptions* options = [self valueForKey:key];
+				[options mergeWith:[otherOptions objectForKey:key]];
+			} else {
+				[self setValue:[otherOptions objectForKey:key] forKey:key];
+			}
+		}
+	}
+}
+
+-(void)mergeIfEmptyWith:(NSDictionary *)otherOptions {
+	for (id key in otherOptions) {
+		if ([self hasProperty:key]) {
+			if ([[self valueForKey:key] isKindOfClass:[RNNOptions class]]) {
+				RNNOptions* options = [self valueForKey:key];
+				[options mergeIfEmptyWith:[otherOptions objectForKey:key]];
+			} else if (![self valueForKey:key]) {
+				[self setValue:[otherOptions objectForKey:key] forKey:key];
+			}
 		}
 	}
 }

lib/ios/RNNOptions.h

@@ -16,6 +16,7 @@
 
 - (instancetype)initWithDict:(NSDictionary*)dict;
 - (void)mergeWith:(NSDictionary*)otherOptions;
+- (void)mergeIfEmptyWith:(NSDictionary*)otherOptions;
 - (void)applyOn:(UIViewController *)viewController defaultOptions:(RNNOptions*)defaultOptions;
 - (BOOL)hasProperty:(NSString*)propName;
 

lib/ios/RNNOptions.m

@@ -22,6 +22,14 @@
 	}
 }
 
+-(void)mergeIfEmptyWith:(NSDictionary *)otherOptions {
+	for (id key in otherOptions) {
+		if ([self hasProperty:key] && ![self valueForKey:key]) {
+			[self setValue:[otherOptions objectForKey:key] forKey:key];
+		}
+	}
+}
+
 - (BOOL)hasProperty:(NSString*)propName {
 	return [self respondsToSelector:NSSelectorFromString(propName)];
 }

lib/ios/RNNRootViewController.m

@@ -69,7 +69,7 @@
 }
 
 - (void)mergeOptions:(NSDictionary *)options {
-	[self.options mergeWith:options];
+	[self.options mergeIfEmptyWith:options];
 }
 
 - (void)setCustomNavigationTitleView {

playground/src/screens/WelcomeScreen.js

@@ -69,7 +69,7 @@ class WelcomeScreen extends Component {
                     },
                     options: {
                       topBar: {
-                        visible: (Platform.OS === 'android') ? true : false,
+                        visible: true,
                         title: 'React Native Navigation!'
                       }
                     }
@@ -81,6 +81,9 @@ class WelcomeScreen extends Component {
                   title: 'Tab 1',
                   icon: require('../images/one.png'),
                   testID: testIDs.FIRST_TAB_BAR_BUTTON
+                },
+                topBar: {
+                  visible: false
                 }
               }
             }