Преглед на файлове

Dismiss all modals in correct order

When more then one modal was displayed, and dismissAllModals
was called, the top most modal was dismissed until no modals
were visible. This resulted in quirky animation since user saw
all modals getting dismissed.
This commit simply changes to order in which modals are dismissed to
avoid this bug.
Guy Carmeli преди 8 години
родител
ревизия
cbeb1a02bc
променени са 1 файла, в които са добавени 3 реда и са изтрити 2 реда
  1. 3
    2
      android/app/src/main/java/com/reactnativenavigation/controllers/ModalController.java

+ 3
- 2
android/app/src/main/java/com/reactnativenavigation/controllers/ModalController.java Целия файл

@@ -31,9 +31,10 @@ public class ModalController implements ScreenStackContainer, Modal.OnModalDismi
31 31
     }
32 32
 
33 33
     public void dismissAllModals() {
34
-        while (isShowing()) {
35
-            dismissTopModal();
34
+        for (Modal modal : stack) {
35
+            modal.dismiss();
36 36
         }
37
+        stack.clear();
37 38
     }
38 39
 
39 40
     public boolean isShowing() {