Bläddra i källkod

refactor android

Daniel Zlotin 7 år sedan
förälder
incheckning
d2458fb259

+ 3
- 3
lib/android/app/src/main/java/com/reactnativenavigation/parse/LayoutFactory.java Visa fil

@@ -83,11 +83,11 @@ public class LayoutFactory {
83 83
 		NavigationOptions navigationOptions = NavigationOptions.parse(node.data.optJSONObject("navigationOptions"));
84 84
 		ContainerViewController.ContainerViewCreator viewCreator = new ContainerViewController.ContainerViewCreator() {
85 85
 			@Override
86
-			public ContainerViewController.ContainerView create(final Activity activity, final String containerName, final String containerId) {
87
-				return new ReactContainerView(activity, reactInstanceManager, containerName, containerId);
86
+			public ContainerViewController.ContainerView create(final Activity activity, final String containerId, final String containerName) {
87
+				return new ReactContainerView(activity, reactInstanceManager, containerId, containerName);
88 88
 			}
89 89
 		};
90
-		return new ContainerViewController(activity, id, name, viewCreator);
90
+		return new ContainerViewController(activity, id, name, viewCreator, navigationOptions);
91 91
 	}
92 92
 
93 93
 	private ViewController createContainerStack(LayoutNode node) {

+ 2
- 2
lib/android/app/src/main/java/com/reactnativenavigation/react/ReactContainerView.java Visa fil

@@ -15,11 +15,11 @@ public class ReactContainerView extends ReactRootView implements ContainerViewCo
15 15
 	private final String containerName;
16 16
 	private boolean attachedToReactInstance = false;
17 17
 
18
-	public ReactContainerView(final Context context, ReactInstanceManager reactInstanceManager, String containerName, String containerId) {
18
+	public ReactContainerView(final Context context, ReactInstanceManager reactInstanceManager, String containerId, String containerName) {
19 19
 		super(context);
20 20
 		this.reactInstanceManager = reactInstanceManager;
21
-		this.containerName = containerName;
22 21
 		this.containerId = containerId;
22
+		this.containerName = containerName;
23 23
 		start();
24 24
 	}
25 25
 

+ 9
- 3
lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/ContainerViewController.java Visa fil

@@ -4,10 +4,12 @@ import android.app.Activity;
4 4
 import android.support.annotation.NonNull;
5 5
 import android.view.View;
6 6
 
7
+import com.reactnativenavigation.parse.NavigationOptions;
8
+
7 9
 public class ContainerViewController extends ViewController {
8 10
 
9 11
 	public interface ContainerViewCreator {
10
-		ContainerView create(Activity activity, String containerName, String containerId);
12
+		ContainerView create(Activity activity, String containerId, String containerName);
11 13
 	}
12 14
 
13 15
 	public interface ContainerView {
@@ -24,15 +26,19 @@ public class ContainerViewController extends ViewController {
24 26
 
25 27
 	private final String containerName;
26 28
 	private final ContainerViewCreator viewCreator;
29
+	private final NavigationOptions initialNavigationOptions;
30
+
27 31
 	private ContainerView containerView;
28 32
 
29 33
 	public ContainerViewController(final Activity activity,
30 34
 	                               final String id,
31 35
 	                               final String containerName,
32
-	                               final ContainerViewCreator viewCreator) {
36
+	                               final ContainerViewCreator viewCreator,
37
+	                               final NavigationOptions initialNavigationOptions) {
33 38
 		super(activity, id);
34 39
 		this.containerName = containerName;
35 40
 		this.viewCreator = viewCreator;
41
+		this.initialNavigationOptions = initialNavigationOptions;
36 42
 	}
37 43
 
38 44
 	@Override
@@ -62,7 +68,7 @@ public class ContainerViewController extends ViewController {
62 68
 	@NonNull
63 69
 	@Override
64 70
 	protected View createView() {
65
-		containerView = viewCreator.create(getActivity(), containerName, getId());
71
+		containerView = viewCreator.create(getActivity(), getId(), containerName);
66 72
 		return containerView.asView();
67 73
 	}
68 74
 }