Fixes sideMenu.animationType (#4198)

lib/ios/RNNSideMenuController.h

@@ -16,5 +16,6 @@
 - (void)side:(MMDrawerSide)side enabled:(BOOL)enabled;
 - (void)side:(MMDrawerSide)side visible:(BOOL)visible;
 - (void)side:(MMDrawerSide)side width:(double)width;
+- (void)setAnimationType:(NSString *)animationType;
 
 @end

lib/ios/RNNSideMenuOptions.h

@@ -6,4 +6,6 @@
 @property (nonatomic, strong) RNNSideMenuSideOptions* left;
 @property (nonatomic, strong) RNNSideMenuSideOptions* right;
 
+@property (nonatomic, strong) Text* animationType;
+
 @end

lib/ios/RNNSideMenuOptions.m

@@ -8,6 +8,7 @@
 	
 	self.left = [[RNNSideMenuSideOptions alloc] initWithDict:dict[@"left"]];
 	self.right = [[RNNSideMenuSideOptions alloc] initWithDict:dict[@"right"]];
+	self.animationType = [TextParser parse:dict key:@"animationType"];
 	
 	return self;
 }

lib/ios/RNNSideMenuPresenter.m

@@ -19,6 +19,8 @@
 	[sideMenuController setAnimationVelocityLeft:[options.sideMenu.left.animationVelocity getWithDefaultValue:840.0f]];
 	[sideMenuController setAnimationVelocityRight:[options.sideMenu.right.animationVelocity getWithDefaultValue:840.0f]];
 	
+	[sideMenuController setAnimationType:[options.sideMenu.animationType getWithDefaultValue:@"door"]];
+
 	if (options.sideMenu.left.width.hasValue) {
 		[sideMenuController side:MMDrawerSideLeft width:options.sideMenu.left.width.get];
 	}
@@ -76,6 +78,10 @@
 	if (options.sideMenu.right.animationVelocity.hasValue) {
 		sideMenuController.animationVelocityRight = options.sideMenu.right.animationVelocity.get;
 	}
+	
+	if (options.sideMenu.animationType.hasValue) {
+		[sideMenuController setAnimationType:options.sideMenu.animationType.get];
+	}
 }
 
 @end

lib/ios/RNNSideMenuSideOptions.h

@@ -6,7 +6,6 @@
 @property (nonatomic, strong) Bool* visible;
 @property (nonatomic, strong) Bool* enabled;
 @property (nonatomic, strong) Double* width;
-@property (nonatomic, strong) Text* animationType;
 @property (nonatomic, strong) Bool* shouldStretchDrawer;
 @property (nonatomic, strong) Double* animationVelocity;
 

lib/ios/RNNSideMenuSideOptions.m

@@ -8,7 +8,6 @@
 	self.visible = [BoolParser parse:dict key:@"visible"];
 	self.enabled = [BoolParser parse:dict key:@"enabled"];
 	self.width = [DoubleParser parse:dict key:@"width"];
-	self.animationType = [TextParser parse:dict key:@"animationType"];
 	self.shouldStretchDrawer = [BoolParser parse:dict key:@"shouldStretchDrawer"];
 	self.animationVelocity = [DoubleParser parse:dict key:@"animationVelocity"];
 	

lib/ios/ReactNativeNavigationTests/RNNSideMenuPresenterTest.m

@@ -30,7 +30,8 @@
 	[[self.bindedViewController expect] setAnimationVelocityRight:840.0f];
 	[[self.bindedViewController reject] side:MMDrawerSideLeft width:0];
 	[[self.bindedViewController reject] side:MMDrawerSideRight width:0];
-	
+  [[self.bindedViewController expect] setAnimationType:@"door"];
+    
 	[self.uut applyOptions:self.options];
 
 	[self.bindedViewController verify];

playground/src/screens/PushedScreen.js

@@ -1,8 +1,8 @@
 const _ = require('lodash');
 const React = require('react');
-const { Component } = require('react');
-const { View, Text, Platform } = require('react-native');
-const { Navigation } = require('react-native-navigation');
+const {Component} = require('react');
+const {View, Text, Platform} = require('react-native');
+const {Navigation} = require('react-native-navigation');
 const Button = require('./Button');
 const testIDs = require('../testIDs');
 
@@ -21,6 +21,7 @@ class PushedScreen extends Component {
           testID: testIDs.TOP_BAR_BUTTON
         },
         rightButtonColor: 'red',
+       noBorder: true
       },
       bottomTabs: {
         visible: false
@@ -40,7 +41,7 @@ class PushedScreen extends Component {
     this.onClickPopToFirstPosition = this.onClickPopToFirstPosition.bind(this);
     this.onClickPopToRoot = this.onClickPopToRoot.bind(this);
     this.onClickSetStackRoot = this.onClickSetStackRoot.bind(this);
-    this.state = { disabled: false };
+    this.state = {disabled: false};
   }
 
   simulateLongRunningTask() {
@@ -54,7 +55,7 @@ class PushedScreen extends Component {
     this.listeners.push(
       Navigation.events().registerComponentDidAppearListener((event) => {
         if (this.state.previewComponentId === event.componentId) {
-          this.setState({ disabled: event.type === 'ComponentDidAppear' });
+          this.setState({disabled: event.type === 'ComponentDidAppear'});
         }
       })
     );
@@ -94,7 +95,7 @@ class PushedScreen extends Component {
     );
   }
 
-  onClickShowPreview = async ({ reactTag }) => {
+  onClickShowPreview = async ({reactTag}) => {
     await Navigation.push(this.props.componentId, {
       component: {
         name: 'navigation.playground.PushedScreen',

playground/src/screens/WelcomeScreen.js

@@ -23,7 +23,10 @@ class WelcomeScreen extends Component {
           visible: false,
         },
         drawBehind: true,
-        visible: false,
+        background: {
+          color: 'transparent'
+        },
+        visible: true,
         animate: false
       }
     };