Address react conditions around ViewController.destroy (#5162)

Closes #5157

lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/ChildController.java

@@ -68,6 +68,7 @@ public abstract class ChildController<T extends ViewGroup> extends ViewControlle
             performOnParentController(parent -> parent.onChildDestroyed((Component) getView()));
         }
         super.destroy();
+        childRegistry.onChildDestroyed(this);
     }
 
     protected boolean isRoot() {

lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/ChildControllersRegistry.java

@@ -25,4 +25,8 @@ public class ChildControllersRegistry {
     public int size() {
         return children.size();
     }
+
+    public void onChildDestroyed(ChildController child) {
+        children.remove(child);
+    }
 }

lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/ViewController.java

@@ -268,7 +268,7 @@ public abstract class ViewController<T extends ViewGroup> implements ViewTreeObs
         }
     }
 
-    protected void onAttachToParent() {
+    public void onAttachToParent() {
 
     }
 

lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/stack/StackController.java

@@ -58,6 +58,7 @@ public class StackController extends ParentController<StackLayout> {
     @Override
     public boolean isRendered() {
         if (isEmpty()) return false;
+        if (getCurrentChild().isDestroyed()) return false;
         ViewGroup currentChild = getCurrentChild().getView();
         if (currentChild instanceof Component) {
             return super.isRendered() && presenter.isRendered((Component) currentChild);
@@ -78,7 +79,7 @@ public class StackController extends ParentController<StackLayout> {
 
     @Override
     public void onAttachToParent() {
-        if (!isViewShown() && !isEmpty()) {
+        if (!isEmpty() && !getCurrentChild().isDestroyed() && !isViewShown()) {
             presenter.applyChildOptions(resolveCurrentOptions(), (Component) getCurrentChild().getView());
         }
     }

lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/child/ChildControllerTest.java

@@ -78,4 +78,10 @@ public class ChildControllerTest extends BaseTest {
         uut.mergeOptions(Options.EMPTY);
         verify(presenter, times(0)).mergeOptions(any(), any());
     }
+
+    @Test
+    public void destroy() {
+        uut.destroy();
+        verify(childRegistry).onChildDestroyed(uut);
+    }
 }

lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/child/ChildControllersRegistryTest.java

@@ -44,4 +44,10 @@ public class ChildControllersRegistryTest extends BaseTest {
         verify(child1, times(1)).onViewBroughtToFront();
         assertThat(uut.size()).isOne();
     }
+
+    @Test
+    public void onChildDestroyed() {
+        child1.destroy();
+        assertThat(uut.size()).isEqualTo(0);
+    }
 }

lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/stack/StackControllerTest.java

@@ -1057,24 +1057,39 @@ public class StackControllerTest extends BaseTest {
         verify(presenter).applyChildOptions(any(), eq(component));
     }
 
+    @Test
+    public void onAttachToParent_doesNotCrashWhenCalledAfterDestroy() {
+        Robolectric.getForegroundThreadScheduler().pause();
+        StackController spy = spy(createStack());
+
+        StackLayout view = spy.getView();
+        spy.push(child1, new CommandListenerAdapter());
+        activity.setContentView(view);
+
+        child1.destroy();
+        ShadowLooper.idleMainLooper();
+
+        verify(spy).onAttachToParent();
+    }
+
     private void assertContainsOnlyId(String... ids) {
         assertThat(uut.size()).isEqualTo(ids.length);
         assertThat(uut.getChildControllers()).extracting((Extractor<ViewController, String>) ViewController::getId).containsOnly(ids);
     }
 
     private StackController createStack() {
-        return createStack("stack", new ArrayList<>());
+        return createStackBuilder("stack", new ArrayList<>()).build();
     }
 
     private StackController createStack(String id) {
-        return createStack(id, new ArrayList<>());
+        return createStackBuilder(id, new ArrayList<>()).build();
     }
 
     private StackController createStack(List<ViewController> children) {
-        return createStack("stack", children);
+        return createStackBuilder("stack", children).build();
     }
 
-    private StackController createStack(String id, List<ViewController> children) {
+    private StackControllerBuilder createStackBuilder(String id, List<ViewController> children) {
         createTopBarController();
         return TestUtils.newStackController(activity)
                 .setChildren(children)
@@ -1083,8 +1098,7 @@ public class StackControllerTest extends BaseTest {
                 .setChildRegistry(childRegistry)
                 .setAnimator(animator)
                 .setStackPresenter(presenter)
-                .setBackButtonHelper(backButtonHelper)
-                .build();
+                .setBackButtonHelper(backButtonHelper);
     }
 
     private void createTopBarController() {