changed hidden props to visible (#2704)

lib/ios/RNNBottomTabsOptions.h

@@ -2,7 +2,7 @@
 
 @interface RNNBottomTabsOptions : RNNOptions
 
-@property (nonatomic, strong) NSNumber* hidden;
+@property (nonatomic, strong) NSNumber* visible;
 @property (nonatomic, strong) NSNumber* animateHide;
 @property (nonatomic, strong) NSNumber* currentTabIndex;
 @property (nonatomic, strong) NSString* testID;

lib/ios/RNNBottomTabsOptions.m

@@ -13,8 +13,8 @@ extern const NSInteger BLUR_TOPBAR_TAG;
 		[(RNNTabBarController*)viewController.tabBarController setSelectedIndexByComponentID:self.currentTabId];
 	}
 	
-	if (self.hidden) {
-		[((RNNTabBarController *)viewController.tabBarController) setTabBarHidden:[self.hidden boolValue] animated:[self.animateHide boolValue]];
+	if (self.visible) {
+		[((RNNTabBarController *)viewController.tabBarController) setTabBarHidden:![self.visible boolValue] animated:[self.animateHide boolValue]];
 	}
 	
 	if (self.testID) {

lib/ios/RNNRootViewController.m

@@ -101,8 +101,8 @@
 
 - (BOOL)hidesBottomBarWhenPushed
 {
-	if (self.options.bottomTabs && self.options.bottomTabs.hidden) {
-		return [self.options.bottomTabs.hidden boolValue];
+	if (self.options.bottomTabs && self.options.bottomTabs.visible) {
+		return ![self.options.bottomTabs.visible boolValue];
 	}
 	return NO;
 }

lib/ios/RNNTopBarOptions.h

@@ -8,7 +8,7 @@
 @property (nonatomic, strong) NSNumber* textColor;
 @property (nonatomic, strong) NSString* title;
 @property (nonatomic, strong) NSString* textFontFamily;
-@property (nonatomic, strong) NSNumber* hidden;
+@property (nonatomic, strong) NSNumber* visible;
 @property (nonatomic, strong) NSNumber* hideOnScroll;
 @property (nonatomic, strong) NSNumber* buttonColor;
 @property (nonatomic, strong) NSNumber* translucent;

lib/ios/RNNTopBarOptions.m

@@ -62,8 +62,8 @@ extern const NSInteger BLUR_TOPBAR_TAG;
 	}
 	
 	
-	if (self.hidden){
-		[viewController.navigationController setNavigationBarHidden:[self.hidden boolValue] animated:[self.animateHide boolValue]];
+	if (self.visible) {
+		[viewController.navigationController setNavigationBarHidden:![self.visible boolValue] animated:[self.animateHide boolValue]];
 	}
 	
 	if (self.hideOnScroll) {

lib/ios/ReactNativeNavigationTests/RNNRootViewControllerTest.m

@@ -79,7 +79,7 @@
 
 - (void)testStatusBarHideWithTopBar_false {
 	self.options.statusBarHideWithTopBar = @(0);
-	self.options.topBar.hidden = @(1);
+	self.options.topBar.visible = @(0);
 	__unused UINavigationController* nav = [[UINavigationController alloc] initWithRootViewController:self.uut];
 	[self.uut viewWillAppear:false];
 	
@@ -88,7 +88,7 @@
 
 - (void)testStatusBarHideWithTopBar_true {
 	self.options.statusBarHideWithTopBar = @(1);
-	self.options.topBar.hidden = @(1);
+	self.options.topBar.visible = @(0);
 	__unused UINavigationController* nav = [[UINavigationController alloc] initWithRootViewController:self.uut];
 	[self.uut viewWillAppear:false];
 
@@ -471,7 +471,7 @@
 
 
 - (void)testTabBarHidden_true {
-	self.options.bottomTabs.hidden = @(1);
+	self.options.bottomTabs.visible = @(0);
 	__unused UINavigationController* nav = [[UINavigationController alloc] initWithRootViewController:self.uut];
 	[self.uut viewWillAppear:false];
 
@@ -479,7 +479,7 @@
 }
 
 - (void)testTabBarHidden_false {
-	self.options.bottomTabs.hidden = @(0);
+	self.options.bottomTabs.visible = @(1);
 	__unused UINavigationController* nav = [[UINavigationController alloc] initWithRootViewController:self.uut];
 	[self.uut viewWillAppear:false];
 

playground/src/screens/OptionsScreen.js

@@ -18,7 +18,7 @@ class OptionsScreen extends Component {
         textColor: 'black',
         drawUnder: false,
         largeTitle: false,
-        hidden: false,
+        visible: true,
         textFontSize: 16,
         textFontFamily: 'HelveticaNeue-Italic',
         testID: testIDs.TOP_BAR_ELEMENT,
@@ -162,7 +162,7 @@ class OptionsScreen extends Component {
   onClickShowTopBar() {
     Navigation.setOptions(this.props.componentId, {
       topBar: {
-        hidden: false,
+        visible: true,
         animateHide: true
       }
     });
@@ -171,7 +171,7 @@ class OptionsScreen extends Component {
   onClickHideTopBar() {
     Navigation.setOptions(this.props.componentId, {
       topBar: {
-        hidden: true,
+        visible: false,
         animateHide: true
       }
     });
@@ -210,7 +210,7 @@ class OptionsScreen extends Component {
   onClickPushDefaultOptionsScreen() {
     Navigation.setDefaultOptions({
       topBar: {
-        hidden: true
+        visible: false
       }
     });
 

playground/src/screens/TextScreen.js

@@ -32,8 +32,8 @@ class TextScreen extends Component {
         <Button title={'Set Tab Badge'} testID={testIDs.SET_TAB_BADGE_BUTTON} onPress={() => this.onButtonPress()} />
         <Button title={'Switch To Tab 2'} testID={testIDs.SWITCH_SECOND_TAB_BUTTON} onPress={() => this.onClickSwitchToTab()} />
         <Button title={'Switch To Tab 1 by componentID'} testID={testIDs.SWITCH_FIRST_TAB_BUTTON} onPress={() => this.onClickSwitchToTabByComponentID()} />
-        <Button title='Hide Tab Bar' testID={testIDs.HIDE_BOTTOM_TABS_BUTTON} onPress={() => this.hideTabBar(true)} />
-        <Button title='Show Tab Bar' testID={testIDs.SHOW_BOTTOM_TABS_BUTTON} onPress={() => this.hideTabBar(false)} />
+        <Button title='Hide Tab Bar' testID={testIDs.HIDE_BOTTOM_TABS_BUTTON} onPress={() => this.hideTabBar(false)} />
+        <Button title='Show Tab Bar' testID={testIDs.SHOW_BOTTOM_TABS_BUTTON} onPress={() => this.hideTabBar(true)} />
         <Button title='Show Left Side Menu' testID={testIDs.SHOW_LEFT_SIDE_MENU_BUTTON} onPress={() => this.showSideMenu('left')} />
         <Button title='Show Right Side Menu' testID={testIDs.SHOW_RIGHT_SIDE_MENU_BUTTON} onPress={() => this.showSideMenu('right')} />
         <Button title='Pop' testID={testIDs.POP_BUTTON} onPress={this.onClickPop} />
@@ -66,7 +66,7 @@ class TextScreen extends Component {
     Navigation.setOptions(this.props.componentId, {
       bottomTabs: {
         currentTabIndex: 1,
-        hidden: true,
+        visible: false,
         animateHide: true
       }
     });
@@ -80,10 +80,10 @@ class TextScreen extends Component {
     });
   }
 
-  hideTabBar(hidden) {
+  hideTabBar(visible) {
     Navigation.setOptions(this.props.componentId, {
       bottomTabs: {
-        hidden
+        visible
       }
     });
   }