setTabButton to change the label of the TabButton (#2215)

* setTabButton -> has now the property 'label' to change the label of the TabButton

* Add to documentation

* [BugFix] use i instead of 0 to check all TabItems

android/app/src/main/java/com/reactnativenavigation/views/BottomTabs.java

@@ -57,10 +57,22 @@ public class BottomTabs extends AHBottomNavigation {
     }
 
     public void setTabButton(ScreenParams params, Integer index) {
-        if (params.tabIcon != null) {
+        if (params.tabIcon != null || params.tabLabel != null) {
             AHBottomNavigationItem item = this.getItem(index);
-            item.setDrawable(params.tabIcon);
-            refresh();
+            boolean tabNeedsRefresh = false;
+
+            if (params.tabIcon != null) {
+                item.setDrawable(params.tabIcon);
+                tabNeedsRefresh = true;
+            }
+            if (params.tabLabel != null) {
+                item.setTitle(params.tabLabel);
+                tabNeedsRefresh = true;
+            }
+
+            if (tabNeedsRefresh) {
+                this.refresh();
+            }
         }
     }
 
@@ -76,7 +88,7 @@ public class BottomTabs extends AHBottomNavigation {
 
     private boolean hasTabsWithLabels() {
         for (int i = 0; i < getItemsCount(); i++) {
-            String title = getItem(0).getTitle(getContext());
+            String title = getItem(i).getTitle(getContext());
             if (!TextUtils.isEmpty(title)) {
                 return true;
             }

docs/screen-api.md

@@ -242,6 +242,7 @@ this.props.navigator.setTabButton({
   tabIndex: 0, // (optional) if missing, the icon will be added to this screen's tab
   icon: require('../img/one.png'), // local image asset for the tab icon unselected state (optional)
   selectedIcon: require('../img/one_selected.png'), // local image asset for the tab icon selected state (optional, iOS only)
+  label: 'New Label' // tab label that appears under the icon (optional)
 });
 ```
 

ios/RCCTabBarController.m

@@ -329,8 +329,8 @@
         iconImage = [RCTConvert UIImage:icon];
         iconImage = [[self image:iconImage withColor:self.tabBar.tintColor] imageWithRenderingMode:UIImageRenderingModeAlwaysOriginal];
         viewController.tabBarItem.image = iconImage;
-      
       }
+      
       UIImage *iconImageSelected = nil;
       id selectedIcon = actionParams[@"selectedIcon"];
       if (selectedIcon && selectedIcon != (id)[NSNull null])
@@ -338,6 +338,12 @@
         iconImageSelected = [RCTConvert UIImage:selectedIcon];
         viewController.tabBarItem.selectedImage = iconImageSelected;
       }
+      
+      id label = actionParams[@"label"];
+      if (label && label != (id)[NSNull null])
+      {
+        viewController.tabBarItem.title = label;
+      }
     }
   }
   

src/deprecated/platformSpecificDeprecated.ios.js

@@ -441,14 +441,16 @@ function navigatorSetTabButton(navigator, params) {
     Controllers.TabBarControllerIOS(controllerID + '_tabs').setTabButton({
       tabIndex: params.tabIndex,
       icon: params.icon,
-      selectedIcon: params.selectedIcon
+      selectedIcon: params.selectedIcon,
+      label: params.label,
     });
   } else {
     Controllers.TabBarControllerIOS(controllerID + '_tabs').setTabButton({
       contentId: navigator.navigatorID,
       contentType: 'NavigationControllerIOS',
       icon: params.icon,
-      selectedIcon: params.selectedIcon
+      selectedIcon: params.selectedIcon,
+      label: params.label,
     });
   }
 }