Pārlūkot izejas kodu

Pop modal stack on back press

Guy Carmeli 6 gadus atpakaļ
vecāks
revīzija
fd8cda2c51

+ 10
- 1
AndroidE2E/app/src/androidTest/java/com/reactnativenavigation/e2e/androide2e/ModalsTest.java Parādīt failu

114
     public void pushIntoModal() throws Exception {
114
     public void pushIntoModal() throws Exception {
115
         elementByText("SHOW MODAL").click();
115
         elementByText("SHOW MODAL").click();
116
         elementByText("PUSH SCREEN").click();
116
         elementByText("PUSH SCREEN").click();
117
-        assertExists(By.text("Pushed from modal"));
117
+        assertExists(By.text("Pushed Screen"));
118
+    }
119
+
120
+    @Test
121
+    public void backPopsModalStack() throws Exception {
122
+        elementByText("SHOW MODAL").click();
123
+        elementByText("PUSH SCREEN").click();
124
+        elementByText("PUSH").click();
125
+        device().pressBack();
126
+        assertExists(By.text("Pushed Screen"));
118
     }
127
     }
119
 }
128
 }

+ 18
- 2
lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/ModalStack.java Parādīt failu

1
 package com.reactnativenavigation.viewcontrollers;
1
 package com.reactnativenavigation.viewcontrollers;
2
 
2
 
3
 import android.app.Dialog;
3
 import android.app.Dialog;
4
+import android.content.DialogInterface;
4
 import android.support.annotation.Nullable;
5
 import android.support.annotation.Nullable;
6
+import android.view.KeyEvent;
5
 import android.view.View;
7
 import android.view.View;
6
 
8
 
7
 import com.facebook.react.bridge.Promise;
9
 import com.facebook.react.bridge.Promise;
65
         return modal != null ? modal.viewController : null;
67
         return modal != null ? modal.viewController : null;
66
     }
68
     }
67
 
69
 
68
-    private static class Modal {
70
+    private static class Modal implements DialogInterface.OnKeyListener {
69
 		public final ViewController viewController;
71
 		public final ViewController viewController;
70
 		private final Dialog dialog;
72
 		private final Dialog dialog;
71
 
73
 
72
 		Modal(final ViewController viewController) {
74
 		Modal(final ViewController viewController) {
73
 			this.viewController = viewController;
75
 			this.viewController = viewController;
74
 			dialog = new Dialog(viewController.getActivity(), R.style.Modal);
76
 			dialog = new Dialog(viewController.getActivity(), R.style.Modal);
77
+			dialog.setOnKeyListener(this);
75
 		}
78
 		}
76
 
79
 
77
 		void show() {
80
 		void show() {
92
 			View decorView = viewController.getActivity().getWindow().getDecorView();
95
 			View decorView = viewController.getActivity().getWindow().getDecorView();
93
 			viewController.getView().measure(makeMeasureSpec(decorView.getMeasuredWidth(), EXACTLY), makeMeasureSpec(decorView.getMeasuredHeight(), EXACTLY));
96
 			viewController.getView().measure(makeMeasureSpec(decorView.getMeasuredWidth(), EXACTLY), makeMeasureSpec(decorView.getMeasuredHeight(), EXACTLY));
94
 		}
97
 		}
95
-	}
98
+
99
+        @Override
100
+        public boolean onKey(DialogInterface dialog, int keyCode, KeyEvent event) {
101
+            if (keyCode == KeyEvent.KEYCODE_BACK) {
102
+                if (event.getAction() == KeyEvent.ACTION_UP) {
103
+                    if (viewController.handleBack()) {
104
+                        return true;
105
+                    }
106
+                    dialog.dismiss();
107
+                }
108
+            }
109
+            return false;
110
+        }
111
+    }
96
 }
112
 }

+ 1
- 1
lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/Navigator.java Parādīt failu

36
 	@NonNull
36
 	@NonNull
37
 	@Override
37
 	@Override
38
 	public Collection<ViewController> getChildControllers() {
38
 	public Collection<ViewController> getChildControllers() {
39
-		return root == null ? Collections.<ViewController>emptyList() : Collections.singletonList(root);
39
+		return root == null ? Collections.emptyList() : Collections.singletonList(root);
40
 	}
40
 	}
41
 
41
 
42
 	@Override
42
 	@Override

+ 6
- 6
lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/NavigatorTest.java Parādīt failu

94
 		StackController stack2 = newStack();
94
 		StackController stack2 = newStack();
95
 		stack1.push(child1);
95
 		stack1.push(child1);
96
 		stack2.push(child2);
96
 		stack2.push(child2);
97
-		bottomTabsController.setTabs(Arrays.<ViewController>asList(stack1, stack2));
97
+		bottomTabsController.setTabs(Arrays.asList(stack1, stack2));
98
 		uut.setRoot(bottomTabsController);
98
 		uut.setRoot(bottomTabsController);
99
 
99
 
100
 		SimpleViewController newChild = new SimpleViewController(activity, "new child");
100
 		SimpleViewController newChild = new SimpleViewController(activity, "new child");
121
 		stack2.push(child2);
121
 		stack2.push(child2);
122
 		stack2.push(child3);
122
 		stack2.push(child3);
123
 		stack2.push(child4);
123
 		stack2.push(child4);
124
-		bottomTabsController.setTabs(Arrays.<ViewController>asList(stack1, stack2));
124
+		bottomTabsController.setTabs(Arrays.asList(stack1, stack2));
125
 		uut.setRoot(bottomTabsController);
125
 		uut.setRoot(bottomTabsController);
126
 
126
 
127
 		uut.pop("child4");
127
 		uut.pop("child4");
138
 		stack2.push(child2);
138
 		stack2.push(child2);
139
 		stack2.push(child3);
139
 		stack2.push(child3);
140
 		stack2.push(child4);
140
 		stack2.push(child4);
141
-		bottomTabsController.setTabs(Arrays.<ViewController>asList(stack1, stack2));
141
+		bottomTabsController.setTabs(Arrays.asList(stack1, stack2));
142
 		uut.setRoot(bottomTabsController);
142
 		uut.setRoot(bottomTabsController);
143
 
143
 
144
 		uut.popSpecific(child2.getId());
144
 		uut.popSpecific(child2.getId());
156
 		stack2.push(child3);
156
 		stack2.push(child3);
157
 		stack2.push(child4);
157
 		stack2.push(child4);
158
 		stack2.push(child5);
158
 		stack2.push(child5);
159
-		bottomTabsController.setTabs(Arrays.<ViewController>asList(stack1, stack2));
159
+		bottomTabsController.setTabs(Arrays.asList(stack1, stack2));
160
 		uut.setRoot(bottomTabsController);
160
 		uut.setRoot(bottomTabsController);
161
 
161
 
162
 		uut.popTo(child2.getId());
162
 		uut.popTo(child2.getId());
175
 		stack2.push(child4);
175
 		stack2.push(child4);
176
 		stack2.push(child5);
176
 		stack2.push(child5);
177
 
177
 
178
-		bottomTabsController.setTabs(Arrays.<ViewController>asList(stack1, stack2));
178
+		bottomTabsController.setTabs(Arrays.asList(stack1, stack2));
179
 		uut.setRoot(bottomTabsController);
179
 		uut.setRoot(bottomTabsController);
180
 
180
 
181
 		uut.popToRoot(child3.getId());
181
 		uut.popToRoot(child3.getId());
272
 		stack2.push(child2);
272
 		stack2.push(child2);
273
 		stack2.push(child3);
273
 		stack2.push(child3);
274
 		stack2.push(child4);
274
 		stack2.push(child4);
275
-		bottomTabsController.setTabs(Arrays.<ViewController>asList(stack1, stack2));
275
+		bottomTabsController.setTabs(Arrays.asList(stack1, stack2));
276
 		uut.setRoot(bottomTabsController);
276
 		uut.setRoot(bottomTabsController);
277
 
277
 
278
 		uut.pop("child4", new MockPromise() {
278
 		uut.pop("child4", new MockPromise() {

+ 1
- 1
playground/src/containers/ModalScreen.js Parādīt failu

83
 
83
 
84
   onClickPushScreen() {
84
   onClickPushScreen() {
85
     Navigation.push(this.props.containerId, {
85
     Navigation.push(this.props.containerId, {
86
-      name: `navigation.playground.TextScreen`,
86
+      name: `navigation.playground.PushedScreen`,
87
       passProps: {
87
       passProps: {
88
         text: 'Pushed from modal'
88
         text: 'Pushed from modal'
89
       }
89
       }