Fix YellowBox handling in TopBar components on RN >= 0.56

This commit includes two fixes to YellowBox handling:

1. RN started throwing exceptions when views added in JSX were removed from hierarchy.
    We could probably use UiManager to fiddle around with the yellow box, either removing it or making
    it hidden and allow touch events to pass through it. For now, we continue removing yellow boxes from hierarchy
    and we replace the removed yellow boxed with dummy views.
2. A “Dismiss All” button was recently added, we remove that as well.

Fixes #4035

e2e/ScreenStyle.test.js

@@ -184,7 +184,7 @@ describe('screen style', () => {
     await expect(elementById(testIDs.TOP_BAR_BUTTON)).toBeVisible();
   });
 
-  test(':android: Popping screen with yellow box in button, title and background components should not crash', async () => {
+  test('Popping screen with yellow box in button, title and background components should not crash', async () => {
     await elementById(testIDs.PUSH_OPTIONS_BUTTON).tap();
     await elementById(testIDs.SHOW_YELLOW_BOX).tap();
     Android.pressBack();

lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/YellowBoxDelegate.java

@@ -4,11 +4,14 @@ import android.support.annotation.RestrictTo;
 import android.view.View;
 import android.view.ViewGroup;
 
+import java.util.ArrayList;
+import java.util.List;
+
 public class YellowBoxDelegate {
     private ViewGroup parent;
-    private View yellowBox;
     private YellowBoxHelper yellowBoxHelper;
     private boolean isDestroyed;
+    private ArrayList<View> yellowBoxViews = new ArrayList<>();
 
     public YellowBoxDelegate() {
         this.yellowBoxHelper = new YellowBoxHelper();
@@ -18,33 +21,39 @@ public class YellowBoxDelegate {
         this.yellowBoxHelper = yellowBoxHelper;
     }
 
-    @RestrictTo(RestrictTo.Scope.TESTS)
-    public ViewGroup getParent() {
-        return parent;
-    }
-
-    @RestrictTo(RestrictTo.Scope.TESTS)
-    public View getYellowBox() {
-        return yellowBox;
-    }
-
     public void onChildViewAdded(View parent, View child) {
         if (yellowBoxHelper.isYellowBox(parent, child)) {
-            onYellowBoxAdded(parent, child);
+            onYellowBoxAdded(parent);
         }
     }
 
-    protected void onYellowBoxAdded(View parent, View yellowBox) {
+    void onYellowBoxAdded(View parent) {
         if (isDestroyed) return;
-        this.yellowBox = yellowBox;
         this.parent = (ViewGroup) parent;
-        this.parent.removeView(yellowBox);
+
+        for (int i = 1; i < this.parent.getChildCount(); i++) {
+            yellowBoxViews.add(this.parent.getChildAt(i));
+            this.parent.removeView(this.parent.getChildAt(i));
+            this.parent.addView(new View(parent.getContext()), i);
+        }
     }
 
     public void destroy() {
         isDestroyed = true;
-        if (yellowBox != null) {
-            parent.addView(yellowBox);
+        if (!yellowBoxViews.isEmpty()) {
+            for (View view : yellowBoxViews) {
+                parent.addView(view);
+            }
         }
     }
+
+    @RestrictTo(RestrictTo.Scope.TESTS)
+    public ViewGroup getParent() {
+        return parent;
+    }
+
+    @RestrictTo(RestrictTo.Scope.TESTS)
+    public List<View> getYellowBoxes() {
+        return yellowBoxViews;
+    }
 }

lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/YellowBoxHelper.java

@@ -13,8 +13,8 @@ public class YellowBoxHelper {
     public boolean isYellowBox(View parent, View child) {
         return parent instanceof ViewGroup &&
                child instanceof ViewGroup &&
-                ((ViewGroup) parent).getChildCount() > 1 &&
-               !ViewUtils.findChildrenByClassRecursive(((ViewGroup) child), View.class, YellowBackgroundMather()).isEmpty();
+               ((ViewGroup) parent).getChildCount() > 1 &&
+               !ViewUtils.findChildrenByClassRecursive((ViewGroup) child, View.class, YellowBackgroundMather()).isEmpty();
     }
 
     @NonNull

lib/android/app/src/reactNative57/java/com/reactnativenavigation/react/NavigationReactNativeHost.java

@@ -35,7 +35,6 @@ public class NavigationReactNativeHost extends ReactNativeHost implements Bundle
         }
     };
 
-
     public NavigationReactNativeHost(NavigationApplication application) {
         this(application, application.isDebug(), application.createAdditionalReactPackages());
     }

lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/YellowBoxDelegateTest.java

@@ -26,25 +26,26 @@ public class YellowBoxDelegateTest extends BaseTest {
         parent = new FrameLayout(context);
         yellowBoxHelper = Mockito.mock(YellowBoxHelper.class);
         uut = new YellowBoxDelegate(yellowBoxHelper);
+        parent.addView(new View(context)); // We assume view at index 0 is not a yellow box
         parent.addView(yellowBox);
     }
 
     @Test
     public void onYellowBoxAdded_removedFromParent() {
-        uut.onYellowBoxAdded(parent, yellowBox);
+        uut.onYellowBoxAdded(parent);
         assertThat(yellowBox.getParent()).isNull();
     }
 
     @Test
     public void onYellowBoxAdded_storesRefToYellowBoxAndParent() {
-        uut.onYellowBoxAdded(parent, yellowBox);
-        assertThat(uut.getYellowBox()).isEqualTo(yellowBox);
+        uut.onYellowBoxAdded(parent);
+        assertThat(uut.getYellowBoxes()).contains(yellowBox);
         assertThat(uut.getParent()).isEqualTo(parent);
     }
 
     @Test
     public void onReactViewDestroy_yellowBoxIsAddedBackToParent() {
-        uut.onYellowBoxAdded(parent, yellowBox);
+        uut.onYellowBoxAdded(parent);
         uut.destroy();
         assertThat(yellowBox.getParent()).isEqualTo(parent);
     }
@@ -57,10 +58,10 @@ public class YellowBoxDelegateTest extends BaseTest {
 
     @Test
     public void onYellowBoxAdded_notHandledIfDelegateIsDestroyed() {
-        uut.onYellowBoxAdded(parent, yellowBox);
+        uut.onYellowBoxAdded(parent);
         uut.destroy();
 
-        uut.onYellowBoxAdded(parent, yellowBox);
+        uut.onYellowBoxAdded(parent);
         assertThat(yellowBox.getParent()).isEqualTo(parent);
     }
 }