Remove SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN flag from root layout (#3654)

The flag was initially set to prevent the root layout from being pushed down when showing full screen modals.
This isn't the right approach and it also messed up keyboard handling.
To prevent the root layout from being pushed down in this scenario we should probably handle window insets

lib/android/app/src/main/java/com/reactnativenavigation/NavigationActivity.java

@@ -8,7 +8,6 @@ import android.support.annotation.NonNull;
 import android.support.annotation.Nullable;
 import android.support.v7.app.AppCompatActivity;
 import android.view.KeyEvent;
-import android.view.View;
 
 import com.facebook.react.modules.core.DefaultHardwareBackBtnHandler;
 import com.facebook.react.modules.core.PermissionAwareActivity;
@@ -32,7 +31,6 @@ public class NavigationActivity extends AppCompatActivity implements DefaultHard
         super.onCreate(savedInstanceState);
         navigator = new Navigator(this, new ChildControllersRegistry(), new ModalStack(this), new OverlayManager());
         getReactGateway().onActivityCreated(this);
-        navigator.getView().setSystemUiVisibility(View.SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN);
         setContentView(navigator.getView());
     }
 

lib/android/app/src/main/java/com/reactnativenavigation/presentation/OptionsPresenter.java

@@ -103,8 +103,9 @@ public class OptionsPresenter {
     }
 
     private void setDrawBehindStatusBar(View view, StatusBarOptions statusBar) {
-        ((MarginLayoutParams) view.getLayoutParams()).topMargin = statusBar.drawBehind.isFalseOrUndefined() ?
-                UiUtils.getStatusBarHeight(activity) :
-                0;
+        if (statusBar.visible.isFalse()) {
+            ((MarginLayoutParams) view.getLayoutParams()).topMargin = statusBar.drawBehind.isTrue() ?
+                    0 : UiUtils.getStatusBarHeight(activity);
+        }
     }
 }

lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/ChildController.java

@@ -52,7 +52,7 @@ public abstract class ChildController<T extends ViewGroup> extends ViewControlle
 
     protected boolean isRoot() {
         return getParentController() == null &&
-               !(this instanceof Navigator) &&
+                !(this instanceof Navigator) &&
                 getView().getParent() != null;
     }
 }

lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/NavigationActivityTest.java

@@ -1,32 +0,0 @@
-package com.reactnativenavigation.viewcontrollers;
-
-import android.view.View;
-
-import com.reactnativenavigation.BaseTest;
-import com.reactnativenavigation.NavigationActivity;
-import com.reactnativenavigation.TestActivity;
-
-import org.junit.Test;
-import org.robolectric.android.controller.ActivityController;
-
-import static org.assertj.core.api.Java6Assertions.assertThat;
-
-public class NavigationActivityTest extends BaseTest {
-    private ActivityController<? extends NavigationActivity> controller;
-    private NavigationActivity uut;
-
-    @Override
-    public void beforeEach() {
-        controller = newActivityController(TestActivity.class);
-        uut = controller.get();
-    }
-
-    @Test
-    public void onCreate_setSystemUiVisibility() {
-        controller.setup();
-        assertThat(uut
-                .getNavigator()
-                .getView()
-                .getSystemUiVisibility()).isEqualTo(View.SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN);
-    }
-}

playground/android/app/src/main/AndroidManifest.xml

@@ -12,6 +12,7 @@
         <activity
             android:name=".MainActivity"
             android:configChanges="orientation|screenSize|keyboard|keyboardHidden"
+            android:windowSoftInputMode="adjustResize"
             android:label="@string/app_name"
             android:launchMode="singleTask">
             <intent-filter>

playground/src/screens/KeyboardScreen.js

@@ -0,0 +1,85 @@
+const React = require('react');
+const { Component } = require('react');
+const {
+  View,
+  ScrollView,
+  Dimensions,
+  StyleSheet,
+  Image,
+  Text,
+  Platform,
+  TouchableHighlight,
+  TextInput
+} = require('react-native');
+
+const testIDs = require('../testIDs');
+const Button = require('./Button');
+
+const { Navigation } = require('react-native-navigation');
+let screenWidth = Dimensions.get('window').width;
+const LOREM_IPSUM = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis' +
+                    'nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum' +
+                    'dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.';
+
+class KeyboardScreen extends Component {
+  static get options() {
+    return {
+      bottomTabs: {
+        drawBehind: true,
+      },
+      topBar: {
+        title: {
+          text: 'Keyboard'
+        }
+      }
+    };
+  }
+
+  render() {
+    return (
+      <View style={styles.root}>
+        <ScrollView>
+          <Image style={styles.image} source={require('../../img/2048.jpeg')} />
+          <Text style={{margin: 8}}>Keyboard e2e</Text>
+          <TextInput placeholder='Input 1'/>
+          <TextInput
+            placeholder='Input 2'
+            onFocus={this.hideTabs}
+            onBlur={this.showTabs}
+            />
+          {/* <Text>{LOREM_IPSUM}</Text> */}
+        </ScrollView>
+      </View>
+    );
+  }
+
+  hideTabs = () => {
+    Navigation.mergeOptions(this.props.componentId, {
+      bottomTabs: {
+        visible: false
+      }
+    });
+  }
+
+  showTabs = () => {
+    Navigation.mergeOptions(this.props.componentId, {
+      bottomTabs: {
+        visible: true
+      }
+    });
+  }
+}
+
+module.exports = KeyboardScreen;
+
+const styles = StyleSheet.create({
+  root: {
+    flex: 1,
+    backgroundColor: '#E3DCC3'
+  },
+  image: {
+    height: 400,
+    width: screenWidth,
+    resizeMode: 'cover'
+  }
+});

playground/src/screens/index.js

@@ -24,6 +24,7 @@ const CustomRoundedButton = require('./CustomRoundedButton');
 const TopBarBackground = require('./TopBarBackground');
 const ComplexLayout = require('./ComplexLayout');
 const SearchScreen = require('./SearchScreen');
+const KeyboardScreen = require('./KeyboardScreen');
 
 function registerScreens() {
   Navigation.registerComponent(`navigation.playground.CustomTransitionDestination`, () => CustomTransitionDestination);
@@ -51,6 +52,7 @@ function registerScreens() {
   Navigation.registerComponent('CustomRoundedButton', () => CustomRoundedButton);
   Navigation.registerComponent('TopBarBackground', () => TopBarBackground);
   Navigation.registerComponent('navigation.playground.SearchControllerScreen', () => SearchScreen);
+  Navigation.registerComponent('navigation.playground.KeyboardScreen', () => KeyboardScreen);
 }
 
 module.exports = {