- We do that in order to allow the end user to decide
wether they want to destroy the host based on who's
the one calling onDestroy.

Motivation:
When searching for the button's concrete TextView by label, if the
title has the same text as the buttons, both views are returned.

This was occuring if a title has no properties set initially, but then are configured later. The title image data would go from [NSNull null] to nil, breaking this check.

By comparing against both values, we can ensure the correct logic for all behaviors.

To save new RNN users some trouble, I've updated the recommended Obj-C that the installation guide tells us to paste over our App Delegate. I think the old one is obsolete because the #import and one of the Obj-C methods has change. Also removed a potentially misleading warning that might now cause users to wrongly blame their NPM version for trouble instead of these new changes. Anyway this new version works for me though someone might want to double check.

Removed reference to - (BOOL)application:(UIApplication *)application... The way it's worded makes it seem like you only need to overwrite what's in the function, not the entire file's code.

This is working on the screen API too, however it's not included in screen API, only on top-level screen

There's a roundabout manner of obtaining the react context on initialisation that is null on some instances (https://github.com/wix/react-native-navigation/issues/2695), including errors on startup that prevents debugging on console. (For instance, throwing an error on index before starting the app)

It is solved by sending the same context given on method onReactContextInitialized, instead of discarding it and calling getReactContext.

* for iOS

* first try for android

* iOS indent

* Android Indent

* Update platformSpecific.android.js

* Update NavigationReactModule.java

* Update NavigationCommandsHandler.java

* Update platformSpecificDeprecated.android.js

* Update platformSpecificDeprecated.ios.js

closes #2966

Test jenkins

Avoids a null pointer exception when not passing { side: "left" } to navigator.toggleDrawer() on Android

check jenkins