Spencer Kingman
59cfb6a50d
Update Installing.md (#3847 )
Fix an imprecise path name, and fix a meaningful typo `No Run --> Now run`.
6 gadus atpakaļ
Spencer Kingman
af3de1558b
Update Installing.md (#3871 )
Change `index.ios` to `index` in `AppDelegate.m`.
6 gadus atpakaļ
Birkir Rafn Guðjónsson
39c10bd934
URLs in docs are case sensitive (#3750 )
Fixing 404 not found
6 gadus atpakaļ
Guy Carmeli
a1b91cd452
Don't parse back button is json is empty
6 gadus atpakaļ
Guy Carmeli
b6520cd337
fix lint
6 gadus atpakaļ
Guy Carmeli
97b83e8124
Add YellowBoxed back to ReactRootViews before unmount
Apparently, UiImplementation doesn't like it when views disappear from hierarchy unexpectedly.
As yellow boxes are added to all ReactRootViews, we remove them from TopBar components.
When these components got unmounted, UiImplementation tried to remove the yellow box and since it
couldn't find it - it crashed.
This commit simply adds the yellow box before views are unmounted.
6 gadus atpakaļ
Raphael Hovsepyan
7ac78c2b3c
Fix setStackRoot animation documentation (#3849 )
6 gadus atpakaļ
Vahid Boreiri
6c3fb8d3e9
Fix some typo issues. (#3852 )
6 gadus atpakaļ
yogevbd
dfa6ba6c4d
Closes #3861
6 gadus atpakaļ
Guy Carmeli
fd483a00ea
Emit ModalDismissed event before resolving dismissModal promise
6 gadus atpakaļ
Guy Carmeli
5d54ed5bf9
Fix unit tests Android
Stack related options are applied only if the view is visible, for now this is a reasonable fix.
6 gadus atpakaļ
Guy Carmeli
2fb2885608
Merge child options in stack controller only if child is visible
This needs to be addressed for other ParentControllers as well
6 gadus atpakaļ
Guy Carmeli
8948b6af0c
Restore detox timeout value
6 gadus atpakaļ
Guy Carmeli
68373759c0
Button unmount (#3856 )
Unmount buttons when corresponding screen is unmounted
Currently buttons were unmounted each time a screen was pushed to the stack.
As we're clearing props when screens are unmounted from the prop store - when a screen
was popped to - its buttons's props were undefined.
This commit changes things so that buttons are unmounted when buttons are set
using mergeOptions and when the corresponding screen is unmounted.
6 gadus atpakaļ
yogevbd
47abec7f10
Closes #3823
6 gadus atpakaļ
yogevbd
26616fc4cc
handle buttonPressed event in rootViewController
6 gadus atpakaļ
yogevbd
cc88900123
fixes crash on iOS
6 gadus atpakaļ
Shalom Yerushalmy
f66556accf
Gradle version back to 3.0.1
6 gadus atpakaļ
Shalom Yerushalmy
293d6bc195
Fix broken jenkins build status badge
6 gadus atpakaļ
Shalom Yerushalmy
d0aa2e2c0b
Update build.gradle
6 gadus atpakaļ
yogevbd
caff3b8801
Fixes button react component props
6 gadus atpakaļ
Shalom Yerushalmy
f36f5dc0c3
Downgrade gradle version from 3.1.4 to 3.1.0
6 gadus atpakaļ
Shalom Yerushalmy
ee34b86f26
Upgrade gradle from 3.0.1 to 3.1.4
6 gadus atpakaļ
yogevbd
62125f9a8f
reset badge with an empty string
6 gadus atpakaļ
Guy Carmeli
2002020aae
Emit modalDismissed event when dismissingAllModals as well
6 gadus atpakaļ
yogevbd
d4879c8cd6
remove yellow boxes on iOS
6 gadus atpakaļ
yogevbd
e50c62eb5b
Downgraded detox in order to fix e2e
6 gadus atpakaļ
Guy Carmeli
81d491f285
Temporarily fix failing e2e test on iOS
6 gadus atpakaļ
Guy Carmeli
3a327c62cb
Add ModalDismissed to supportedEvents on iOS
6 gadus atpakaļ
yogevbd
b8945a26d5
fix header alignment
6 gadus atpakaļ
Guy Carmeli
a322875c98
Rename Color to Colour
As RNN's Color is used frequently with Android's Color class, we had to use fully qualified names, the rename avoids this.
6 gadus atpakaļ
Guy Carmeli
9543b539d5
Emit modalDismissed event when modals are dismissed on Android
6 gadus atpakaļ
Guy Carmeli
5eee64a0ea
Hide YellowBox in TopBar components
6 gadus atpakaļ
yogevbd
27a6bb653f
fix custom header component
6 gadus atpakaļ
Guy Carmeli
7470f02045
Handle waitForRender when displaying Modals without animation
6 gadus atpakaļ
yogevbd
28322c71ce
fixes react component as titleView
6 gadus atpakaļ
Yogev Ben David
5162f17bef
fix custom header (#3798 )
* fix custom header
* fix e2e
6 gadus atpakaļ
Yogev Ben David
069f1a7408
Upgrade to detox 8.x.x (#3811 )
6 gadus atpakaļ
Yogev Ben David
ea00ae09e0
Detach button react view on reload (#3805 )
6 gadus atpakaļ
Guy Carmeli
64ddd95e4e
Pass defaultOptions to Stack options presenter
6 gadus atpakaļ
Guy Carmeli
93a448fe95
Apply topMargin only if defined
6 gadus atpakaļ
Guy Carmeli
319d9c8662
Always apply topMargin
Check LayoutParams before applying, set 0 topMargin if margin is not provided to reset margin.
6 gadus atpakaļ
Daniel Zlotin
c657ff9fd6
update docs
6 gadus atpakaļ
Daniel Zlotin
cf7e817f96
support for static options as a function with passProps optional argument
6 gadus atpakaļ
yogevbd
85b6dfa36a
Revert "Revert "Resolves componentId on showModal""
This reverts commit e1ee3d5f99 .
6 gadus atpakaļ
yogevbd
099ac15fbb
Revert "resolves commandId and layout on showModal"
This reverts commit f6728fc1d6 .
6 gadus atpakaļ
yogevbd
f6728fc1d6
resolves commandId and layout on showModal
6 gadus atpakaļ
yogevbd
e1ee3d5f99
Revert "Resolves componentId on showModal"
This reverts commit 2d879ccd0c .
6 gadus atpakaļ
yogevbd
2d879ccd0c
Resolves componentId on showModal
6 gadus atpakaļ
Guy Carmeli
ac10df86fd
Handle back only if root exists (#3791 )
This commit fixes a crash when hardware back button was pressed before root was set.
6 gadus atpakaļ